Consider specifying a default bitrate for VEAEncoder |
|||||||||
Issue descriptionVEAEncoder::ConfigureEncoderOnEncodingTaskRunner() takes |bits_per_second_| as it comes, but the value might be zero and, at least in Win MF encoder, that value would not work (perhaps Mac has the same problem, it's unknown). Consider writing some fall back value. [1] https://cs.chromium.org/chromium/src/content/renderer/media/video_track_recorder.cc?sq=package:chromium&dr&rcl=1482337321&l=699
,
Dec 21 2016
,
Jan 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/185c9436cfdf89c54bbfc7141bb259f709fa84f0 commit 185c9436cfdf89c54bbfc7141bb259f709fa84f0 Author: emircan <emircan@chromium.org> Date: Wed Jan 04 19:15:48 2017 Specify a default bitrate for VEAEncoder This CL adds a non-zero default bitrate for VEAEncoder. When given 0 bitrate, Media Foundation H264 HW encoder does not output any results. BUG= 676421 TEST= Tested https://rawgit.com/Miguelao/demos/master/mediarecorder.html H264 on Mac and Win. Review-Url: https://codereview.chromium.org/2611843002 Cr-Commit-Position: refs/heads/master@{#441427} [modify] https://crrev.com/185c9436cfdf89c54bbfc7141bb259f709fa84f0/content/renderer/media/video_track_recorder.cc
,
Jan 4 2017
,
Jan 12 2017
,
Jan 12 2017
Since we are targeting M56 for full stable in finch experiment of MediaFoundation encoder, I should merge this as well.
,
Jan 12 2017
Your change meets the bar and is auto-approved for M56. Please go ahead and merge the CL manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e22cbf90e88a90259866b48a09f255cee687ed57 commit e22cbf90e88a90259866b48a09f255cee687ed57 Author: emircan <emircan@chromium.org> Date: Thu Jan 12 22:12:15 2017 Specify a default bitrate for VEAEncoder This CL adds a non-zero default bitrate for VEAEncoder. When given 0 bitrate, Media Foundation H264 HW encoder does not output any results. BUG= 676421 TEST= Tested https://rawgit.com/Miguelao/demos/master/mediarecorder.html H264 on Mac and Win. Review-Url: https://codereview.chromium.org/2611843002 Cr-Commit-Position: refs/heads/master@{#441427} (cherry picked from commit 185c9436cfdf89c54bbfc7141bb259f709fa84f0) NOTRY=true NOPRESUBMIT=true TBR=mcasas@chromium.org Review-Url: https://codereview.chromium.org/2628963004 Cr-Commit-Position: refs/branch-heads/2924@{#746} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/e22cbf90e88a90259866b48a09f255cee687ed57/content/renderer/media/video_track_recorder.cc
,
Jan 18 2017
,
Jan 18 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by mcasas@chromium.org
, Dec 21 2016