LNK4217 symbol import warnings in v8 cctest.exe link step in Windows component builds |
||||||
Issue descriptionOutput from the link step, with warnings configured as errors: [44/5067] LINK cctest.exe cctest.exe.pdb FAILED: cctest.exe cctest.exe.pdb C:/python_27_amd64/files/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False link.exe /nologo /OUT:./cctest.exe /PDB:./cctest.exe.pdb @./cctest.exe.rsp wasm-module-runner.obj : warning LNK4217: locally defined symbol ??0Zone@internal@v8@@QEAA@PEAVAccountingAllocator@12@PEBD@Z (public: __cdecl v8::internal::Zone::Zone(class v8::internal::AccountingAllocator *,char const *)) imported in function "int __cdecl v8::internal::wasm::testing::InterpretWasmModule(class v8::internal::Isolate *,class v8::internal::wasm::ErrorThrower *,struct v8::internal::wasm::WasmModule const *,struct v8::internal::wasm::ModuleWireBytes const &,int,struct v8::internal::wasm::WasmVal *,bool *)" (?InterpretWasmModule@testing@wasm@internal@v8@@YAHPEAVIsolate@34@PEAVErrorThrower@234@PEBUWasmModule@234@AEBUModuleWireBytes@234@HPEAUWasmVal@234@PEA_N@Z) LINK : error LNK1218: warning treated as error; no output file generated
,
Dec 21 2016
,
Dec 22 2016
,
Dec 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c868aae8f9b8d51461afff79064c75339e6ce30c commit c868aae8f9b8d51461afff79064c75339e6ce30c Author: wez <wez@chromium.org> Date: Fri Dec 23 08:09:04 2016 Use the /WX flag to have link warnings treated as errors. Link steps with warnings typically lead to working binaries, but warnings can indicate dependency issues in the codebase, slow down builds, and otherwise just make it harder to find more relevant output in build logs. This CL also adds exceptions to ignore certain linker warnings under specific configurations and targets. BUG= 659007 , 676418 , 676417, 654776 Review-Url: https://codereview.chromium.org/2581893002 Cr-Commit-Position: refs/heads/master@{#440600} [modify] https://crrev.com/c868aae8f9b8d51461afff79064c75339e6ce30c/build/config/compiler/BUILD.gn [modify] https://crrev.com/c868aae8f9b8d51461afff79064c75339e6ce30c/build/config/win/BUILD.gn [modify] https://crrev.com/c868aae8f9b8d51461afff79064c75339e6ce30c/media/BUILD.gn [modify] https://crrev.com/c868aae8f9b8d51461afff79064c75339e6ce30c/media/mojo/BUILD.gn [modify] https://crrev.com/c868aae8f9b8d51461afff79064c75339e6ce30c/media/mojo/services/BUILD.gn [modify] https://crrev.com/c868aae8f9b8d51461afff79064c75339e6ce30c/third_party/WebKit/Source/platform/BUILD.gn
,
Jan 3 2017
Note that suppression for the cctest.exe linker warning has landed, so you'll need to remove it and delete the target binary to force a re-link, to see the warning fire.
,
Feb 15 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 20 2018
,
Jan 16
Tempted to mark this as obsolete, but should build on Windows to be sure. wez@ can you still reproduce this? If not, feel free to close.
,
Jan 16
Issue trivially repros if you remove the /ignore:4217 and /ignore:4049 from the "cctest" target, so this is still an issue that needs resolving. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by w...@chromium.org
, Dec 21 2016