New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 676414 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"PermissionReporterBrowserTest.PermissionActionReporting" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Dec 21 2016

Issue description

"PermissionReporterBrowserTest.PermissionActionReporting" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 8 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyQgsSBUZsYWtlIjdQZXJtaXNzaW9uUmVwb3J0ZXJCcm93c2VyVGVzdC5QZXJtaXNzaW9uQWN0aW9uUmVwb3J0aW5nDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

This flaky test/step was previously tracked in  issue 638316 .
 
 Issue 676415  has been merged into this issue.
Components: Services>Safebrowsing
Labels: -Sheriff-Chromium
Owner: kcaratt...@chromium.org
Status: Assigned (was: Untriaged)
As seeing the dashboard, this test has been a bit flaky with FAIL/TIMEOUT/PASS.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=PermissionActionReporting

I created a CL to disable the test temporally: https://codereview.chromium.org/2598943002.

Assigned this issue to kcarattini@ as the previous issue's owner.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a0ae3b5e1dcbd5d3d8c3886ecf6b009438621c4

commit 3a0ae3b5e1dcbd5d3d8c3886ecf6b009438621c4
Author: shimazu <shimazu@chromium.org>
Date: Thu Dec 22 06:26:27 2016

Disable flaky browsertests: PermissionReporterBrowserTest

BUG= 676414 
TBR=kcarattini@chromium.org

Review-Url: https://codereview.chromium.org/2598943002
Cr-Commit-Position: refs/heads/master@{#440347}

[modify] https://crrev.com/3a0ae3b5e1dcbd5d3d8c3886ecf6b009438621c4/chrome/browser/safe_browsing/permission_reporter_browsertest.cc

Most of the errors I see are for a failing DCHECK that was changed in
https://codereview.chromium.org/2591643004

Since the test was disabled shortly after that patch was submitted, it's hard to know whether that fixed the problem.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfb349df416fa51bfdda643a08e42e2ba1527fe1

commit bfb349df416fa51bfdda643a08e42e2ba1527fe1
Author: kcarattini <kcarattini@chromium.org>
Date: Fri Jan 06 01:49:19 2017

Reenable PermissionActionReporter tests.

Ran against trybots 50 times with no issue so I suspect the issue was fixed in cr/2591643004

BUG= 676414 

Review-Url: https://codereview.chromium.org/2616793002
Cr-Commit-Position: refs/heads/master@{#441806}

[modify] https://crrev.com/bfb349df416fa51bfdda643a08e42e2ba1527fe1/chrome/browser/safe_browsing/permission_reporter_browsertest.cc

Comment 6 by vakh@chromium.org, Jan 13 2017

Labels: SafeBrowsing-Triaged
Status: Fixed (was: Assigned)

Sign in to add a comment