MD Shelf: No ripple effect when buttons on sign-in/lock screens are clicked |
||||||||||
Issue descriptionGoogle Chrome 57.0.2957.0 (Official Build) dev (64-bit) Revision 0 Platform 9107.0.0 (Official Build) dev-channel samus What steps will reproduce the problem? 1. Click on shelf buttons on sign-in/lock screens What happens instead? No ripple effect is seen. Attaching spec.
,
Jan 11 2017
+zalcorn if this is a simple fix it'd be great to get it into M56.
,
Jan 17 2017
Given the proximity to M56 stable branch, let's get this done in M57
,
Jan 30 2017
Do we have a fix for this yet? This is currently Beta blocking and those dates are coming near.
,
Feb 7 2017
alemate@ do we have a fix for this yet? The issue is open since Dec 21st and is currently Beta blocking. If there is no rush to fix this let us move this to Stable.
,
Feb 9 2017
,
Feb 14 2017
@jdufault could you take a look at this?
,
Feb 14 2017
Chatted with Tom offline. Implementing this correctly is a little tricky, because the shut down and sign out buttons are part of the lock screen webui, but the shelf buttons are native C++ views UI. I'm removing the RB-Stable so we have time to do this correctly. Loading the ripple from polymer for webui will have to be lazy loaded, otherwise showing the lock screen will take too long. This means that the ripple effect won't be active immediately. Beyond that, we would have to keep the two ripples in-sync across HTML/Views. I'd prefer to move the shut down / sign-in buttons over to a native views implementation. This removes the performance and code duplication issues described above. alemate@, do you know why these buttons were originally implemented in HTML?
,
Feb 14 2017
Re #8, if I'm not mistaken these buttons are HTML because they predate Ash (which brought in the native UI shelf and system menu). +jamescook@ to clarify any history here.
,
Feb 14 2017
I don't know all the history, but they have been WebUI for a very long time, and probably predate ash. I would also prefer a native views implementation. It could simplify the C++ shelf initialization code paths. They currently do a tricky dance of partial initialization depending on login state.
,
Mar 6 2017
,
Nov 29 2017
,
Dec 21
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by tdander...@chromium.org
, Jan 9 2017Labels: -M-57 M-56
Owner: alemate@chromium.org
Status: Assigned (was: Untriaged)