New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 676412 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

MD Shelf: No ripple effect when buttons on sign-in/lock screens are clicked

Project Member Reported by sdantul...@chromium.org, Dec 21 2016

Issue description

Google Chrome	57.0.2957.0 (Official Build) dev (64-bit)
Revision	0
Platform	9107.0.0 (Official Build) dev-channel samus

What steps will reproduce the problem?
1. Click on shelf buttons on sign-in/lock screens

What happens instead?
No ripple effect is seen.

Attaching spec.



 
Screenshot from 2016-12-21 11:48:27.png
365 KB View Download
Cc: tbuck...@chromium.org
Labels: -M-57 M-56
Owner: alemate@chromium.org
Status: Assigned (was: Untriaged)
Tom/alemate@, is this still being targeted for M-56?
Cc: zalcorn@chromium.org
+zalcorn if this is a simple fix it'd be great to get it into M56.
Labels: -Pri-2 -M-56 M-57 ReleaseBlock-Beta Pri-1
Given the proximity to M56 stable branch, let's get this done in M57
Do we have a fix for this yet? This is currently Beta blocking and those dates are coming near.
alemate@ do we have a fix for this yet? The issue is open since Dec 21st and is currently Beta blocking. If there is no rush to fix this let us move this to Stable.
Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
Cc: alemate@chromium.org
Owner: jdufault@chromium.org
@jdufault could you take a look at this?
Labels: -ReleaseBlock-Stable
Chatted with Tom offline. Implementing this correctly is a little tricky, because the shut down and sign out buttons are part of the lock screen webui, but the shelf buttons are native C++ views UI. I'm removing the RB-Stable so we have time to do this correctly.

Loading the ripple from polymer for webui will have to be lazy loaded, otherwise showing the lock screen will take too long. This means that the ripple effect won't be active immediately. Beyond that, we would have to keep the two ripples in-sync across HTML/Views.

I'd prefer to move the shut down / sign-in buttons over to a native views implementation. This removes the performance and code duplication issues described above.

alemate@, do you know why these buttons were originally implemented in HTML?
Cc: jamescook@chromium.org
Re #8, if I'm not mistaken these buttons are HTML because they predate Ash (which brought in the native UI shelf and system menu). +jamescook@ to clarify any history here.
I don't know all the history, but they have been WebUI for a very long time, and probably predate ash.

I would also prefer a native views implementation. It could simplify the C++ shelf initialization code paths. They currently do a tricky dance of partial initialization depending on login state.

Labels: -M-57 M-59
Labels: Not-Touch-Friendly-Launcher
Owner: manucornet@chromium.org
Status: Fixed (was: Assigned)
2018-12-21 16.49.51.mp4
14.4 MB View Download

Sign in to add a comment