Let Butler specify global tags. |
|||
Issue descriptionLogDog currently has the ability to apply tags to individual streams. The Butler should have a top-level "tag all streams" command-line flag that adds the supplied set of tags to all LogDog streams. This will allow the top-level Butler call (and its caller) to apply a single set of tags to all streams.
,
Dec 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/9599b0a81a599cb27ac7931dfe81b63d2cf0500a commit 9599b0a81a599cb27ac7931dfe81b63d2cf0500a Author: Dan Jacques <dnj@chromium.org> Date: Thu Dec 22 02:01:09 2016 Roll luci-go. infra/go/src/github.com/luci/luci-go: 294de93 Add Butler global tags. 464d9ab Create unbuffered Tumble entry point for LogDog. 8c47ef9 cipd: Add CIPD_CACHE_DIR env var that can be used to specify global CIPD cache. 5f34031 cipd: Optimize installation of cached packages. aadad8c Add grpc client side monitoring interceptor. c84e178 Move server-side gRPC monitoring interceptors into its own package. c5d59a0 Add bufferpool, a sync.Pool-backed pool of buffers 72a7572 Instrument HTTP transport produced by common/auth lib. 31a0a28 Revert of Use classic GAE for coordinator default frontend. (patchset #2 id:20001 of https://codereview.chromium.org/2591443002/ ) 4130c9e auth: Stop abusing oauth2.NewClient for transport extraction on GAE. bde0f94 Use classic GAE for coordinator default frontend. 66819f2 Add a way to instrument http.Client objects used by oauth2 f469f25 Use global rand.Rand instance in mathrand. fd0a102 Don't allcoate a new math/rand every request. fad4dad LogDog: Re-use Pub/Sub gRPC clients. 3f27478 Enable AppEngine profiling endpoints. 1157710 client/isolate: add --dump_json support to exparchive TBR=seanmccullough@chromium.org BUG= chromium:676409 TEST=None Change-Id: I4d93e8dc334807f55d21e0f446a9176eb728d9fa Reviewed-on: https://chromium-review.googlesource.com/422466 Reviewed-by: Daniel Jacques <dnj@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org> [modify] https://crrev.com/9599b0a81a599cb27ac7931dfe81b63d2cf0500a/DEPS
,
Dec 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/bceba2f804b5fe3202a5526c7cc8fad3959ef40d commit bceba2f804b5fe3202a5526c7cc8fad3959ef40d Author: Dan Jacques <dnj@chromium.org> Date: Thu Dec 22 17:58:20 2016 LogDog: Add Butler "-tag" for BuildBot. This adds API v3, which automatically generates global Butler tags based on BuildBot properties. BUG= chromium:676409 TEST=unit - Unit test expectations seem reasonable. Change-Id: I59139aaff11c5c7f0e753dbc314e94d6eec78984 Reviewed-on: https://chromium-review.googlesource.com/423128 Reviewed-by: Daniel Jacques <dnj@chromium.org> Reviewed-by: Sean McCullough <seanmccullough@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org> [modify] https://crrev.com/bceba2f804b5fe3202a5526c7cc8fad3959ef40d/scripts/slave/logdog_bootstrap.py [modify] https://crrev.com/bceba2f804b5fe3202a5526c7cc8fad3959ef40d/scripts/slave/unittests/logdog_bootstrap_test.py
,
Dec 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/bb802f51d2280578a1c56dce37839573c3d3e1cd commit bb802f51d2280578a1c56dce37839573c3d3e1cd Author: Sean McCullough <seanmccullough@chromium.org> Date: Thu Dec 22 21:03:18 2016 Revert "LogDog: Add Butler "-tag" for BuildBot." This reverts commit bceba2f804b5fe3202a5526c7cc8fad3959ef40d. Reason for revert: closed the infra tree with this failure: https://build.chromium.org/p/chromium.infra/builders/infra-continuous-xenial-64/builds/2648/steps/steps/logs/stdio Original change's description: > LogDog: Add Butler "-tag" for BuildBot. > > This adds API v3, which automatically generates global Butler tags based > on BuildBot properties. > > BUG= chromium:676409 > TEST=unit > - Unit test expectations seem reasonable. > > Change-Id: I59139aaff11c5c7f0e753dbc314e94d6eec78984 > Reviewed-on: https://chromium-review.googlesource.com/423128 > Reviewed-by: Daniel Jacques <dnj@chromium.org> > Reviewed-by: Sean McCullough <seanmccullough@chromium.org> > Commit-Queue: Daniel Jacques <dnj@chromium.org> > TBR=dnj@chromium.org,seanmccullough@chromium.org,chromium-reviews@chromium.org BUG= chromium:676409 NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Ibdbe730da334112bd77903f6a1bd13d6fe48f330 Reviewed-on: https://chromium-review.googlesource.com/423330 Reviewed-by: Sean McCullough <seanmccullough@chromium.org> Commit-Queue: Sean McCullough <seanmccullough@chromium.org> [modify] https://crrev.com/bb802f51d2280578a1c56dce37839573c3d3e1cd/scripts/slave/logdog_bootstrap.py [modify] https://crrev.com/bb802f51d2280578a1c56dce37839573c3d3e1cd/scripts/slave/unittests/logdog_bootstrap_test.py
,
Dec 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/6eccb06f2227ce46fdabf854eb526d10f6878efe commit 6eccb06f2227ce46fdabf854eb526d10f6878efe Author: dnj <dnj@chromium.org> Date: Thu Dec 22 23:32:31 2016 Butler: fix global tags applied to empty map. BUG= chromium:676409 TEST=None R=seanmccullough@chromium.org Review-Url: https://codereview.chromium.org/2601583002 [modify] https://crrev.com/6eccb06f2227ce46fdabf854eb526d10f6878efe/logdog/client/butler/bundler/bundler.go [modify] https://crrev.com/6eccb06f2227ce46fdabf854eb526d10f6878efe/logdog/client/butler/bundler/stream.go [modify] https://crrev.com/6eccb06f2227ce46fdabf854eb526d10f6878efe/logdog/client/butler/butler.go [modify] https://crrev.com/6eccb06f2227ce46fdabf854eb526d10f6878efe/logdog/client/butler/butler_test.go
,
Dec 22 2016
,
Dec 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/e47b1bfb1b44f13037fd98207c42bd8b7a703749 commit e47b1bfb1b44f13037fd98207c42bd8b7a703749 Author: Dan Jacques <dnj@chromium.org> Date: Thu Dec 22 23:33:54 2016 Roll luci-go. infra/go/src/github.com/luci/luci-go: 6eccb06 Butler: fix global tags applied to empty map. TBR=seanmccullough@chromium.org BUG= chromium:676409 TEST=None Change-Id: I10462c9b1321e9fc4e40fa96650fff258a4865e8 Reviewed-on: https://chromium-review.googlesource.com/423391 Reviewed-by: Daniel Jacques <dnj@chromium.org> Reviewed-by: Sean McCullough <seanmccullough@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org> [modify] https://crrev.com/e47b1bfb1b44f13037fd98207c42bd8b7a703749/DEPS
,
Dec 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/3f21933f54f1291716b014204baa3010e1faff95 commit 3f21933f54f1291716b014204baa3010e1faff95 Author: Dan Jacques <dnj@chromium.org> Date: Wed Dec 28 18:38:19 2016 Reland of: LogDog: Add Butler "-tag" for BuildBot. This adds API v3, which automatically generates global Butler tags based on BuildBot properties. BUG= chromium:676409 TEST=unit - Unit test expectations seem reasonable. Change-Id: I7b6240b79d1159f32617ceebb69648443a37cb58 Reviewed-on: https://chromium-review.googlesource.com/423257 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org> [modify] https://crrev.com/3f21933f54f1291716b014204baa3010e1faff95/scripts/slave/logdog_bootstrap.py [modify] https://crrev.com/3f21933f54f1291716b014204baa3010e1faff95/scripts/slave/unittests/logdog_bootstrap_test.py
,
Dec 28 2016
,
Jan 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/7a02e109f530c978854ea364649a286866612462 commit 7a02e109f530c978854ea364649a286866612462 Author: Dan Jacques <dnj@chromium.org> Date: Tue Jan 03 20:13:12 2017 Bump LogDog Stable, remove API v1. BUG= chromium:678045 , chromium:676409 TEST=None Change-Id: Ia18403d32ad1446707f3457501567941ce338746 Reviewed-on: https://chromium-review.googlesource.com/424131 Reviewed-by: Erik Staab <estaab@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org> [modify] https://crrev.com/7a02e109f530c978854ea364649a286866612462/scripts/slave/logdog_bootstrap.py [modify] https://crrev.com/7a02e109f530c978854ea364649a286866612462/scripts/slave/unittests/logdog_bootstrap_test.py
,
Jan 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/603490c636b1da5e2425388c0a41476e6bcf5e57 commit 603490c636b1da5e2425388c0a41476e6bcf5e57 Author: Daniel Jacques <dnj@chromium.org> Date: Wed Jan 04 23:12:31 2017 Revert "Bump LogDog Stable, remove API v1." This reverts commit 7a02e109f530c978854ea364649a286866612462. Reason for revert: Stripping more than it intended to (STEP_LOG_LINE). Original change's description: > Bump LogDog Stable, remove API v1. > > BUG= chromium:678045 , chromium:676409 > TEST=None > > Change-Id: Ia18403d32ad1446707f3457501567941ce338746 > Reviewed-on: https://chromium-review.googlesource.com/424131 > Reviewed-by: Erik Staab <estaab@chromium.org> > Commit-Queue: Daniel Jacques <dnj@chromium.org> > TBR=agable@chromium.org,dnj@chromium.org,estaab@chromium.org,chromium-reviews@chromium.org BUG= chromium:678045 , chromium:676409 NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Ia9f907df374f0dddfd8ee6b0566851a05d215004 Reviewed-on: https://chromium-review.googlesource.com/424864 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by: Daniel Jacques <dnj@chromium.org> [modify] https://crrev.com/603490c636b1da5e2425388c0a41476e6bcf5e57/scripts/slave/logdog_bootstrap.py [modify] https://crrev.com/603490c636b1da5e2425388c0a41476e6bcf5e57/scripts/slave/unittests/logdog_bootstrap_test.py
,
Jan 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/603490c636b1da5e2425388c0a41476e6bcf5e57 commit 603490c636b1da5e2425388c0a41476e6bcf5e57 Author: Daniel Jacques <dnj@chromium.org> Date: Wed Jan 04 23:12:31 2017 Revert "Bump LogDog Stable, remove API v1." This reverts commit 7a02e109f530c978854ea364649a286866612462. Reason for revert: Stripping more than it intended to (STEP_LOG_LINE). Original change's description: > Bump LogDog Stable, remove API v1. > > BUG= chromium:678045 , chromium:676409 > TEST=None > > Change-Id: Ia18403d32ad1446707f3457501567941ce338746 > Reviewed-on: https://chromium-review.googlesource.com/424131 > Reviewed-by: Erik Staab <estaab@chromium.org> > Commit-Queue: Daniel Jacques <dnj@chromium.org> > TBR=agable@chromium.org,dnj@chromium.org,estaab@chromium.org,chromium-reviews@chromium.org BUG= chromium:678045 , chromium:676409 NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Ia9f907df374f0dddfd8ee6b0566851a05d215004 Reviewed-on: https://chromium-review.googlesource.com/424864 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by: Daniel Jacques <dnj@chromium.org> [modify] https://crrev.com/603490c636b1da5e2425388c0a41476e6bcf5e57/scripts/slave/logdog_bootstrap.py [modify] https://crrev.com/603490c636b1da5e2425388c0a41476e6bcf5e57/scripts/slave/unittests/logdog_bootstrap_test.py
,
Jan 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/e21073d2085429d606223172b886a6991b78441b commit e21073d2085429d606223172b886a6991b78441b Author: Dan Jacques <dnj@chromium.org> Date: Thu Jan 05 03:19:32 2017 Re-land "Bump LogDog Stable, remove API v1." This reverts commit 603490c636b1da5e2425388c0a41476e6bcf5e57, which reverted commit 7a02e109f530c978854ea364649a286866612462. The commit was reverted due to a bug in LogDog/Annotee which stripped STEP_LOG_LINES even when tee'ing text. This bug was fixed in: https://github.com/luci/luci-go/commit/3b9b350e96778cdf0bd6381a2b3c23503faed52d The canary has passed a round of builds successfully on Infra waterfall, so let's bump it to stable again. BUG= chromium:678045 , chromium:676409 ,chromium:678412 TEST=canary - Successfully canaried a round of builds on "chromium.infra". Change-Id: I7e7734c3f3415755335bfe8959ee0df5030d162f Reviewed-on: https://chromium-review.googlesource.com/425001 Reviewed-by: Erik Staab <estaab@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org> [modify] https://crrev.com/e21073d2085429d606223172b886a6991b78441b/scripts/slave/logdog_bootstrap.py [modify] https://crrev.com/e21073d2085429d606223172b886a6991b78441b/scripts/slave/unittests/logdog_bootstrap_test.py |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Dec 22 2016