New issue
Advanced search Search tips

Issue 676399 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 707006



Sign in to add a comment

[WPT common] Move git invocations to webkitpy.common.checkout.git.Git

Project Member Reported by jeffcarp@chromium.org, Dec 21 2016

Issue description

Currently we farm out our git commands to the command line. It would be nicer to use the existing Git class in webkitpy.

Via https://codereview.chromium.org/2576353003/

As part of this work we should move any unique methods in ChromiumCommit into Git.
 
Components: Blink>Infra>Predictability
Components: -Blink>Infra
Description: Show this description
Blocking: 707006
Blocking: -657117
Components: Blink>Infra>Ecosystem
Components: -Blink>Infra>Predictability
Cc: jeffcarp@chromium.org
Owner: ----
Status: Available (was: Assigned)
Cc: robertma@chromium.org qyears...@chromium.org
Labels: Hotlist-CodeHealth
Summary: [WPT common] Move git invocations to webkitpy.common.checkout.git.Git (was: [WPT Export] Move git invocations to webkitpy.common.checkout.git.Git)
Changed the summary to include the importer as well.
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd0c516c9dbe22b47d7f4325baae0a3b411ed634

commit cd0c516c9dbe22b47d7f4325baae0a3b411ed634
Author: Robert Ma <robertma@chromium.org>
Date: Tue Nov 28 19:08:47 2017

Refactor wpt-import to use common.checkout.git

Some methods are not currently supported by common.checkout.git, and
Git.run is used in such cases for now. Later we would like to port some
of them (the reusable ones) to common.checkout.git.

Bug: 676399
Change-Id: I42459221c684f8ffeabb9991a64dea3489663d19
Reviewed-on: https://chromium-review.googlesource.com/793984
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519777}
[modify] https://crrev.com/cd0c516c9dbe22b47d7f4325baae0a3b411ed634/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
[modify] https://crrev.com/cd0c516c9dbe22b47d7f4325baae0a3b411ed634/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aaf39338eec2a22c73d372daf6c86cfeef1eea79

commit aaf39338eec2a22c73d372daf6c86cfeef1eea79
Author: Robert Ma <robertma@chromium.org>
Date: Tue Nov 28 20:43:12 2017

Revert "Refactor wpt-import to use common.checkout.git"

This reverts commit cd0c516c9dbe22b47d7f4325baae0a3b411ed634.

Reason for revert: failing on bots (Git.__init__ throws when cwd does
not yet exist.)

Original change's description:
> Refactor wpt-import to use common.checkout.git
> 
> Some methods are not currently supported by common.checkout.git, and
> Git.run is used in such cases for now. Later we would like to port some
> of them (the reusable ones) to common.checkout.git.
> 
> Bug: 676399
> Change-Id: I42459221c684f8ffeabb9991a64dea3489663d19
> Reviewed-on: https://chromium-review.googlesource.com/793984
> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
> Commit-Queue: Robert Ma <robertma@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#519777}

TBR=qyearsley@chromium.org,robertma@chromium.org

Change-Id: I692635b8a3ff57edb19ad7ee6401b0940dccce63
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 676399
Reviewed-on: https://chromium-review.googlesource.com/794570
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519822}
[modify] https://crrev.com/aaf39338eec2a22c73d372daf6c86cfeef1eea79/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
[modify] https://crrev.com/aaf39338eec2a22c73d372daf6c86cfeef1eea79/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0dc5c1b56c5a8c1010ad0cb6c9aa395f14840a2

commit e0dc5c1b56c5a8c1010ad0cb6c9aa395f14840a2
Author: Robert Ma <robertma@chromium.org>
Date: Wed Nov 29 15:17:26 2017

Reland "Refactor wpt-import to use common.checkout.git"

This is a reland of cd0c516c9dbe22b47d7f4325baae0a3b411ed634

Compared with the original CL, this one instantiates self.wpt_git
after local_wpt.fetch() to ensure local_wpt.path exists so that
Git.__init__ does not throw.

Original change's description:
> Refactor wpt-import to use common.checkout.git
>
> Some methods are not currently supported by common.checkout.git, and
> Git.run is used in such cases for now. Later we would like to port some
> of them (the reusable ones) to common.checkout.git.
>
> Bug: 676399
> Change-Id: I42459221c684f8ffeabb9991a64dea3489663d19
> Reviewed-on: https://chromium-review.googlesource.com/793984
> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
> Commit-Queue: Robert Ma <robertma@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#519777}

Bug: 676399
Change-Id: I919064f5599a1b503a9ce5db927cc6713d9f428f
Reviewed-on: https://chromium-review.googlesource.com/794610
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520115}
[modify] https://crrev.com/e0dc5c1b56c5a8c1010ad0cb6c9aa395f14840a2/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
[modify] https://crrev.com/e0dc5c1b56c5a8c1010ad0cb6c9aa395f14840a2/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py

Project Member

Comment 14 by sheriffbot@chromium.org, Nov 29

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)

Sign in to add a comment