New issue
Advanced search Search tips

Issue 676394 link

Starred by 1 user
Status: Fixed
Owner:
rtoy@chromium.org
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 684010
Blocking:
issue 623160



Sign in to add a comment

Convert AudioBufferSource tests to use testharness

Project Member Reported by rtoy@chromium.org, Dec 21 2016 
As the summary says, convert what we can to use testharness.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/593e520625209e04e23d096052ef8a8e99c992b3

commit 593e520625209e04e23d096052ef8a8e99c992b3
Author: rtoy <rtoy@chromium.org>
Date: Wed Jan 04 21:50:39 2017

Convert audiobuffersource-grain test to testharness

Manually convert test to use testharness

BUG= 676394 
TEST=audiobuffersource-grain.html

Review-Url: https://codereview.chromium.org/2595153002
Cr-Commit-Position: refs/heads/master@{#441475}

[delete] https://crrev.com/8e37fbee0ce0215ceef931e2cbb4aee343d10523/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-grain-expected.txt
[modify] https://crrev.com/593e520625209e04e23d096052ef8a8e99c992b3/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-grain.html
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee7bb192c6b0cef69ab9173df1ca589612449c63

commit ee7bb192c6b0cef69ab9173df1ca589612449c63
Author: rtoy <rtoy@chromium.org>
Date: Wed Jan 04 21:51:56 2017

Convert audiobuffersource-one-sample-loop to testharness

Manually convert test to use testharness

BUG= 676394 
TEST=audiobuffersource-one-sample-loop.html

Review-Url: https://codereview.chromium.org/2591383002
Cr-Commit-Position: refs/heads/master@{#441476}

[delete] https://crrev.com/593e520625209e04e23d096052ef8a8e99c992b3/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-one-sample-loop-expected.txt
[modify] https://crrev.com/ee7bb192c6b0cef69ab9173df1ca589612449c63/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-one-sample-loop.html

Comment 4 by rtoy@chromium.org, Jan 5 2017

Owner: rtoy@chromium.org
Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1224f7bab210549bd2110b224e5697bc29feb411

commit 1224f7bab210549bd2110b224e5697bc29feb411
Author: rtoy <rtoy@chromium.org>
Date: Fri Jan 13 19:29:16 2017

Convert audiobuffersource-playbackrate to testharness

Manually convert test to use testharness

BUG= 676394 
TEST=audiobuffersource-playbackrate.html

Review-Url: https://codereview.chromium.org/2596983002
Cr-Commit-Position: refs/heads/master@{#443635}

[delete] https://crrev.com/88e2c2a04386feceaaa40129829c15432681363d/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate-expected.txt
[modify] https://crrev.com/1224f7bab210549bd2110b224e5697bc29feb411/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate.html
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65eceecf7418a59d7ee03e32f01fbb8dede34bc6

commit 65eceecf7418a59d7ee03e32f01fbb8dede34bc6
Author: rtoy <rtoy@chromium.org>
Date: Sat Jan 21 00:33:02 2017

Convert AudioBufferSource sample-accurate-scheduling to testharness

Manually convert test to use testharness and new Audit.

BUG= 676394 
TEST=sample-accurate-scheduling.html

Review-Url: https://codereview.chromium.org/2635223004
Cr-Commit-Position: refs/heads/master@{#445227}

[delete] https://crrev.com/68c7753dd291fbf573dc67c258284440f5aad6ff/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/sample-accurate-scheduling-expected.txt
[modify] https://crrev.com/65eceecf7418a59d7ee03e32f01fbb8dede34bc6/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/sample-accurate-scheduling.html

Comment 10 by rtoy@chromium.org, Jan 23 2017 

All files in AudioBufferSource have been converted to use testharness except:

audiobuffersource.html
audiobuffersource-loop-points.html
audiobuffersource-multi-channels.html

These save the result as a wav file for comparison.  Converting to testharness means these need to be rewritten, essentially, from scratch.  

This will tracked in a separate bug; we are finished with converting AudioBufferSource to testharness.

Comment 11 by rtoy@chromium.org, Jan 23 2017

Blockedon: 684010

Comment 12 by rtoy@chromium.org, Mar 23 2017

Status: Fixed (was: Started)
AudioBufferSource/audiobuffersource.html contains a call to finishAudioTest().

We're leaving that as is so that there's still a test for finishAudioTest().
►

Sign in to add a comment