Issue metadata
Sign in to add a comment
|
Clicking on shelf ARC++ apps before container loads causes black screen and sometimes browser crash |
||||||||||||||||||||||
Issue descriptionGoogle Chrome 57.0.2957.0 (Official Build) dev (64-bit) Revision 0 Platform 9107.0.0 (Official Build) dev-channel samus What steps will reproduce the problem? (1) AU to 9107.0.0, 57.0.2957.0 build (2) Log-in to user account that already has ARC++ enabled with some apps pinned to shelf (3) Before the container loads, click on any ARC++ app from shelf What happens instead? Black screen and sometimes followed by browser crash. Crash link: https://crash.corp.google.com/browse?stbtiq=6537f0c080000000 Magic Signature: ArcAppListPrefs::IsRegistered Stable Signature: ArcAppListPrefs::IsRegistered-3d4f29ad Thread 0 CRASHED [SIGSEGV @ 0xffffe58c2738f000 ] MAGIC SIGNATURE THREAD Stack Quality98%Show frame trust levels 0x0000637c3a68cd96 (chrome -string_piece.h:186 ) ArcAppListPrefs::IsRegistered(std::string const&) const 0x0000637c3a68ce5e (chrome -arc_app_list_prefs.cc:533 ) ArcAppListPrefs::SetLastLaunchTime(std::string const&, base::Time const&) 0x0000637c3a694a21 (chrome -arc_app_utils.cc:329 ) arc::LaunchApp(content::BrowserContext*, std::string const&, bool, int) 0x0000637c3a60cabf (chrome -launcher_controller_helper.cc:182 ) LauncherControllerHelper::LaunchAppWithLaunchId(std::string const&, std::string const&, ash::LaunchSource, int) 0x0000637c3a7d4445 (chrome -app_shortcut_launcher_item_controller.cc:130 ) AppShortcutLauncherItemController::Activate(ash::LaunchSource) 0x0000637c3a4ac444 (chrome -shelf_view.cc:597 ) ash::ShelfView::ButtonPressed(views::Button*, ui::Event const&, views::InkDrop*) 0x0000637c39d0f50f (chrome -custom_button.cc:198 ) views::CustomButton::OnMouseReleased(ui::MouseEvent const&) 0x0000637c3a5033f0 (chrome -shelf_button.cc:382 ) ash::ShelfButton::OnMouseReleased(ui::MouseEvent const&) 0x0000637c39d53dcb (chrome -ink_drop_host_view.cc:262 ) views::InkDropHostView::OnMouseEvent(ui::MouseEvent*) 0x0000637c3bbec2f3 (chrome -scoped_target_handler.cc:32 ) ui::ScopedTargetHandler::OnEvent(ui::Event*) 0x0000637c393eaf76 (chrome -event_dispatcher.cc:191 ) ui::EventDispatcher::DispatchEvent(ui::EventHandler*, ui::Event*) 0x0000637c393eb360 (chrome -event_dispatcher.cc:139 ) ui::EventDispatcher::ProcessEvent(ui::EventTarget*, ui::Event*) 0x0000637c393eb446 (chrome -event_dispatcher.cc:86 ) ui::EventDispatcherDelegate::DispatchEventToTarget(ui::EventTarget*, ui::Event*) 0x0000637c393eb53f (chrome -event_dispatcher.cc:58 ) ui::EventDispatcherDelegate::DispatchEvent(ui::EventTarget*, ui::Event*) 0x0000637c39d6ebeb (chrome -root_view.cc:442 ) views::internal::RootView::OnMouseReleased(ui::MouseEvent const&) 0x0000637c39d466b0 (chrome -widget.cc:1203 ) views::Widget::OnMouseEvent(ui::MouseEvent*) 0x0000637c393eaf76 (chrome -event_dispatcher.cc:191 ) ui::EventDispatcher::DispatchEvent(ui::EventHandler*, ui::Event*) 0x0000637c393eb360 (chrome -event_dispatcher.cc:139 ) ui::EventDispatcher::ProcessEvent(ui::EventTarget*, ui::Event*) 0x0000637c393eb446 (chrome -event_dispatcher.cc:86 ) ui::EventDispatcherDelegate::DispatchEventToTarget(ui::EventTarget*, ui::Event*) 0x0000637c393eb53f (chrome -event_dispatcher.cc:58 ) ui::EventDispatcherDelegate::DispatchEvent(ui::EventTarget*, ui::Event*) 0x0000637c3bbec226 (chrome -event_processor.cc:35 ) ui::EventProcessor::OnEventFromSource(ui::Event*) 0x0000637c393ebca2 (chrome -event_source.cc:73 ) ui::EventSource::DeliverEventToProcessor(ui::Event*) 0x0000637c393ebe62 (chrome -event_source.cc:51 ) ui::EventSource::SendEventToProcessor(ui::Event*) 0x0000637c3a47bd2e (chrome -ash_window_tree_host_platform.cc:111 ) ash::AshWindowTreeHostPlatform::DispatchEvent(ui::Event*) 0x0000637c393ec832 (chrome -callback.h:85 ) ui::DispatchEventFromNativeUiEvent(void* const&, base::Callback<void (ui::Event*), (base::internal::CopyMode)1, (base::internal::RepeatMode)1>) 0x0000637c37712df4 (chrome -drm_window_host.cc:185 ) ui::DrmWindowHost::DispatchEvent(void* const&) 0x0000637c393cc47e (chrome -platform_event_source.cc:81 ) ui::PlatformEventSource::DispatchEvent(void*) 0x0000637c3955256b (chrome -event_factory_evdev.cc:356 ) ui::EventFactoryEvdev::DispatchMouseButtonEvent(ui::MouseButtonEventParams const&) 0x0000637c3729f89c (chrome -callback.h:68 ) base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) 0x0000637c372887f5 (chrome -message_loop.cc:421 ) base::MessageLoop::DoWork() 0x0000637c37289232 (chrome -message_pump_libevent.cc:218 ) base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) 0x0000637c38bf9567 (chrome -run_loop.cc:37 ) base::RunLoop::Run() 0x0000637c388e0ee5 (chrome -chrome_browser_main.cc:1987 ) ChromeBrowserMainParts::MainMessageLoopRun(int*) 0x0000637c37f36a8a (chrome -browser_main_loop.cc:1173 ) content::BrowserMainLoop::RunMainMessageLoopParts() 0x0000637c37f39844 (chrome -browser_main_runner.cc:141 ) content::BrowserMainRunnerImpl::Run() 0x0000637c37f338cb (chrome -browser_main.cc:46 ) content::BrowserMain(content::MainFunctionParams const&) 0x0000637c38881299 (chrome -content_main_runner.cc:793 ) content::ContentMainRunnerImpl::Run() 0x0000637c3887ff3a (chrome -content_main.cc:20 ) content::ContentMain(content::ContentMainParams const&) 0x0000637c3751279a (chrome -chrome_main.cc:112 ) ChromeMain 0x00007ead0aa83fb5 (libc-2.19.so -libc-start.c:292 ) __libc_start_main 0x0000637c375125c2 (chrome + 0x0123a5c2 ) _start
,
Jan 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5ab8ce0e2a1a7b6a8e3e003878768b8dc124f1e commit d5ab8ce0e2a1a7b6a8e3e003878768b8dc124f1e Author: khmel <khmel@chromium.org> Date: Wed Jan 04 01:24:24 2017 Fix memory corruption during launching an app from shortcut. This fix memory corruption crash when app is launched from shelf shortcut. TEST=Manually, crash is no longer observed. BUG= 676392 Review-Url: https://codereview.chromium.org/2612453002 Cr-Commit-Position: refs/heads/master@{#441280} [modify] https://crrev.com/d5ab8ce0e2a1a7b6a8e3e003878768b8dc124f1e/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc
,
Jan 4 2017
,
Jan 13 2017
This bug was for M57. I investigated crash reports and found that M56 is also affected (but with significantly lower rate) Fix is simple and low risk. Bug can easy be found by users. So I recommend it for M56 merge. My crash report analyzing: https://crash.corp.google.com/browse?q=product.name%3D%27Chrome_ChromeOS%27%20OMIT%20RECORD%20IF%20SUM(CrashedStackTrace.StackFrame.FunctionName%3D%27ArcAppListPrefs%3A%3AIsRegistered(std%3A%3Astring%20const%26)%20const%27)%20%3D%200%20OR%20SUM(CrashedStackTrace.StackFrame.FunctionName%3D%27AppShortcutLauncherItemController%3A%3AActivate(ash%3A%3ALaunchSource)%27)%20%3D%200%20%20OR%20SUM(CrashedStackTrace.StackFrame.FunctionName%3D%27ash%3A%3AShelfView%3A%3AButtonPressed(views%3A%3AButton*%2C%20ui%3A%3AEvent%20const%26%2C%20views%3A%3AInkDrop*)%27)%20%3D%200&ignore_case=false&enable_rewrite=false&omit_field_name=&omit_field_value=&omit_field_opt=%3D#-samplereports:5,productversion:50
,
Jan 13 2017
Your change meets the bar and is auto-approved for M56. Please go ahead and merge the CL manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be037ef6060f2d5cd5c0a12d2ccd59492bf767f4 commit be037ef6060f2d5cd5c0a12d2ccd59492bf767f4 Author: khmel <khmel@chromium.org> Date: Fri Jan 13 23:53:26 2017 [Merge M56] Fig memory corruption during launching an app from shortcut. This fix memory corruption crash when app is launched from shelf shortcut. TEST=Manually, crash is no longer observed. BUG= 676392 NOTRY=true NOPRESUBMIT=true TBR=skuhne@chromium.org Review-Url: https://codereview.chromium.org/2612453002 Cr-Commit-Position: refs/heads/master@{#441280} (cherry picked from commit d5ab8ce0e2a1a7b6a8e3e003878768b8dc124f1e) Review-Url: https://codereview.chromium.org/2631873002 Cr-Commit-Position: refs/branch-heads/2924@{#765} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/be037ef6060f2d5cd5c0a12d2ccd59492bf767f4/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc
,
Jan 13 2017
,
Jan 20 2017
Verified on 9202.0.0, 57.0.2984.0 and 9000.66.0, 56.0.2924.67 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by khmel@chromium.org
, Dec 21 2016Status: Started (was: Untriaged)