New issue
Advanced search Search tips

Issue 676391 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Download Later button seen on form resubmission confirmation page.

Project Member Reported by dewittj@chromium.org, Dec 21 2016

Issue description

Google Chrome	57.0.2950.3 (Official Build) dev (32-bit)
Revision	e67f9b3395c12f01747246a5fc44836e34b510bd-refs/branch-heads/2950@{#5}
OS	Android 7.1.1; Nexus 5X Build/NMF26F

What steps will reproduce the problem?
1. Submit a form
2. Evict Chrome, restore tab
3. See resubmission page

What is the expected result?
No download button

What happens instead of that?
Download button seen.

Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36



 
Screenshot_20161221-110608.png
136 KB View Download
Seems that we don't want to show the download button for "ERR_CACHE_MISS" pages.
Owner: jianli@chromium.org
Status: Assigned (was: Unconfirmed)
It is caused by an uncached page created by a POST. So we should also check for POST in addition to ERR_CACHE_MISS.

Working on it.
Status: Started (was: Assigned)
With more thought, I think we should not shown DOWNLOAD button for any error page resulted from a POST.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e00bb4ae7b482e3a14eaf9f46043b9e89e3dbfb1

commit e00bb4ae7b482e3a14eaf9f46043b9e89e3dbfb1
Author: jianli <jianli@chromium.org>
Date: Thu Jan 05 21:48:21 2017

Do not show DOWNLOAD PAGE LATER button for post error page

BUG= 676391 

Review-Url: https://codereview.chromium.org/2618503003
Cr-Commit-Position: refs/heads/master@{#441765}

[modify] https://crrev.com/e00bb4ae7b482e3a14eaf9f46043b9e89e3dbfb1/components/error_page/common/localized_error.cc

Status: Fixed (was: Started)

Comment 8 by ram...@chromium.org, Jan 10 2017

Status: Verified (was: Fixed)
Verified with latest M57 build on LG V20.

Sign in to add a comment