Remove base::NonThreadSafe in favor of base::SequenceChecker |
||||||
Issue descriptionSequences provide thread-safety. base::NonThreadSafe should check for sequence-affinity not thread-affinity. Will require survey of existing use cases.
,
Mar 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76880239f2fc320edf283061081b6cf323a29263 commit 76880239f2fc320edf283061081b6cf323a29263 Author: gab <gab@chromium.org> Date: Fri Mar 31 00:15:17 2017 Fix method naming in SequenceCheckerImpl::Core to match SequenceCheckerImpl::CalledOnValidSequence() BUG=676387 Review-Url: https://codereview.chromium.org/2788613004 Cr-Commit-Position: refs/heads/master@{#460946} [modify] https://crrev.com/76880239f2fc320edf283061081b6cf323a29263/base/sequence_checker_impl.cc
,
May 5 2017
,
May 24 2017
,
May 25 2017
,
May 26 2017
Here's the script I'm using, Fix() is being applied to every .h and subsequently to every .cc, .mm, .cpp file in the codebase: (I follow it with "git cl format" + fixup a few things manually based on the few things the script prints because it found an oddity + then fix compile errors for things that are really unscriptable -- e.g. NonThreadSafe::CalledOnValidThread() was public so it's impossible to find all callers, guess clang tidy could have helped ther
,
May 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e66aa55947422665d6fddaad94610ac8fc271d79 commit e66aa55947422665d6fddaad94610ac8fc271d79 Author: gab <gab@chromium.org> Date: Fri May 26 17:20:58 2017 WARN_UNUSED_RESULT on all Thread/SequenceChecker impls Discovered a few unused NonThreadSafe::CalledOnValidThread() while migrating away from it. Thankfully Thread/SequenceChecker already have WARN_UNUSED_RESULT on their main impl. Coalesce a bit further to have it everywhere. BUG=676387 Review-Url: https://codereview.chromium.org/2905213002 Cr-Commit-Position: refs/heads/master@{#475040} [modify] https://crrev.com/e66aa55947422665d6fddaad94610ac8fc271d79/base/sequence_checker.h [modify] https://crrev.com/e66aa55947422665d6fddaad94610ac8fc271d79/base/threading/thread_checker.h
,
May 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f03b5126e924f11cca9e5cc2243d29d861fc52b8 commit f03b5126e924f11cca9e5cc2243d29d861fc52b8 Author: gab <gab@chromium.org> Date: Mon May 29 18:44:37 2017 Move off of deprecated base::NonThreadSafe in device/ BUG=676387 Review-Url: https://codereview.chromium.org/2905153002 Cr-Commit-Position: refs/heads/master@{#475368} [modify] https://crrev.com/f03b5126e924f11cca9e5cc2243d29d861fc52b8/device/serial/serial_io_handler.cc [modify] https://crrev.com/f03b5126e924f11cca9e5cc2243d29d861fc52b8/device/serial/serial_io_handler.h [modify] https://crrev.com/f03b5126e924f11cca9e5cc2243d29d861fc52b8/device/serial/serial_io_handler_posix.cc [modify] https://crrev.com/f03b5126e924f11cca9e5cc2243d29d861fc52b8/device/serial/serial_io_handler_win.cc [modify] https://crrev.com/f03b5126e924f11cca9e5cc2243d29d861fc52b8/device/usb/usb_service.cc [modify] https://crrev.com/f03b5126e924f11cca9e5cc2243d29d861fc52b8/device/usb/usb_service.h [modify] https://crrev.com/f03b5126e924f11cca9e5cc2243d29d861fc52b8/device/usb/usb_service_impl.cc [modify] https://crrev.com/f03b5126e924f11cca9e5cc2243d29d861fc52b8/device/usb/usb_service_linux.cc [modify] https://crrev.com/f03b5126e924f11cca9e5cc2243d29d861fc52b8/device/usb/usb_service_win.cc
,
May 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33588a10e58a5a53909fbcc2886f71c6cb4aec07 commit 33588a10e58a5a53909fbcc2886f71c6cb4aec07 Author: gab <gab@chromium.org> Date: Mon May 29 21:54:23 2017 Deprecate NonThreadSafe in rlz in favor of SequenceChecker. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=thakis@chromium.org Review-Url: https://codereview.chromium.org/2914523003 Cr-Commit-Position: refs/heads/master@{#475386} [modify] https://crrev.com/33588a10e58a5a53909fbcc2886f71c6cb4aec07/rlz/chromeos/lib/rlz_value_store_chromeos.cc [modify] https://crrev.com/33588a10e58a5a53909fbcc2886f71c6cb4aec07/rlz/chromeos/lib/rlz_value_store_chromeos.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25894fe14877c00103c88e18ba0a57b41a076824 commit 25894fe14877c00103c88e18ba0a57b41a076824 Author: gab <gab@chromium.org> Date: Tue May 30 03:40:36 2017 Replace deprecated base::NonThreadSafe in chrome in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=thakis@chromium.org Review-Url: https://codereview.chromium.org/2911983003 Cr-Commit-Position: refs/heads/master@{#475417} [modify] https://crrev.com/25894fe14877c00103c88e18ba0a57b41a076824/chrome/browser/after_startup_task_utils.cc [modify] https://crrev.com/25894fe14877c00103c88e18ba0a57b41a076824/chrome/browser/browser_process_impl.cc [modify] https://crrev.com/25894fe14877c00103c88e18ba0a57b41a076824/chrome/browser/browser_process_impl.h [modify] https://crrev.com/25894fe14877c00103c88e18ba0a57b41a076824/chrome/browser/browser_process_platform_part_chromeos.cc [modify] https://crrev.com/25894fe14877c00103c88e18ba0a57b41a076824/chrome/browser/browser_process_platform_part_chromeos.h [modify] https://crrev.com/25894fe14877c00103c88e18ba0a57b41a076824/chrome/browser/process_singleton.h [modify] https://crrev.com/25894fe14877c00103c88e18ba0a57b41a076824/chrome/browser/process_singleton_posix.cc [modify] https://crrev.com/25894fe14877c00103c88e18ba0a57b41a076824/chrome/browser/process_singleton_startup_lock.cc [modify] https://crrev.com/25894fe14877c00103c88e18ba0a57b41a076824/chrome/browser/process_singleton_startup_lock.h [modify] https://crrev.com/25894fe14877c00103c88e18ba0a57b41a076824/chrome/browser/process_singleton_win.cc
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57fe347f98ad917c27a8b6c154c79dc42445b8f8 commit 57fe347f98ad917c27a8b6c154c79dc42445b8f8 Author: gab <gab@chromium.org> Date: Tue May 30 04:30:16 2017 Replace deprecated base::NonThreadSafe in chrome/browser/metrics/perf in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=sque@chromium.org Review-Url: https://codereview.chromium.org/2912843002 Cr-Commit-Position: refs/heads/master@{#475424} [modify] https://crrev.com/57fe347f98ad917c27a8b6c154c79dc42445b8f8/chrome/browser/metrics/perf/perf_provider_chromeos.cc [modify] https://crrev.com/57fe347f98ad917c27a8b6c154c79dc42445b8f8/chrome/browser/metrics/perf/perf_provider_chromeos.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e02b1ecd617641398e13243ae79381ddb4560cda commit e02b1ecd617641398e13243ae79381ddb4560cda Author: gab <gab@chromium.org> Date: Tue May 30 05:32:50 2017 Replace deprecated base::NonThreadSafe in content/browser/memory in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=haraken@chromium.org Review-Url: https://codereview.chromium.org/2913683002 Cr-Commit-Position: refs/heads/master@{#475431} [modify] https://crrev.com/e02b1ecd617641398e13243ae79381ddb4560cda/content/browser/memory/memory_coordinator_impl.cc [modify] https://crrev.com/e02b1ecd617641398e13243ae79381ddb4560cda/content/browser/memory/memory_coordinator_impl.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b89ad6eeb6acfbfe183815c696e53c5e243448a9 commit b89ad6eeb6acfbfe183815c696e53c5e243448a9 Author: gab <gab@chromium.org> Date: Tue May 30 06:29:02 2017 Deprecate NonThreadSafe in content/browser/streams in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=tyoshino@chromium.org Review-Url: https://codereview.chromium.org/2909123002 Cr-Commit-Position: refs/heads/master@{#475442} [modify] https://crrev.com/b89ad6eeb6acfbfe183815c696e53c5e243448a9/content/browser/streams/stream_registry.cc [modify] https://crrev.com/b89ad6eeb6acfbfe183815c696e53c5e243448a9/content/browser/streams/stream_registry.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4ade68a229ed1aa9ae1ab6552475b76acbee7e5 commit e4ade68a229ed1aa9ae1ab6552475b76acbee7e5 Author: gab <gab@chromium.org> Date: Tue May 30 07:47:10 2017 Replace deprecated base::NonThreadSafe in chrome/browser/win in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=grt@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Review-Url: https://codereview.chromium.org/2911133002 Cr-Commit-Position: refs/heads/master@{#475453} [modify] https://crrev.com/e4ade68a229ed1aa9ae1ab6552475b76acbee7e5/chrome/browser/win/jumplist.cc [modify] https://crrev.com/e4ade68a229ed1aa9ae1ab6552475b76acbee7e5/chrome/browser/win/jumplist.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e2fda8fca4cbd931958b5438fbaea32244b3068 commit 9e2fda8fca4cbd931958b5438fbaea32244b3068 Author: gab <gab@chromium.org> Date: Tue May 30 08:18:11 2017 Replace deprecated base::NonThreadSafe in chrome/browser/chromeos/settings in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=pastarmovj@chromium.org Review-Url: https://codereview.chromium.org/2910093002 Cr-Commit-Position: refs/heads/master@{#475463} [modify] https://crrev.com/9e2fda8fca4cbd931958b5438fbaea32244b3068/chrome/browser/chromeos/settings/cros_settings.cc [modify] https://crrev.com/9e2fda8fca4cbd931958b5438fbaea32244b3068/chrome/browser/chromeos/settings/cros_settings.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a8783cef052958962a9d34f8e8c6eded65b9041 commit 8a8783cef052958962a9d34f8e8c6eded65b9041 Author: gab <gab@chromium.org> Date: Tue May 30 08:28:05 2017 Replace deprecated base::NonThreadSafe in chrome/browser/profile_resetter in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=vasilii@chromium.org Review-Url: https://codereview.chromium.org/2908143004 Cr-Commit-Position: refs/heads/master@{#475465} [modify] https://crrev.com/8a8783cef052958962a9d34f8e8c6eded65b9041/chrome/browser/profile_resetter/profile_resetter.cc [modify] https://crrev.com/8a8783cef052958962a9d34f8e8c6eded65b9041/chrome/browser/profile_resetter/profile_resetter.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/febb8e88d2e3617cede29d793ca171f7a751bb88 commit febb8e88d2e3617cede29d793ca171f7a751bb88 Author: gab <gab@chromium.org> Date: Tue May 30 08:50:38 2017 Replace deprecated base::NonThreadSafe in components/sync_preferences in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=battre@chromium.org Review-Url: https://codereview.chromium.org/2912853002 Cr-Commit-Position: refs/heads/master@{#475469} [modify] https://crrev.com/febb8e88d2e3617cede29d793ca171f7a751bb88/components/sync_preferences/pref_model_associator.cc [modify] https://crrev.com/febb8e88d2e3617cede29d793ca171f7a751bb88/components/sync_preferences/pref_model_associator.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3184531f72e00e50b4e79bf0a3fe799bde9c87f6 commit 3184531f72e00e50b4e79bf0a3fe799bde9c87f6 Author: gab <gab@chromium.org> Date: Tue May 30 08:56:55 2017 Replace deprecated base::NonThreadSafe in components/reading_list in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=olivierrobin@chromium.org Review-Url: https://codereview.chromium.org/2914583002 Cr-Commit-Position: refs/heads/master@{#475471} [modify] https://crrev.com/3184531f72e00e50b4e79bf0a3fe799bde9c87f6/components/reading_list/core/reading_list_model.cc [modify] https://crrev.com/3184531f72e00e50b4e79bf0a3fe799bde9c87f6/components/reading_list/core/reading_list_model.h [modify] https://crrev.com/3184531f72e00e50b4e79bf0a3fe799bde9c87f6/components/reading_list/core/reading_list_model_impl.cc [modify] https://crrev.com/3184531f72e00e50b4e79bf0a3fe799bde9c87f6/components/reading_list/core/reading_list_store.cc [modify] https://crrev.com/3184531f72e00e50b4e79bf0a3fe799bde9c87f6/components/reading_list/core/reading_list_store.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca02aa30556a6d7d55817a34355bfe6c2e9f4fa8 commit ca02aa30556a6d7d55817a34355bfe6c2e9f4fa8 Author: gab <gab@chromium.org> Date: Tue May 30 09:04:25 2017 Replace deprecated base::NonThreadSafe in components/password_manager in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=dvadym@chromium.org Review-Url: https://codereview.chromium.org/2911993002 Cr-Commit-Position: refs/heads/master@{#475472} [modify] https://crrev.com/ca02aa30556a6d7d55817a34355bfe6c2e9f4fa8/components/password_manager/core/browser/password_syncable_service.cc [modify] https://crrev.com/ca02aa30556a6d7d55817a34355bfe6c2e9f4fa8/components/password_manager/core/browser/password_syncable_service.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f78b5b66d3637fa3d2b2b13ff2d39d98985d27f commit 2f78b5b66d3637fa3d2b2b13ff2d39d98985d27f Author: gab <gab@chromium.org> Date: Tue May 30 10:35:22 2017 Replace deprecated base::NonThreadSafe in content/public/test in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2913673002 Cr-Commit-Position: refs/heads/master@{#475486} [modify] https://crrev.com/2f78b5b66d3637fa3d2b2b13ff2d39d98985d27f/content/public/test/test_download_request_handler.cc [modify] https://crrev.com/2f78b5b66d3637fa3d2b2b13ff2d39d98985d27f/content/public/test/test_download_request_handler.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45a3dafd553e3f183e63e579686f9f4bcfb4e9dc commit 45a3dafd553e3f183e63e579686f9f4bcfb4e9dc Author: gab <gab@chromium.org> Date: Tue May 30 11:27:39 2017 Replace deprecated base::NonThreadSafe in chrome/browser/chromeos/policy in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=emaxx@chromium.org Review-Url: https://codereview.chromium.org/2910013003 Cr-Commit-Position: refs/heads/master@{#475490} [modify] https://crrev.com/45a3dafd553e3f183e63e579686f9f4bcfb4e9dc/chrome/browser/chromeos/policy/cloud_external_data_manager_base.cc [modify] https://crrev.com/45a3dafd553e3f183e63e579686f9f4bcfb4e9dc/chrome/browser/chromeos/policy/cloud_external_data_manager_base.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b37907345be06c386a62db88dac41365907bbad4 commit b37907345be06c386a62db88dac41365907bbad4 Author: gab <gab@chromium.org> Date: Tue May 30 11:29:07 2017 Replace deprecated base::NonThreadSafe in components/policy in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=emaxx@chromium.org Review-Url: https://codereview.chromium.org/2915493002 Cr-Commit-Position: refs/heads/master@{#475492} [modify] https://crrev.com/b37907345be06c386a62db88dac41365907bbad4/components/policy/core/common/async_policy_provider.cc [modify] https://crrev.com/b37907345be06c386a62db88dac41365907bbad4/components/policy/core/common/async_policy_provider.h [modify] https://crrev.com/b37907345be06c386a62db88dac41365907bbad4/components/policy/core/common/cloud/component_cloud_policy_service.cc [modify] https://crrev.com/b37907345be06c386a62db88dac41365907bbad4/components/policy/core/common/cloud/component_cloud_policy_service.h [modify] https://crrev.com/b37907345be06c386a62db88dac41365907bbad4/components/policy/core/common/cloud/component_cloud_policy_store.cc [modify] https://crrev.com/b37907345be06c386a62db88dac41365907bbad4/components/policy/core/common/cloud/component_cloud_policy_store.h [modify] https://crrev.com/b37907345be06c386a62db88dac41365907bbad4/components/policy/core/common/schema_registry.cc [modify] https://crrev.com/b37907345be06c386a62db88dac41365907bbad4/components/policy/core/common/schema_registry.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42f156958878270e4574544ab7abf9a99b7972ee commit 42f156958878270e4574544ab7abf9a99b7972ee Author: gab <gab@chromium.org> Date: Tue May 30 12:41:40 2017 Replace deprecated base::NonThreadSafe in content/browser/loader in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=csharrison@chromium.org Review-Url: https://codereview.chromium.org/2907283002 Cr-Commit-Position: refs/heads/master@{#475502} [modify] https://crrev.com/42f156958878270e4574544ab7abf9a99b7972ee/content/browser/loader/resource_scheduler.cc [modify] https://crrev.com/42f156958878270e4574544ab7abf9a99b7972ee/content/browser/loader/resource_scheduler.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75ce10f5e422d2da2e8bca32b456273c297beff3 commit 75ce10f5e422d2da2e8bca32b456273c297beff3 Author: gab <gab@chromium.org> Date: Tue May 30 14:40:08 2017 Deprecate NonThreadSafe in storage/browser/quota in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=tzik@chromium.org Review-Url: https://codereview.chromium.org/2908223002 Cr-Commit-Position: refs/heads/master@{#475521} [modify] https://crrev.com/75ce10f5e422d2da2e8bca32b456273c297beff3/storage/browser/quota/client_usage_tracker.cc [modify] https://crrev.com/75ce10f5e422d2da2e8bca32b456273c297beff3/storage/browser/quota/client_usage_tracker.h [modify] https://crrev.com/75ce10f5e422d2da2e8bca32b456273c297beff3/storage/browser/quota/quota_temporary_storage_evictor.cc [modify] https://crrev.com/75ce10f5e422d2da2e8bca32b456273c297beff3/storage/browser/quota/quota_temporary_storage_evictor.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a05726ef77312a57e1c392b8dac943abb0d97dc1 commit a05726ef77312a57e1c392b8dac943abb0d97dc1 Author: gab <gab@chromium.org> Date: Tue May 30 15:04:53 2017 Replace deprecated base::NonThreadSafe in content in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=nasko@chromium.org Review-Url: https://codereview.chromium.org/2909053003 Cr-Commit-Position: refs/heads/master@{#475526} [modify] https://crrev.com/a05726ef77312a57e1c392b8dac943abb0d97dc1/content/public/browser/notification_registrar.cc [modify] https://crrev.com/a05726ef77312a57e1c392b8dac943abb0d97dc1/content/public/browser/notification_registrar.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a48181837832ca432f87369fddfa092f0450768 commit 2a48181837832ca432f87369fddfa092f0450768 Author: gab <gab@chromium.org> Date: Tue May 30 15:08:50 2017 Replace deprecated base::NonThreadSafe in chrome/browser/ssl in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=agl@chromium.org Review-Url: https://codereview.chromium.org/2911123002 Cr-Commit-Position: refs/heads/master@{#475527} [modify] https://crrev.com/2a48181837832ca432f87369fddfa092f0450768/chrome/browser/ssl/common_name_mismatch_handler.cc [modify] https://crrev.com/2a48181837832ca432f87369fddfa092f0450768/chrome/browser/ssl/common_name_mismatch_handler.h [modify] https://crrev.com/2a48181837832ca432f87369fddfa092f0450768/chrome/browser/ssl/ssl_error_handler.cc
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43eaff9cc22ea1b44505e03b0135e789486cefbf commit 43eaff9cc22ea1b44505e03b0135e789486cefbf Author: gab <gab@chromium.org> Date: Tue May 30 15:19:01 2017 Replace deprecated base::NonThreadSafe in chrome/browser/themes in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=estade@chromium.org Review-Url: https://codereview.chromium.org/2909183002 Cr-Commit-Position: refs/heads/master@{#475531} [modify] https://crrev.com/43eaff9cc22ea1b44505e03b0135e789486cefbf/chrome/browser/themes/theme_service.cc [modify] https://crrev.com/43eaff9cc22ea1b44505e03b0135e789486cefbf/chrome/browser/themes/theme_service.h [modify] https://crrev.com/43eaff9cc22ea1b44505e03b0135e789486cefbf/chrome/browser/themes/theme_service_mac.mm
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d25e7c3befa903c9bef0950a1365b13d1074ae0 commit 9d25e7c3befa903c9bef0950a1365b13d1074ae0 Author: gab <gab@chromium.org> Date: Tue May 30 15:30:58 2017 Replace deprecated base::NonThreadSafe in components/keyed_service in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implicitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2910053002 Cr-Commit-Position: refs/heads/master@{#475536} [modify] https://crrev.com/9d25e7c3befa903c9bef0950a1365b13d1074ae0/components/keyed_service/content/browser_context_keyed_base_factory.cc [modify] https://crrev.com/9d25e7c3befa903c9bef0950a1365b13d1074ae0/components/keyed_service/content/browser_context_keyed_service_factory.cc [modify] https://crrev.com/9d25e7c3befa903c9bef0950a1365b13d1074ae0/components/keyed_service/content/refcounted_browser_context_keyed_service_factory.cc [modify] https://crrev.com/9d25e7c3befa903c9bef0950a1365b13d1074ae0/components/keyed_service/core/keyed_service_base_factory.cc [modify] https://crrev.com/9d25e7c3befa903c9bef0950a1365b13d1074ae0/components/keyed_service/core/keyed_service_base_factory.h [modify] https://crrev.com/9d25e7c3befa903c9bef0950a1365b13d1074ae0/components/keyed_service/ios/browser_state_keyed_service_factory.cc [modify] https://crrev.com/9d25e7c3befa903c9bef0950a1365b13d1074ae0/components/keyed_service/ios/refcounted_browser_state_keyed_service_factory.cc
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa76e566cab7436963a2d12312173cbd0339093d commit aa76e566cab7436963a2d12312173cbd0339093d Author: gab <gab@chromium.org> Date: Tue May 30 15:49:40 2017 Replace deprecated base::NonThreadSafe in content/browser in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=boliu@chromium.org Review-Url: https://codereview.chromium.org/2910083002 Cr-Commit-Position: refs/heads/master@{#475541} [modify] https://crrev.com/aa76e566cab7436963a2d12312173cbd0339093d/content/browser/child_process_launcher.cc [modify] https://crrev.com/aa76e566cab7436963a2d12312173cbd0339093d/content/browser/child_process_launcher.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c2859bc15968f41c36ce8f026b09e1bf8066669 commit 7c2859bc15968f41c36ce8f026b09e1bf8066669 Author: gab <gab@chromium.org> Date: Tue May 30 16:31:40 2017 Deprecate NonThreadSafe in components/captive_portal in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=mmenke@chromium.org Review-Url: https://codereview.chromium.org/2906233005 Cr-Commit-Position: refs/heads/master@{#475551} [modify] https://crrev.com/7c2859bc15968f41c36ce8f026b09e1bf8066669/components/captive_portal/captive_portal_detector.cc [modify] https://crrev.com/7c2859bc15968f41c36ce8f026b09e1bf8066669/components/captive_portal/captive_portal_detector.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e78de22c51a073429e5cfdbebd74809cd4aaa3e7 commit e78de22c51a073429e5cfdbebd74809cd4aaa3e7 Author: gab <gab@chromium.org> Date: Tue May 30 16:45:45 2017 Replace deprecated base::NonThreadSafe in chrome/browser/prerender in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=davidben@chromium.org Review-Url: https://codereview.chromium.org/2909193002 Cr-Commit-Position: refs/heads/master@{#475556} [modify] https://crrev.com/e78de22c51a073429e5cfdbebd74809cd4aaa3e7/chrome/browser/prerender/prerender_history.cc [modify] https://crrev.com/e78de22c51a073429e5cfdbebd74809cd4aaa3e7/chrome/browser/prerender/prerender_history.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33237ba4ee368a91a2ab8bdcbed1a350edd3135a commit 33237ba4ee368a91a2ab8bdcbed1a350edd3135a Author: gab <gab@chromium.org> Date: Tue May 30 16:46:59 2017 Deprecate NonThreadSafe in components/bookmarks in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=sky@chromium.org Review-Url: https://codereview.chromium.org/2909963002 Cr-Commit-Position: refs/heads/master@{#475557} [modify] https://crrev.com/33237ba4ee368a91a2ab8bdcbed1a350edd3135a/components/bookmarks/browser/startup_task_runner_service.cc [modify] https://crrev.com/33237ba4ee368a91a2ab8bdcbed1a350edd3135a/components/bookmarks/browser/startup_task_runner_service.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb1830f1f2f36ecd8dda3b42bfe5302fd8321a0c commit bb1830f1f2f36ecd8dda3b42bfe5302fd8321a0c Author: gab <gab@chromium.org> Date: Tue May 30 16:52:50 2017 Replace deprecated base::NonThreadSafe in jingle in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=zea@chromium.org Review-Url: https://codereview.chromium.org/2913673003 Cr-Commit-Position: refs/heads/master@{#475565} [modify] https://crrev.com/bb1830f1f2f36ecd8dda3b42bfe5302fd8321a0c/jingle/glue/task_pump.cc [modify] https://crrev.com/bb1830f1f2f36ecd8dda3b42bfe5302fd8321a0c/jingle/glue/task_pump.h [modify] https://crrev.com/bb1830f1f2f36ecd8dda3b42bfe5302fd8321a0c/jingle/notifier/base/weak_xmpp_client.cc [modify] https://crrev.com/bb1830f1f2f36ecd8dda3b42bfe5302fd8321a0c/jingle/notifier/base/weak_xmpp_client.h [modify] https://crrev.com/bb1830f1f2f36ecd8dda3b42bfe5302fd8321a0c/jingle/notifier/base/xmpp_connection.cc [modify] https://crrev.com/bb1830f1f2f36ecd8dda3b42bfe5302fd8321a0c/jingle/notifier/base/xmpp_connection.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3151205cf264a0e8ff6d45f4b953721e198483fb commit 3151205cf264a0e8ff6d45f4b953721e198483fb Author: gab <gab@chromium.org> Date: Tue May 30 17:29:08 2017 Replace deprecated base::NonThreadSafe in media/capture/video in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=emircan@chromium.org Review-Url: https://codereview.chromium.org/2908293002 Cr-Commit-Position: refs/heads/master@{#475578} [modify] https://crrev.com/3151205cf264a0e8ff6d45f4b953721e198483fb/media/capture/video/win/video_capture_device_mf_win.cc [modify] https://crrev.com/3151205cf264a0e8ff6d45f4b953721e198483fb/media/capture/video/win/video_capture_device_mf_win.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd4c890179f3a0b7e6911420765c7616de3555d0 commit dd4c890179f3a0b7e6911420765c7616de3555d0 Author: gab <gab@chromium.org> Date: Tue May 30 18:05:37 2017 Replace deprecated base::NonThreadSafe in extensions/browser/api/cast_channel in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=kmarshall@chromium.org Review-Url: https://codereview.chromium.org/2910073002 Cr-Commit-Position: refs/heads/master@{#475595} [modify] https://crrev.com/dd4c890179f3a0b7e6911420765c7616de3555d0/extensions/browser/api/cast_channel/cast_transport.cc [modify] https://crrev.com/dd4c890179f3a0b7e6911420765c7616de3555d0/extensions/browser/api/cast_channel/cast_transport.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08d631764004455408cbc88dd6156f6bef3c5c90 commit 08d631764004455408cbc88dd6156f6bef3c5c90 Author: gab <gab@chromium.org> Date: Tue May 30 18:08:31 2017 Replace deprecated base::NonThreadSafe in media in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=sandersd@chromium.org Review-Url: https://codereview.chromium.org/2914603002 Cr-Commit-Position: refs/heads/master@{#475596} [modify] https://crrev.com/08d631764004455408cbc88dd6156f6bef3c5c90/media/base/test_helpers.cc [modify] https://crrev.com/08d631764004455408cbc88dd6156f6bef3c5c90/media/base/test_helpers.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc9a99aeb236d40290aa81dab893740688c1ce2a commit dc9a99aeb236d40290aa81dab893740688c1ce2a Author: gab <gab@chromium.org> Date: Tue May 30 18:10:49 2017 Deprecate NonThreadSafe in chrome/renderer/media in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=sergeyu@chromium.org Review-Url: https://codereview.chromium.org/2907133003 Cr-Commit-Position: refs/heads/master@{#475597} [modify] https://crrev.com/dc9a99aeb236d40290aa81dab893740688c1ce2a/chrome/renderer/media/chrome_webrtc_log_message_delegate.cc [modify] https://crrev.com/dc9a99aeb236d40290aa81dab893740688c1ce2a/chrome/renderer/media/chrome_webrtc_log_message_delegate.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9f5b26537f6e4a7fb7552c96cb23b04d9d7db7b commit e9f5b26537f6e4a7fb7552c96cb23b04d9d7db7b Author: gab <gab@chromium.org> Date: Tue May 30 18:11:48 2017 Deprecate NonThreadSafe in components/data_reduction_proxy in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=bolian@chromium.org Review-Url: https://codereview.chromium.org/2909973002 Cr-Commit-Position: refs/heads/master@{#475598} [modify] https://crrev.com/e9f5b26537f6e4a7fb7552c96cb23b04d9d7db7b/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.cc [modify] https://crrev.com/e9f5b26537f6e4a7fb7552c96cb23b04d9d7db7b/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e146085ef2bed9d808fc90288f72fcaa2e3a0788 commit e146085ef2bed9d808fc90288f72fcaa2e3a0788 Author: gab <gab@chromium.org> Date: Tue May 30 18:14:20 2017 Replace deprecated base::NonThreadSafe in content/renderer/p2p in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=sergeyu@chromium.org Review-Url: https://codereview.chromium.org/2912873002 Cr-Commit-Position: refs/heads/master@{#475599} [modify] https://crrev.com/e146085ef2bed9d808fc90288f72fcaa2e3a0788/content/renderer/p2p/ipc_socket_factory.cc
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d771e4b28b5878d005596283b88a3296518abf65 commit d771e4b28b5878d005596283b88a3296518abf65 Author: gab <gab@chromium.org> Date: Tue May 30 18:16:11 2017 Replace deprecated base::NonThreadSafe in content/renderer/media/webrtc in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=sergeyu@chromium.org Review-Url: https://codereview.chromium.org/2913693003 Cr-Commit-Position: refs/heads/master@{#475600} [modify] https://crrev.com/d771e4b28b5878d005596283b88a3296518abf65/content/renderer/media/webrtc/media_stream_track_metrics.cc [modify] https://crrev.com/d771e4b28b5878d005596283b88a3296518abf65/content/renderer/media/webrtc/media_stream_track_metrics.h [modify] https://crrev.com/d771e4b28b5878d005596283b88a3296518abf65/content/renderer/media/webrtc/peer_connection_dependency_factory.cc [modify] https://crrev.com/d771e4b28b5878d005596283b88a3296518abf65/content/renderer/media/webrtc/peer_connection_dependency_factory.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d43afa1fa4853b90c1437b4ea57bf904106258b2 commit d43afa1fa4853b90c1437b4ea57bf904106258b2 Author: gab <gab@chromium.org> Date: Tue May 30 18:26:24 2017 Remove deprecated NonThreadSafe usage in net\socket. Used ThreadChecker over the usually prefered SequenceChecker because some implementations are thread-affine.. This was scripted (check also added to destructors because NonThreadSafe implicitly checked on destruction but ThreadChecker doesn't). BUG=676387 Review-Url: https://codereview.chromium.org/2905183002 Cr-Commit-Position: refs/heads/master@{#475604} [modify] https://crrev.com/d43afa1fa4853b90c1437b4ea57bf904106258b2/net/socket/client_socket_pool_manager_impl.cc [modify] https://crrev.com/d43afa1fa4853b90c1437b4ea57bf904106258b2/net/socket/client_socket_pool_manager_impl.h [modify] https://crrev.com/d43afa1fa4853b90c1437b4ea57bf904106258b2/net/socket/tcp_socket_win.cc [modify] https://crrev.com/d43afa1fa4853b90c1437b4ea57bf904106258b2/net/socket/tcp_socket_win.h [modify] https://crrev.com/d43afa1fa4853b90c1437b4ea57bf904106258b2/net/socket/udp_socket_posix.cc [modify] https://crrev.com/d43afa1fa4853b90c1437b4ea57bf904106258b2/net/socket/udp_socket_posix.h [modify] https://crrev.com/d43afa1fa4853b90c1437b4ea57bf904106258b2/net/socket/udp_socket_win.cc [modify] https://crrev.com/d43afa1fa4853b90c1437b4ea57bf904106258b2/net/socket/udp_socket_win.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29f0def5903e9faed165254fe83598713876a028 commit 29f0def5903e9faed165254fe83598713876a028 Author: gab <gab@chromium.org> Date: Tue May 30 19:06:43 2017 Deprecate NonThreadSafe in content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=chfremer@chromium.org Review-Url: https://codereview.chromium.org/2911063002 Cr-Commit-Position: refs/heads/master@{#475618} [modify] https://crrev.com/29f0def5903e9faed165254fe83598713876a028/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc [modify] https://crrev.com/29f0def5903e9faed165254fe83598713876a028/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08f8a175f76521083cb503e31bb470b4ff227e1c commit 08f8a175f76521083cb503e31bb470b4ff227e1c Author: gab <gab@chromium.org> Date: Tue May 30 19:08:27 2017 Replace deprecated base::NonThreadSafe in content/renderer/devtools in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2907273002 Cr-Commit-Position: refs/heads/master@{#475620} [modify] https://crrev.com/08f8a175f76521083cb503e31bb470b4ff227e1c/content/renderer/devtools/devtools_agent.cc
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7802f1cfc5ee707a977415fcc47912778e45925 commit b7802f1cfc5ee707a977415fcc47912778e45925 Author: gab <gab@chromium.org> Date: Tue May 30 19:12:42 2017 Replace deprecated base::NonThreadSafe in chrome/browser/devtools in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2913693002 Cr-Commit-Position: refs/heads/master@{#475622} [modify] https://crrev.com/b7802f1cfc5ee707a977415fcc47912778e45925/chrome/browser/devtools/device/adb/mock_adb_server.cc [modify] https://crrev.com/b7802f1cfc5ee707a977415fcc47912778e45925/chrome/browser/devtools/device/android_device_manager.cc [modify] https://crrev.com/b7802f1cfc5ee707a977415fcc47912778e45925/chrome/browser/devtools/device/android_device_manager.h [modify] https://crrev.com/b7802f1cfc5ee707a977415fcc47912778e45925/chrome/browser/devtools/device/port_forwarding_controller.cc [modify] https://crrev.com/b7802f1cfc5ee707a977415fcc47912778e45925/chrome/browser/devtools/device/usb/android_usb_socket.cc [modify] https://crrev.com/b7802f1cfc5ee707a977415fcc47912778e45925/chrome/browser/devtools/device/usb/android_usb_socket.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4523afedd7271dcdd8a2d310e219ecb8c63fff63 commit 4523afedd7271dcdd8a2d310e219ecb8c63fff63 Author: gab <gab@chromium.org> Date: Tue May 30 19:43:19 2017 Replace deprecated base::NonThreadSafe in android_webview in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=boliu@chromium.org Review-Url: https://codereview.chromium.org/2909173002 Cr-Commit-Position: refs/heads/master@{#475631} [modify] https://crrev.com/4523afedd7271dcdd8a2d310e219ecb8c63fff63/android_webview/browser/renderer_host/aw_render_view_host_ext.cc [modify] https://crrev.com/4523afedd7271dcdd8a2d310e219ecb8c63fff63/android_webview/browser/renderer_host/aw_render_view_host_ext.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22a94ad4834982354b10542970d7393d876338c6 commit 22a94ad4834982354b10542970d7393d876338c6 Author: gab <gab@chromium.org> Date: Tue May 30 20:08:02 2017 Replace deprecated base::NonThreadSafe in components/login in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=achuith@chromium.org Review-Url: https://codereview.chromium.org/2910073003 Cr-Commit-Position: refs/heads/master@{#475641} [modify] https://crrev.com/22a94ad4834982354b10542970d7393d876338c6/components/login/screens/screen_context.cc [modify] https://crrev.com/22a94ad4834982354b10542970d7393d876338c6/components/login/screens/screen_context.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/806734a3c5e5f2d1772b917522840655c35afc43 commit 806734a3c5e5f2d1772b917522840655c35afc43 Author: gab <gab@chromium.org> Date: Tue May 30 20:59:48 2017 Deprecate NonThreadSafe in chromeos/process_proxy in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=tbarzic@chromium.org Review-Url: https://codereview.chromium.org/2909113003 Cr-Commit-Position: refs/heads/master@{#475668} [modify] https://crrev.com/806734a3c5e5f2d1772b917522840655c35afc43/chromeos/process_proxy/process_proxy_registry.cc [modify] https://crrev.com/806734a3c5e5f2d1772b917522840655c35afc43/chromeos/process_proxy/process_proxy_registry.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db220d62efe14726b852e7bd1a2cab7045701e4e commit db220d62efe14726b852e7bd1a2cab7045701e4e Author: gab <gab@chromium.org> Date: Tue May 30 23:28:31 2017 Deprecate NonThreadSafe in chrome/browser/chromeos/login in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=achuith@chromium.org Review-Url: https://codereview.chromium.org/2909953002 Cr-Commit-Position: refs/heads/master@{#475688} [modify] https://crrev.com/db220d62efe14726b852e7bd1a2cab7045701e4e/chrome/browser/chromeos/login/signin/merge_session_throttling_utils.cc
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a3671ded59ef375816a99cf890b0e1171720485c commit a3671ded59ef375816a99cf890b0e1171720485c Author: gab <gab@chromium.org> Date: Wed May 31 00:48:43 2017 Replace deprecated base::NonThreadSafe in content/browser/appcache in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=michaeln@chromium.org Review-Url: https://codereview.chromium.org/2911983004 Cr-Commit-Position: refs/heads/master@{#475709} [modify] https://crrev.com/a3671ded59ef375816a99cf890b0e1171720485c/content/browser/appcache/appcache_job.cc [modify] https://crrev.com/a3671ded59ef375816a99cf890b0e1171720485c/content/browser/appcache/appcache_job.h [modify] https://crrev.com/a3671ded59ef375816a99cf890b0e1171720485c/content/browser/appcache/appcache_request.cc [modify] https://crrev.com/a3671ded59ef375816a99cf890b0e1171720485c/content/browser/appcache/appcache_request.h
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c70ce762d963655ec12866e88f3f1107dcaea560 commit c70ce762d963655ec12866e88f3f1107dcaea560 Author: gab <gab@chromium.org> Date: Wed May 31 16:36:39 2017 Replace deprecated base::NonThreadSafe in ui/gl in favor of ThreadChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. (and then updated from SequenceChecker to ThreadChecker per request) BUG=676387 This CL was uploaded by git cl split. R=piman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2911113002 Cr-Commit-Position: refs/heads/master@{#475939} [modify] https://crrev.com/c70ce762d963655ec12866e88f3f1107dcaea560/ui/gl/gl_surface_glx.cc
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21edbfa38a6aac6c2f3dd7b024414725ad2afdbb commit 21edbfa38a6aac6c2f3dd7b024414725ad2afdbb Author: gab <gab@chromium.org> Date: Wed May 31 16:49:12 2017 Replace deprecated base::NonThreadSafe in ipc in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=jam@chromium.org Review-Url: https://codereview.chromium.org/2909993003 Cr-Commit-Position: refs/heads/master@{#475944} [modify] https://crrev.com/21edbfa38a6aac6c2f3dd7b024414725ad2afdbb/ipc/ipc_channel_proxy.cc [modify] https://crrev.com/21edbfa38a6aac6c2f3dd7b024414725ad2afdbb/ipc/ipc_channel_proxy.h
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c5a0ac597cce0b30d7a067e96b909bdfe04a4c5 commit 8c5a0ac597cce0b30d7a067e96b909bdfe04a4c5 Author: gab <gab@chromium.org> Date: Wed May 31 16:58:48 2017 Replace deprecated base::NonThreadSafe in chrome/browser/apps/app_shim in favor of ThreadChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8 but was then amended to favor ThreadChecker over SequenceChecker per reviewer request. BUG=676387 This CL was uploaded by git cl split. R=dominickn@chromium.org Review-Url: https://codereview.chromium.org/2908973004 Cr-Commit-Position: refs/heads/master@{#475947} [modify] https://crrev.com/8c5a0ac597cce0b30d7a067e96b909bdfe04a4c5/chrome/browser/apps/app_shim/app_shim_host_mac.cc [modify] https://crrev.com/8c5a0ac597cce0b30d7a067e96b909bdfe04a4c5/chrome/browser/apps/app_shim/app_shim_host_mac.h
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/479c1fb15f0c8f32751e2fc88d70493af70ebd84 commit 479c1fb15f0c8f32751e2fc88d70493af70ebd84 Author: gab <gab@chromium.org> Date: Wed May 31 17:47:57 2017 Replace deprecated base::NonThreadSafe in chrome/browser/supervised_user in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=bauerb@chromium.org Review-Url: https://codereview.chromium.org/2911113004 Cr-Commit-Position: refs/heads/master@{#475958} [modify] https://crrev.com/479c1fb15f0c8f32751e2fc88d70493af70ebd84/chrome/browser/supervised_user/supervised_user_url_filter.cc [modify] https://crrev.com/479c1fb15f0c8f32751e2fc88d70493af70ebd84/chrome/browser/supervised_user/supervised_user_url_filter.h
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e1fb53580a932ea620ea5d02838f32425e04f1e commit 6e1fb53580a932ea620ea5d02838f32425e04f1e Author: gab <gab@chromium.org> Date: Wed May 31 18:27:12 2017 Replace deprecated base::NonThreadSafe in components/prefs in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=bauerb@chromium.org Review-Url: https://codereview.chromium.org/2908263002 Cr-Commit-Position: refs/heads/master@{#475963} [modify] https://crrev.com/6e1fb53580a932ea620ea5d02838f32425e04f1e/components/prefs/json_pref_store.cc [modify] https://crrev.com/6e1fb53580a932ea620ea5d02838f32425e04f1e/components/prefs/json_pref_store.h [modify] https://crrev.com/6e1fb53580a932ea620ea5d02838f32425e04f1e/components/prefs/pref_service.cc [modify] https://crrev.com/6e1fb53580a932ea620ea5d02838f32425e04f1e/components/prefs/pref_service.h [modify] https://crrev.com/6e1fb53580a932ea620ea5d02838f32425e04f1e/components/prefs/scoped_user_pref_update.cc [modify] https://crrev.com/6e1fb53580a932ea620ea5d02838f32425e04f1e/components/prefs/scoped_user_pref_update.h
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/655dcb37d6fe61834d8bc10dff22075e0c83d789 commit 655dcb37d6fe61834d8bc10dff22075e0c83d789 Author: gab <gab@chromium.org> Date: Wed May 31 20:07:44 2017 Replace deprecated base::NonThreadSafe in content/shell in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=peter@chromium.org Review-Url: https://codereview.chromium.org/2908293003 Cr-Commit-Position: refs/heads/master@{#475993} [modify] https://crrev.com/655dcb37d6fe61834d8bc10dff22075e0c83d789/content/shell/browser/layout_test/blink_test_controller.cc [modify] https://crrev.com/655dcb37d6fe61834d8bc10dff22075e0c83d789/content/shell/browser/layout_test/blink_test_controller.h
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff918f8d6e180f8d53573fd9e368286731e83329 commit ff918f8d6e180f8d53573fd9e368286731e83329 Author: gab <gab@chromium.org> Date: Wed May 31 20:23:58 2017 Replace deprecated base::NonThreadSafe in content/browser/gpu in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=zmo@chromium.org Review-Url: https://codereview.chromium.org/2915513002 Cr-Commit-Position: refs/heads/master@{#475999} [modify] https://crrev.com/ff918f8d6e180f8d53573fd9e368286731e83329/content/browser/gpu/gpu_process_host.cc [modify] https://crrev.com/ff918f8d6e180f8d53573fd9e368286731e83329/content/browser/gpu/gpu_process_host.h
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9279f0c0358aa6492a7a271e651eabe5e0f5086 commit d9279f0c0358aa6492a7a271e651eabe5e0f5086 Author: gab <gab@chromium.org> Date: Wed May 31 20:36:26 2017 Replace deprecated base::NonThreadSafe in chrome/browser/chromeos in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=achuith@chromium.org Review-Url: https://codereview.chromium.org/2909203002 Cr-Commit-Position: refs/heads/master@{#476003} [modify] https://crrev.com/d9279f0c0358aa6492a7a271e651eabe5e0f5086/chrome/browser/chromeos/net/network_portal_detector_impl.cc [modify] https://crrev.com/d9279f0c0358aa6492a7a271e651eabe5e0f5086/chrome/browser/chromeos/net/network_portal_detector_impl.h
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93f8b8a5cc48cc016c1979076b08d16d568c34f1 commit 93f8b8a5cc48cc016c1979076b08d16d568c34f1 Author: gab <gab@chromium.org> Date: Wed May 31 20:54:18 2017 Deprecate NonThreadSafe in components/sync in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=stanisc@chromium.org Review-Url: https://codereview.chromium.org/2915453002 Cr-Commit-Position: refs/heads/master@{#476015} [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/base/sync_prefs.cc [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/base/sync_prefs.h [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/base/weak_handle.h [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/device_info/local_device_info_provider_impl.cc [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/device_info/local_device_info_provider_impl.h [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/engine/attachments/attachment_store_frontend.cc [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/engine/attachments/attachment_store_frontend.h [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/engine/attachments/fake_attachment_downloader.cc [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/engine/attachments/fake_attachment_downloader.h [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/engine/attachments/fake_attachment_uploader.cc [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/engine/attachments/fake_attachment_uploader.h [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/engine/attachments/in_memory_attachment_store.cc [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/engine/attachments/in_memory_attachment_store.h [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/engine/attachments/on_disk_attachment_store.cc [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/engine/attachments/on_disk_attachment_store.h [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/engine_impl/attachments/attachment_downloader_impl.cc [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/engine_impl/attachments/attachment_downloader_impl.h [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/engine_impl/attachments/attachment_downloader_impl_unittest.cc [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/engine_impl/attachments/attachment_uploader_impl.cc [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/engine_impl/attachments/attachment_uploader_impl.h [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/engine_impl/attachments/attachment_uploader_impl_unittest.cc [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/engine_impl/js_mutation_event_observer.cc [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/engine_impl/js_mutation_event_observer.h [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/engine_impl/sync_scheduler_impl.cc [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/engine_impl/sync_scheduler_impl.h [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/model/attachments/attachment_service_proxy_unittest.cc [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/model_impl/attachments/attachment_service_impl.cc [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/model_impl/attachments/attachment_service_impl.h [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/model_impl/attachments/task_queue.h [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/model_impl/model_type_store_impl.cc [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/model_impl/model_type_store_impl.h [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/model_impl/shared_model_type_processor.cc [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/model_impl/shared_model_type_processor.h [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/syncable/directory_backing_store.cc [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/syncable/directory_backing_store.h [modify] https://crrev.com/93f8b8a5cc48cc016c1979076b08d16d568c34f1/components/sync/syncable/on_disk_directory_backing_store.cc
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/974c05c371ca2913e8e84519c1d1440c8fa381f2 commit 974c05c371ca2913e8e84519c1d1440c8fa381f2 Author: gab <gab@chromium.org> Date: Wed May 31 21:27:31 2017 Deprecate NonThreadSafe in components/safe_browsing_db in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=vakh@chromium.org Review-Url: https://codereview.chromium.org/2915443002 Cr-Commit-Position: refs/heads/master@{#476029} [modify] https://crrev.com/974c05c371ca2913e8e84519c1d1440c8fa381f2/components/safe_browsing_db/v4_get_hash_protocol_manager.cc [modify] https://crrev.com/974c05c371ca2913e8e84519c1d1440c8fa381f2/components/safe_browsing_db/v4_get_hash_protocol_manager.h [modify] https://crrev.com/974c05c371ca2913e8e84519c1d1440c8fa381f2/components/safe_browsing_db/v4_update_protocol_manager.cc [modify] https://crrev.com/974c05c371ca2913e8e84519c1d1440c8fa381f2/components/safe_browsing_db/v4_update_protocol_manager.h
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4686a2a8cd62dceec3336a2b06c721d02daf140 commit c4686a2a8cd62dceec3336a2b06c721d02daf140 Author: gab <gab@chromium.org> Date: Wed May 31 21:35:00 2017 Remove deprecated base::NonThreadSafe in media/cast. Note to crash team: This CL is a refactor and has no intended behavior change. It was not replaced by SequenceChecker per request from OWNERS. BUG=676387 This CL was uploaded by git cl split. R=miu@chromium.org Review-Url: https://codereview.chromium.org/2910063002 Cr-Commit-Position: refs/heads/master@{#476035} [modify] https://crrev.com/c4686a2a8cd62dceec3336a2b06c721d02daf140/media/cast/common/transport_encryption_handler.h [modify] https://crrev.com/c4686a2a8cd62dceec3336a2b06c721d02daf140/media/cast/net/cast_transport.h [modify] https://crrev.com/c4686a2a8cd62dceec3336a2b06c721d02daf140/media/cast/sender/audio_sender.h [modify] https://crrev.com/c4686a2a8cd62dceec3336a2b06c721d02daf140/media/cast/sender/video_sender.h
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/234cd78265fdc3965626d10b14d37e8b09b39c86 commit 234cd78265fdc3965626d10b14d37e8b09b39c86 Author: gab <gab@chromium.org> Date: Wed May 31 22:26:51 2017 Replace deprecated base::NonThreadSafe in chrome/browser/extensions in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. ... and then replaced by DCHECK_CURRENTLY_ON(UI) per request. Which forced a fix to .../chromeos/printing/printers_manager_unittest.cc as its TestBrowserThreadBundle was initialized too late for TestingProfile's constructor (which would now crash in DCHECK_CURRENTLY_ON()), switched to using proper member stack ordering instead of trying to do more or less that but not quite correctly with heap allocations. BUG=676387 This CL was uploaded by git cl split. Review-Url: https://codereview.chromium.org/2912003002 Cr-Commit-Position: refs/heads/master@{#476061} [modify] https://crrev.com/234cd78265fdc3965626d10b14d37e8b09b39c86/chrome/browser/chromeos/printing/printers_manager_unittest.cc [modify] https://crrev.com/234cd78265fdc3965626d10b14d37e8b09b39c86/chrome/browser/extensions/warning_badge_service.cc [modify] https://crrev.com/234cd78265fdc3965626d10b14d37e8b09b39c86/chrome/browser/extensions/warning_badge_service.h
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/234cd78265fdc3965626d10b14d37e8b09b39c86 commit 234cd78265fdc3965626d10b14d37e8b09b39c86 Author: gab <gab@chromium.org> Date: Wed May 31 22:26:51 2017 Replace deprecated base::NonThreadSafe in chrome/browser/extensions in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. ... and then replaced by DCHECK_CURRENTLY_ON(UI) per request. Which forced a fix to .../chromeos/printing/printers_manager_unittest.cc as its TestBrowserThreadBundle was initialized too late for TestingProfile's constructor (which would now crash in DCHECK_CURRENTLY_ON()), switched to using proper member stack ordering instead of trying to do more or less that but not quite correctly with heap allocations. BUG=676387 This CL was uploaded by git cl split. Review-Url: https://codereview.chromium.org/2912003002 Cr-Commit-Position: refs/heads/master@{#476061} [modify] https://crrev.com/234cd78265fdc3965626d10b14d37e8b09b39c86/chrome/browser/chromeos/printing/printers_manager_unittest.cc [modify] https://crrev.com/234cd78265fdc3965626d10b14d37e8b09b39c86/chrome/browser/extensions/warning_badge_service.cc [modify] https://crrev.com/234cd78265fdc3965626d10b14d37e8b09b39c86/chrome/browser/extensions/warning_badge_service.h
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d2fae4b6ab7843ec08e938f8cdaa38749d1187c commit 7d2fae4b6ab7843ec08e938f8cdaa38749d1187c Author: gab <gab@chromium.org> Date: Thu Jun 01 14:02:55 2017 Replace deprecated base::NonThreadSafe in base in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=thakis@chromium.org Review-Url: https://codereview.chromium.org/2907303002 Cr-Commit-Position: refs/heads/master@{#476274} [modify] https://crrev.com/7d2fae4b6ab7843ec08e938f8cdaa38749d1187c/base/deferred_sequenced_task_runner_unittest.cc [modify] https://crrev.com/7d2fae4b6ab7843ec08e938f8cdaa38749d1187c/base/files/important_file_writer.cc [modify] https://crrev.com/7d2fae4b6ab7843ec08e938f8cdaa38749d1187c/base/files/important_file_writer.h [modify] https://crrev.com/7d2fae4b6ab7843ec08e938f8cdaa38749d1187c/base/message_loop/message_pump.h
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de5249482175d769de973bc55f429dce97e4b282 commit de5249482175d769de973bc55f429dce97e4b282 Author: gab <gab@chromium.org> Date: Thu Jun 01 14:29:58 2017 Replace deprecated base::NonThreadSafe in components/autofill in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=mathp@chromium.org Review-Url: https://codereview.chromium.org/2908973003 Cr-Commit-Position: refs/heads/master@{#476278} [modify] https://crrev.com/de5249482175d769de973bc55f429dce97e4b282/components/autofill/core/browser/webdata/autocomplete_syncable_service.cc [modify] https://crrev.com/de5249482175d769de973bc55f429dce97e4b282/components/autofill/core/browser/webdata/autocomplete_syncable_service.h [modify] https://crrev.com/de5249482175d769de973bc55f429dce97e4b282/components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc [modify] https://crrev.com/de5249482175d769de973bc55f429dce97e4b282/components/autofill/core/browser/webdata/autofill_profile_syncable_service.h
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf77513ab512c29a2f27b71dbd0510b7ef9695f1 commit bf77513ab512c29a2f27b71dbd0510b7ef9695f1 Author: gab <gab@chromium.org> Date: Thu Jun 01 14:35:34 2017 Deprecate NonThreadSafe in remoting in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=sergeyu@chromium.org Review-Url: https://codereview.chromium.org/2911893003 Cr-Commit-Position: refs/heads/master@{#476279} [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/base/oauth_token_getter_impl.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/base/oauth_token_getter_impl.h [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/base/rate_counter.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/base/rate_counter.h [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/BUILD.gn [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/chromoting_host.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/chromoting_host.h [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/client_session.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/client_session.h [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/continue_window.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/continue_window_linux.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/continue_window_mac.mm [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/continue_window_win.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/disconnect_window_linux.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/disconnect_window_mac.mm [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/disconnect_window_win.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/host_status_logger.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/host_status_logger.h [add] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/host_window.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/host_window.h [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/host_window_proxy.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/ipc_host_event_logger.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/ipc_host_event_logger.h [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/local_input_monitor_mac.mm [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/local_input_monitor_win.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/local_input_monitor_x11.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/native_messaging/pipe_messaging_channel.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/native_messaging/pipe_messaging_channel.h [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/policy_watcher.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/policy_watcher.h [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/setup/win/auth_code_getter.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/setup/win/auth_code_getter.h [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/signaling_connector.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/signaling_connector.h [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/win/rdp_client.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/win/rdp_client.h [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/win/unprivileged_process_delegate.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/win/unprivileged_process_delegate.h [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/win/worker_process_launcher.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/win/worker_process_launcher.h [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/win/wts_session_process_delegate.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/host/win/wts_session_process_delegate.h [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/protocol/channel_multiplexer.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/protocol/ice_connection_to_host.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/protocol/ice_connection_to_host.h [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/protocol/jingle_session_manager.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/protocol/jingle_session_manager.h [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/protocol/message_reader.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/protocol/message_reader.h [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/protocol/pseudotcp_adapter.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/protocol/pseudotcp_adapter.h [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/protocol/session_manager.h [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/protocol/ssl_hmac_channel_authenticator.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/protocol/ssl_hmac_channel_authenticator.h [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/protocol/stream_channel_factory.h [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/signaling/fake_signal_strategy.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/signaling/fake_signal_strategy.h [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/signaling/log_to_server.cc [modify] https://crrev.com/bf77513ab512c29a2f27b71dbd0510b7ef9695f1/remoting/signaling/log_to_server.h
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/370841f24900462d5f74d2b4f96b7125d44eae37 commit 370841f24900462d5f74d2b4f96b7125d44eae37 Author: gab <gab@chromium.org> Date: Thu Jun 01 14:38:26 2017 Replace deprecated base::NonThreadSafe in extensions in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implicitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=finnur@chromium.org Review-Url: https://codereview.chromium.org/2915523002 Cr-Commit-Position: refs/heads/master@{#476280} [modify] https://crrev.com/370841f24900462d5f74d2b4f96b7125d44eae37/extensions/browser/api/api_resource_manager.h [modify] https://crrev.com/370841f24900462d5f74d2b4f96b7125d44eae37/extensions/browser/extension_throttle_manager.cc [modify] https://crrev.com/370841f24900462d5f74d2b4f96b7125d44eae37/extensions/browser/extension_throttle_manager.h [modify] https://crrev.com/370841f24900462d5f74d2b4f96b7125d44eae37/extensions/browser/quota_service.cc [modify] https://crrev.com/370841f24900462d5f74d2b4f96b7125d44eae37/extensions/browser/quota_service.h [modify] https://crrev.com/370841f24900462d5f74d2b4f96b7125d44eae37/extensions/browser/value_store/value_store_frontend.cc [modify] https://crrev.com/370841f24900462d5f74d2b4f96b7125d44eae37/extensions/browser/value_store/value_store_frontend.h [modify] https://crrev.com/370841f24900462d5f74d2b4f96b7125d44eae37/extensions/browser/warning_service.cc [modify] https://crrev.com/370841f24900462d5f74d2b4f96b7125d44eae37/extensions/browser/warning_service.h [modify] https://crrev.com/370841f24900462d5f74d2b4f96b7125d44eae37/extensions/browser/warning_service_unittest.cc
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1359d99e8b759c08e9dff8e934e002e75ca6f0ac commit 1359d99e8b759c08e9dff8e934e002e75ca6f0ac Author: gab <gab@chromium.org> Date: Thu Jun 01 14:43:49 2017 Replace deprecated base::NonThreadSafe in media/audio in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=justinlin@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2914593002 Cr-Commit-Position: refs/heads/master@{#476284} [modify] https://crrev.com/1359d99e8b759c08e9dff8e934e002e75ca6f0ac/media/audio/alsa/alsa_output.cc [modify] https://crrev.com/1359d99e8b759c08e9dff8e934e002e75ca6f0ac/media/audio/alsa/alsa_output.h [modify] https://crrev.com/1359d99e8b759c08e9dff8e934e002e75ca6f0ac/media/audio/sounds/audio_stream_handler.cc [modify] https://crrev.com/1359d99e8b759c08e9dff8e934e002e75ca6f0ac/media/audio/sounds/audio_stream_handler.h [modify] https://crrev.com/1359d99e8b759c08e9dff8e934e002e75ca6f0ac/media/audio/sounds/sounds_manager.cc [modify] https://crrev.com/1359d99e8b759c08e9dff8e934e002e75ca6f0ac/media/audio/sounds/sounds_manager.h [modify] https://crrev.com/1359d99e8b759c08e9dff8e934e002e75ca6f0ac/media/audio/win/audio_low_latency_input_win.cc [modify] https://crrev.com/1359d99e8b759c08e9dff8e934e002e75ca6f0ac/media/audio/win/audio_low_latency_input_win.h
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68602138f8e1f6be21fcd2c2e0e84bedded99901 commit 68602138f8e1f6be21fcd2c2e0e84bedded99901 Author: gab <gab@chromium.org> Date: Thu Jun 01 15:04:07 2017 Deprecate NonThreadSafe in components/drive in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. TBR=hashimoto@chromium.org Review-Url: https://codereview.chromium.org/2907223002 Cr-Commit-Position: refs/heads/master@{#476292} [modify] https://crrev.com/68602138f8e1f6be21fcd2c2e0e84bedded99901/components/drive/service/drive_api_service.cc [modify] https://crrev.com/68602138f8e1f6be21fcd2c2e0e84bedded99901/components/drive/service/drive_api_service.h
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04b63e7cbb8aa3f8f27b0b42f2eaa9e890fed8ac commit 04b63e7cbb8aa3f8f27b0b42f2eaa9e890fed8ac Author: gab <gab@chromium.org> Date: Thu Jun 01 18:58:07 2017 Replace deprecated base::NonThreadSafe in chrome/service in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=scottbyer@chromium.org Review-Url: https://codereview.chromium.org/2914573002 Cr-Commit-Position: refs/heads/master@{#476374} [modify] https://crrev.com/04b63e7cbb8aa3f8f27b0b42f2eaa9e890fed8ac/chrome/service/cloud_print/cloud_print_proxy.cc [modify] https://crrev.com/04b63e7cbb8aa3f8f27b0b42f2eaa9e890fed8ac/chrome/service/cloud_print/cloud_print_proxy.h [modify] https://crrev.com/04b63e7cbb8aa3f8f27b0b42f2eaa9e890fed8ac/chrome/service/cloud_print/cloud_print_token_store.cc [modify] https://crrev.com/04b63e7cbb8aa3f8f27b0b42f2eaa9e890fed8ac/chrome/service/cloud_print/cloud_print_token_store.h
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f37bf18685e1729e784fa3b5d27aeec3323c136 commit 2f37bf18685e1729e784fa3b5d27aeec3323c136 Author: gab <gab@chromium.org> Date: Thu Jun 01 19:54:48 2017 Replace deprecated base::NonThreadSafe in chrome/browser/ui/views in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. (and then amended to use ThreadChecker instead for StatusTrayStateChangerWin) Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=pkasting@chromium.org Review-Url: https://codereview.chromium.org/2909213002 Cr-Commit-Position: refs/heads/master@{#476397} [modify] https://crrev.com/2f37bf18685e1729e784fa3b5d27aeec3323c136/chrome/browser/ui/views/status_icons/status_tray_state_changer_win.cc [modify] https://crrev.com/2f37bf18685e1729e784fa3b5d27aeec3323c136/chrome/browser/ui/views/status_icons/status_tray_state_changer_win.h [modify] https://crrev.com/2f37bf18685e1729e784fa3b5d27aeec3323c136/chrome/browser/ui/views/status_icons/status_tray_win.cc
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79ba0231316d391f0636c071f2d745c045d49fbd commit 79ba0231316d391f0636c071f2d745c045d49fbd Author: gab <gab@chromium.org> Date: Thu Jun 01 20:00:50 2017 Replace deprecated base::NonThreadSafe in chrome/browser/safe_browsing in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=nparker@chromium.org Review-Url: https://codereview.chromium.org/2909123003 Cr-Commit-Position: refs/heads/master@{#476399} [modify] https://crrev.com/79ba0231316d391f0636c071f2d745c045d49fbd/chrome/browser/safe_browsing/certificate_reporting_service_test_utils.cc [modify] https://crrev.com/79ba0231316d391f0636c071f2d745c045d49fbd/chrome/browser/safe_browsing/certificate_reporting_service_test_utils.h [modify] https://crrev.com/79ba0231316d391f0636c071f2d745c045d49fbd/chrome/browser/safe_browsing/download_feedback.h
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01d03ed2538901cab22ab2ecedca296776355e4b commit 01d03ed2538901cab22ab2ecedca296776355e4b Author: gab <gab@chromium.org> Date: Thu Jun 01 20:05:40 2017 Replace deprecated base::NonThreadSafe in components/signin in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=rogerta@chromium.org Review-Url: https://codereview.chromium.org/2908263003 Cr-Commit-Position: refs/heads/master@{#476401} [modify] https://crrev.com/01d03ed2538901cab22ab2ecedca296776355e4b/components/signin/core/browser/account_fetcher_service.cc [modify] https://crrev.com/01d03ed2538901cab22ab2ecedca296776355e4b/components/signin/core/browser/account_fetcher_service.h [modify] https://crrev.com/01d03ed2538901cab22ab2ecedca296776355e4b/components/signin/core/browser/account_tracker_service.cc [modify] https://crrev.com/01d03ed2538901cab22ab2ecedca296776355e4b/components/signin/core/browser/account_tracker_service.h [modify] https://crrev.com/01d03ed2538901cab22ab2ecedca296776355e4b/components/signin/core/browser/refresh_token_annotation_request.cc [modify] https://crrev.com/01d03ed2538901cab22ab2ecedca296776355e4b/components/signin/core/browser/refresh_token_annotation_request.h
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d19cd77fd040e15ecc2b459a6230c601a9879526 commit d19cd77fd040e15ecc2b459a6230c601a9879526 Author: gab <gab@chromium.org> Date: Thu Jun 01 20:14:04 2017 Replace deprecated base::NonThreadSafe in google_apis/gaia in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=rogerta@chromium.org Review-Url: https://codereview.chromium.org/2910983003 Cr-Commit-Position: refs/heads/master@{#476406} [modify] https://crrev.com/d19cd77fd040e15ecc2b459a6230c601a9879526/google_apis/gaia/oauth2_token_service.cc [modify] https://crrev.com/d19cd77fd040e15ecc2b459a6230c601a9879526/google_apis/gaia/oauth2_token_service.h [modify] https://crrev.com/d19cd77fd040e15ecc2b459a6230c601a9879526/google_apis/gaia/oauth2_token_service_request.cc [modify] https://crrev.com/d19cd77fd040e15ecc2b459a6230c601a9879526/google_apis/gaia/oauth2_token_service_request.h
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d161eb579eb2a491e59d82a616dde87c29eb65f1 commit d161eb579eb2a491e59d82a616dde87c29eb65f1 Author: gab <gab@chromium.org> Date: Thu Jun 01 20:17:04 2017 Replace deprecated base::NonThreadSafe in content/child/fileapi in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=jianli@chromium.org Review-Url: https://codereview.chromium.org/2915503002 Cr-Commit-Position: refs/heads/master@{#476408} [modify] https://crrev.com/d161eb579eb2a491e59d82a616dde87c29eb65f1/content/child/fileapi/webfilesystem_impl.cc [modify] https://crrev.com/d161eb579eb2a491e59d82a616dde87c29eb65f1/content/child/fileapi/webfilesystem_impl.h
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3538d39da5877e597441971b5424ccc08ec282f9 commit 3538d39da5877e597441971b5424ccc08ec282f9 Author: gab <gab@chromium.org> Date: Thu Jun 01 20:28:50 2017 Replace deprecated base::NonThreadSafe in chrome/browser/printing in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. Review-Url: https://codereview.chromium.org/2908273002 Cr-Commit-Position: refs/heads/master@{#476413} [modify] https://crrev.com/3538d39da5877e597441971b5424ccc08ec282f9/chrome/browser/printing/background_printing_manager.cc [modify] https://crrev.com/3538d39da5877e597441971b5424ccc08ec282f9/chrome/browser/printing/background_printing_manager.h
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4738228e37a570f880553bad7c77d1d8512fd874 commit 4738228e37a570f880553bad7c77d1d8512fd874 Author: gab <gab@chromium.org> Date: Thu Jun 01 20:30:11 2017 Deprecate NonThreadSafe in storage/browser/blob in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=jianli@chromium.org Review-Url: https://codereview.chromium.org/2912823002 Cr-Commit-Position: refs/heads/master@{#476415} [modify] https://crrev.com/4738228e37a570f880553bad7c77d1d8512fd874/storage/browser/blob/shareable_file_reference.cc
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eda899c5bbc75f81b298fc206da835b9884bde2e commit eda899c5bbc75f81b298fc206da835b9884bde2e Author: gab <gab@chromium.org> Date: Thu Jun 01 20:53:58 2017 Replace deprecated base::NonThreadSafe in media/gpu in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=posciak@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2911113003 Cr-Commit-Position: refs/heads/master@{#476429} [modify] https://crrev.com/eda899c5bbc75f81b298fc206da835b9884bde2e/media/gpu/ipc/client/gpu_jpeg_decode_accelerator_host.cc [modify] https://crrev.com/eda899c5bbc75f81b298fc206da835b9884bde2e/media/gpu/ipc/client/gpu_jpeg_decode_accelerator_host.h [modify] https://crrev.com/eda899c5bbc75f81b298fc206da835b9884bde2e/media/gpu/ipc/client/gpu_video_decode_accelerator_host.cc [modify] https://crrev.com/eda899c5bbc75f81b298fc206da835b9884bde2e/media/gpu/ipc/client/gpu_video_decode_accelerator_host.h [modify] https://crrev.com/eda899c5bbc75f81b298fc206da835b9884bde2e/media/gpu/ipc/client/gpu_video_encode_accelerator_host.cc [modify] https://crrev.com/eda899c5bbc75f81b298fc206da835b9884bde2e/media/gpu/ipc/client/gpu_video_encode_accelerator_host.h [modify] https://crrev.com/eda899c5bbc75f81b298fc206da835b9884bde2e/media/gpu/ipc/service/gpu_jpeg_decode_accelerator.cc [modify] https://crrev.com/eda899c5bbc75f81b298fc206da835b9884bde2e/media/gpu/ipc/service/gpu_jpeg_decode_accelerator.h [modify] https://crrev.com/eda899c5bbc75f81b298fc206da835b9884bde2e/media/gpu/vaapi_picture.cc [modify] https://crrev.com/eda899c5bbc75f81b298fc206da835b9884bde2e/media/gpu/vaapi_picture.h
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/582f3d53c92a020931828dc67e6a849db4f56f93 commit 582f3d53c92a020931828dc67e6a849db4f56f93 Author: gab <gab@chromium.org> Date: Fri Jun 02 15:24:39 2017 Deprecate NonThreadSafe in components/invalidation in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=nyquist@chromium.org Review-Url: https://codereview.chromium.org/2909113002 Cr-Commit-Position: refs/heads/master@{#476661} [modify] https://crrev.com/582f3d53c92a020931828dc67e6a849db4f56f93/components/invalidation/impl/gcm_invalidation_bridge.cc [modify] https://crrev.com/582f3d53c92a020931828dc67e6a849db4f56f93/components/invalidation/impl/gcm_invalidation_bridge.h [modify] https://crrev.com/582f3d53c92a020931828dc67e6a849db4f56f93/components/invalidation/impl/gcm_network_channel.cc [modify] https://crrev.com/582f3d53c92a020931828dc67e6a849db4f56f93/components/invalidation/impl/gcm_network_channel.h [modify] https://crrev.com/582f3d53c92a020931828dc67e6a849db4f56f93/components/invalidation/impl/invalidation_notifier.cc [modify] https://crrev.com/582f3d53c92a020931828dc67e6a849db4f56f93/components/invalidation/impl/invalidation_notifier.h [modify] https://crrev.com/582f3d53c92a020931828dc67e6a849db4f56f93/components/invalidation/impl/invalidation_service_android.cc [modify] https://crrev.com/582f3d53c92a020931828dc67e6a849db4f56f93/components/invalidation/impl/invalidation_service_android.h [modify] https://crrev.com/582f3d53c92a020931828dc67e6a849db4f56f93/components/invalidation/impl/p2p_invalidation_service.cc [modify] https://crrev.com/582f3d53c92a020931828dc67e6a849db4f56f93/components/invalidation/impl/p2p_invalidation_service.h [modify] https://crrev.com/582f3d53c92a020931828dc67e6a849db4f56f93/components/invalidation/impl/registration_manager.cc [modify] https://crrev.com/582f3d53c92a020931828dc67e6a849db4f56f93/components/invalidation/impl/registration_manager.h [modify] https://crrev.com/582f3d53c92a020931828dc67e6a849db4f56f93/components/invalidation/impl/sync_invalidation_listener.cc [modify] https://crrev.com/582f3d53c92a020931828dc67e6a849db4f56f93/components/invalidation/impl/sync_invalidation_listener.h [modify] https://crrev.com/582f3d53c92a020931828dc67e6a849db4f56f93/components/invalidation/impl/ticl_invalidation_service.cc [modify] https://crrev.com/582f3d53c92a020931828dc67e6a849db4f56f93/components/invalidation/impl/ticl_invalidation_service.h
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47aa7da88b306da3da8cefa5180ddcad753107f5 commit 47aa7da88b306da3da8cefa5180ddcad753107f5 Author: gab <gab@chromium.org> Date: Fri Jun 02 16:09:43 2017 Deprecate NonThreadSafe in net/ in favor of ThreadChecker. This change was scripted by the ThreadChecker equivalent of https://crbug.com/676387#c8. Noteworthy: * ~NonThreadSafe() used to implicitly check, ~ThreadChecker() doesn't so explicit checks were added in relevant destructors to maintain status quo * NonThreadSafe provided a public interface for CalledOnValidThread() and protected for DetachFromThread(). The ThreadChecker was exposed as protected where required and public AssertCalledOnValidThread() methods added as appropriate. BUG=676387 TBR=alokp,benwells Review-Url: https://codereview.chromium.org/2910473005 Cr-Commit-Position: refs/heads/master@{#476681} [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/chrome/browser/custom_handlers/protocol_handler_registry.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/chromecast/browser/cast_network_delegate.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/base/backoff_entry.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/base/backoff_entry.h [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/base/network_change_notifier_win.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/base/network_change_notifier_win.h [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/base/network_delegate.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/base/network_delegate.h [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/base/priority_queue.h [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/cert/multi_threaded_cert_verifier.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/cert/multi_threaded_cert_verifier.h [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/dns/address_sorter_posix.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/dns/address_sorter_posix.h [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/dns/dns_config_service.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/dns/dns_config_service.h [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/dns/dns_config_service_posix.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/dns/dns_config_service_win.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/dns/dns_transaction.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/dns/host_cache.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/dns/host_cache.h [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/dns/host_resolver_impl.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/dns/host_resolver_impl.h [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/dns/mock_host_resolver.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/dns/mock_host_resolver.h [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/http/http_auth_controller.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/http/http_auth_controller.h [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/http/http_cache.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/http/http_cache.h [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/http/http_network_layer.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/http/http_network_layer.h [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/http/http_network_session.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/http/http_network_session.h [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/http/http_server_properties_impl.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/http/http_server_properties_impl.h [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/http/transport_security_state.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/http/transport_security_state.h [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/log/net_log_util.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/log/write_to_file_net_log_observer.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/proxy/dhcp_proxy_script_adapter_fetcher_win.h [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/proxy/dhcp_proxy_script_fetcher_win.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/proxy/dhcp_proxy_script_fetcher_win.h [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/proxy/multi_threaded_proxy_resolver.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/proxy/proxy_resolver_v8_tracing.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/proxy/proxy_service.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/proxy/proxy_service.h [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/ssl/channel_id_service.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/ssl/channel_id_service.h [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/ssl/channel_id_store.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/ssl/channel_id_store.h [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/ssl/default_channel_id_store.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/url_request/sdch_dictionary_fetcher.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/url_request/sdch_dictionary_fetcher.h [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/url_request/test_url_fetcher_factory.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/url_request/test_url_fetcher_factory.h [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/url_request/url_request.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/url_request/url_request.h [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/url_request/url_request_context.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/url_request/url_request_context.h [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/url_request/url_request_intercepting_job_factory.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/url_request/url_request_job_factory.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/url_request/url_request_job_factory.h [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/url_request/url_request_job_factory_impl.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/url_request/url_request_throttler_manager.cc [modify] https://crrev.com/47aa7da88b306da3da8cefa5180ddcad753107f5/net/url_request/url_request_throttler_manager.h
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99ff1d83a3574b1b689ad35d7a14688eee88f97a commit 99ff1d83a3574b1b689ad35d7a14688eee88f97a Author: gab <gab@chromium.org> Date: Fri Jun 02 16:29:12 2017 Replace deprecated base::NonThreadSafe in chrome/browser/profiles. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Then favored DCHECK_CURRENTLY_ON(UI) per reviewer request. And ultimately used ThreadChecker per https://codereview.chromium.org/2907253003/#msg37. BUG=676387 This CL was uploaded by git cl split. R=bauerb@chromium.org TBR=sorin, pauljensen Review-Url: https://codereview.chromium.org/2907253003 Cr-Commit-Position: refs/heads/master@{#476684} [modify] https://crrev.com/99ff1d83a3574b1b689ad35d7a14688eee88f97a/chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc [modify] https://crrev.com/99ff1d83a3574b1b689ad35d7a14688eee88f97a/chrome/browser/history/android/android_history_provider_service_unittest.cc [modify] https://crrev.com/99ff1d83a3574b1b689ad35d7a14688eee88f97a/chrome/browser/history/android/sqlite_cursor_unittest.cc [modify] https://crrev.com/99ff1d83a3574b1b689ad35d7a14688eee88f97a/chrome/browser/profiles/profile_attributes_storage_unittest.cc [modify] https://crrev.com/99ff1d83a3574b1b689ad35d7a14688eee88f97a/chrome/browser/profiles/profile_manager.cc [modify] https://crrev.com/99ff1d83a3574b1b689ad35d7a14688eee88f97a/chrome/browser/profiles/profile_manager.h
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a58cd0bd4e7fee28aceddd7a6310f820cace3f7d commit a58cd0bd4e7fee28aceddd7a6310f820cace3f7d Author: gab <gab@chromium.org> Date: Fri Jun 02 16:33:03 2017 Deprecate NonThreadSafe in content/renderer/media in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=wolenetz@chromium.org Review-Url: https://codereview.chromium.org/2909103002 Cr-Commit-Position: refs/heads/master@{#476688} [modify] https://crrev.com/a58cd0bd4e7fee28aceddd7a6310f820cace3f7d/content/renderer/media/media_stream_video_source.cc [modify] https://crrev.com/a58cd0bd4e7fee28aceddd7a6310f820cace3f7d/content/renderer/media/media_stream_video_source.h [modify] https://crrev.com/a58cd0bd4e7fee28aceddd7a6310f820cace3f7d/content/renderer/media/pepper_to_video_track_adapter.cc [modify] https://crrev.com/a58cd0bd4e7fee28aceddd7a6310f820cace3f7d/content/renderer/media/rtc_dtmf_sender_handler.cc [modify] https://crrev.com/a58cd0bd4e7fee28aceddd7a6310f820cace3f7d/content/renderer/media/rtc_dtmf_sender_handler.h [modify] https://crrev.com/a58cd0bd4e7fee28aceddd7a6310f820cace3f7d/content/renderer/media/user_media_client_impl.cc [modify] https://crrev.com/a58cd0bd4e7fee28aceddd7a6310f820cace3f7d/content/renderer/media/user_media_client_impl.h [modify] https://crrev.com/a58cd0bd4e7fee28aceddd7a6310f820cace3f7d/content/renderer/media/webrtc/media_stream_remote_video_source.cc [modify] https://crrev.com/a58cd0bd4e7fee28aceddd7a6310f820cace3f7d/content/renderer/media/webrtc_audio_renderer.h [modify] https://crrev.com/a58cd0bd4e7fee28aceddd7a6310f820cace3f7d/content/renderer/media/webrtc_uma_histograms.cc [modify] https://crrev.com/a58cd0bd4e7fee28aceddd7a6310f820cace3f7d/content/renderer/media/webrtc_uma_histograms.h
,
Jun 2 2017
FTR, attached is the latest (and last) version of my script, previous one was handling "NON_EXPORTED_BASE(public base::NonThreadSafe)" but not "public NON_EXPORTED_BASE(base::NonThreadSafe)"... A few more CLs with this update and we're DONNNEEE!!
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/728abbb55ee7c2da5819b56c22bbedd79fb0e09b commit 728abbb55ee7c2da5819b56c22bbedd79fb0e09b Author: gab <gab@chromium.org> Date: Fri Jun 02 18:17:16 2017 Replace deprecated base::NonThreadSafe in ui\gfx\image_skia.cc in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! ImageSkiaStorage doesn't appear thread-affine so that's most likely a no-op. * ~NonThreadSafe() used to implcitly check in its destructor ~SequenceChecker() doesn't by design. Hence this CL allows removing the explicit Detach from ~ImageSkiaStorage(). BUG=676387 Review-Url: https://codereview.chromium.org/2922463002 Cr-Commit-Position: refs/heads/master@{#476727} [modify] https://crrev.com/728abbb55ee7c2da5819b56c22bbedd79fb0e09b/ui/gfx/image/image_skia.cc [modify] https://crrev.com/728abbb55ee7c2da5819b56c22bbedd79fb0e09b/ui/gfx/image/image_skia.h [modify] https://crrev.com/728abbb55ee7c2da5819b56c22bbedd79fb0e09b/ui/gfx/image/image_skia_unittest.cc
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17bf185c1ff5d8cc7f3a9d501e140136e3482911 commit 17bf185c1ff5d8cc7f3a9d501e140136e3482911 Author: gab <gab@chromium.org> Date: Fri Jun 02 19:05:41 2017 ThreadChecker instead of SequenceChecker in classes that use TLS. A few incorrect SequenceChecker slipped through reviews in mass migration of base::NonThreadSafe. As documented on those CLs, usage of ThreadLocalStorage requires thread-affinity (ThreadChecker instead of SequenceChecker). BUG=676387 Review-Url: https://codereview.chromium.org/2916303002 Cr-Commit-Position: refs/heads/master@{#476742} [modify] https://crrev.com/17bf185c1ff5d8cc7f3a9d501e140136e3482911/chrome/service/cloud_print/cloud_print_token_store.cc [modify] https://crrev.com/17bf185c1ff5d8cc7f3a9d501e140136e3482911/chrome/service/cloud_print/cloud_print_token_store.h [modify] https://crrev.com/17bf185c1ff5d8cc7f3a9d501e140136e3482911/content/child/fileapi/webfilesystem_impl.cc [modify] https://crrev.com/17bf185c1ff5d8cc7f3a9d501e140136e3482911/content/child/fileapi/webfilesystem_impl.h
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2510d3fbc38be38f5c8cd870dc9d7329d0f43a99 commit 2510d3fbc38be38f5c8cd870dc9d7329d0f43a99 Author: gab <gab@chromium.org> Date: Fri Jun 02 19:20:18 2017 Replace deprecated base::NonThreadSafe in /content/browser/speech in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c84. If you're wondering why there's a second wave of this, the first version of the script handled "NON_EXPORTED_BASE(public base::NonThreadSafe)" but not "public NON_EXPORTED_BASE(base::NonThreadSafe)"... Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implicitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=tommi@chromium.org Review-Url: https://codereview.chromium.org/2919993002 Cr-Commit-Position: refs/heads/master@{#476748} [modify] https://crrev.com/2510d3fbc38be38f5c8cd870dc9d7329d0f43a99/content/browser/speech/speech_recognition_engine.cc [modify] https://crrev.com/2510d3fbc38be38f5c8cd870dc9d7329d0f43a99/content/browser/speech/speech_recognition_engine.h
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05b0011942b32c97bcb9dbffa6deceb5e31b85b8 commit 05b0011942b32c97bcb9dbffa6deceb5e31b85b8 Author: gab <gab@chromium.org> Date: Fri Jun 02 19:23:31 2017 Replace deprecated base::NonThreadSafe in /cc in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c84. If you're wondering why there's a second wave of this, the first version of the script handled "NON_EXPORTED_BASE(public base::NonThreadSafe)" but not "public NON_EXPORTED_BASE(base::NonThreadSafe)"... Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implicitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=sunnyps@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2919103002 Cr-Commit-Position: refs/heads/master@{#476750} [modify] https://crrev.com/05b0011942b32c97bcb9dbffa6deceb5e31b85b8/cc/test/fake_external_begin_frame_source.cc [modify] https://crrev.com/05b0011942b32c97bcb9dbffa6deceb5e31b85b8/cc/test/fake_external_begin_frame_source.h
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db0d68b9a8438d6d8480f5372f984c035dfdae57 commit db0d68b9a8438d6d8480f5372f984c035dfdae57 Author: gab <gab@chromium.org> Date: Fri Jun 02 19:33:47 2017 Replace deprecated base::NonThreadSafe in /extensions/renderer/api/display_source in favor of ThreadChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c84. (amend to use ThreadChecker instead of SequenceChecker to make this CL a no-op and expedite it per being the very last one!) If you're wondering why there's a second wave of this, the first version of the script handled "NON_EXPORTED_BASE(public base::NonThreadSafe)" but not "public NON_EXPORTED_BASE(base::NonThreadSafe)"... Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implicitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. TBR=alexander.shalamov@intel.com Review-Url: https://codereview.chromium.org/2918113004 Cr-Commit-Position: refs/heads/master@{#476754} [modify] https://crrev.com/db0d68b9a8438d6d8480f5372f984c035dfdae57/extensions/renderer/api/display_source/wifi_display/wifi_display_transport_stream_packetizer.cc [modify] https://crrev.com/db0d68b9a8438d6d8480f5372f984c035dfdae57/extensions/renderer/api/display_source/wifi_display/wifi_display_transport_stream_packetizer.h
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c2beea1d9791f49c8a44084dead3632dfcff09b commit 6c2beea1d9791f49c8a44084dead3632dfcff09b Author: gab <gab@chromium.org> Date: Fri Jun 02 21:07:30 2017 Replace deprecated base::NonThreadSafe in /media/audio in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c84. If you're wondering why there's a second wave of this, the first version of the script handled "NON_EXPORTED_BASE(public base::NonThreadSafe)" but not "public NON_EXPORTED_BASE(base::NonThreadSafe)"... Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implicitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=justinlin@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2921033002 Cr-Commit-Position: refs/heads/master@{#476785} [modify] https://crrev.com/6c2beea1d9791f49c8a44084dead3632dfcff09b/media/audio/audio_output_proxy.cc [modify] https://crrev.com/6c2beea1d9791f49c8a44084dead3632dfcff09b/media/audio/audio_output_proxy.h
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9354aaa8274db4ad73d22c98941435e596a818df commit 9354aaa8274db4ad73d22c98941435e596a818df Author: gab <gab@chromium.org> Date: Fri Jun 02 21:12:37 2017 Replace deprecated base::NonThreadSafe in /content/browser/loader in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c84. If you're wondering why there's a second wave of this, the first version of the script handled "NON_EXPORTED_BASE(public base::NonThreadSafe)" but not "public NON_EXPORTED_BASE(base::NonThreadSafe)"... Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implicitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. Review-Url: https://codereview.chromium.org/2915313002 Cr-Commit-Position: refs/heads/master@{#476791} [modify] https://crrev.com/9354aaa8274db4ad73d22c98941435e596a818df/content/browser/loader/resource_handler.cc [modify] https://crrev.com/9354aaa8274db4ad73d22c98941435e596a818df/content/browser/loader/resource_handler.h
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0a378fde6de7bd1e63db9b8249600f4ab4feaf9 commit b0a378fde6de7bd1e63db9b8249600f4ab4feaf9 Author: gab <gab@chromium.org> Date: Fri Jun 02 22:09:37 2017 Replace deprecated base::NonThreadSafe in /content/renderer/gpu in favor of ThreadChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c84. (amended to use ThreadChecker upon reviewer request) If you're wondering why there's a second wave of this, the first version of the script handled "NON_EXPORTED_BASE(public base::NonThreadSafe)" but not "public NON_EXPORTED_BASE(base::NonThreadSafe)"... Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implicitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=kbr@chromium.org Review-Url: https://codereview.chromium.org/2918083003 Cr-Commit-Position: refs/heads/master@{#476810} [modify] https://crrev.com/b0a378fde6de7bd1e63db9b8249600f4ab4feaf9/content/renderer/gpu/compositor_external_begin_frame_source.cc [modify] https://crrev.com/b0a378fde6de7bd1e63db9b8249600f4ab4feaf9/content/renderer/gpu/compositor_external_begin_frame_source.h
,
Jun 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60b3f18fedd0b2eb42a06d719cd121ecf7214c4b commit 60b3f18fedd0b2eb42a06d719cd121ecf7214c4b Author: gab <gab@chromium.org> Date: Mon Jun 05 02:27:23 2017 Update a comment in proxy_resolution_service_provider_unittest.cc following deprecation of base::NonThreadSafe. BUG=676387 Review-Url: https://codereview.chromium.org/2921013003 Cr-Commit-Position: refs/heads/master@{#476924} [modify] https://crrev.com/60b3f18fedd0b2eb42a06d719cd121ecf7214c4b/chromeos/dbus/services/proxy_resolution_service_provider_unittest.cc
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a6e9d93719ad9f51c1f6f89e1e080d3131e07e2 commit 4a6e9d93719ad9f51c1f6f89e1e080d3131e07e2 Author: gab <gab@chromium.org> Date: Tue Jun 06 16:02:50 2017 Replace ENABLE_NON_THREAD_SAFE with DCHECK_IS_ON() in image_skia_unittest.cc NonThreadSafe is gone and DCHECK_IS_ON() is the right construct to express such requirements now. BUG=676387 Review-Url: https://codereview.chromium.org/2923223002 Cr-Commit-Position: refs/heads/master@{#477303} [modify] https://crrev.com/4a6e9d93719ad9f51c1f6f89e1e080d3131e07e2/ui/gfx/image/image_skia_unittest.cc
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c64944c2f2b156865e2936879d9ca12a972a5501 commit c64944c2f2b156865e2936879d9ca12a972a5501 Author: gab <gab@chromium.org> Date: Tue Jun 06 16:09:53 2017 Remove base::NonThreadSafe now that all users are gone!! And get rid of the few already unused includes of non_thread_safe.h BUG=676387 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=gab@chromium.org (for unused includes) TBR=thestig@chromium.org (for removing unused NonThreadSafe) Review-Url: https://codereview.chromium.org/2921903003 Cr-Commit-Position: refs/heads/master@{#477305} [modify] https://crrev.com/c64944c2f2b156865e2936879d9ca12a972a5501/PRESUBMIT.py [modify] https://crrev.com/c64944c2f2b156865e2936879d9ca12a972a5501/base/BUILD.gn [modify] https://crrev.com/c64944c2f2b156865e2936879d9ca12a972a5501/base/ios/weak_nsobject.h [delete] https://crrev.com/a6215bc06ce7fc233fe1cedab27988d6cbd5b9c4/base/threading/non_thread_safe.h [delete] https://crrev.com/a6215bc06ce7fc233fe1cedab27988d6cbd5b9c4/base/threading/non_thread_safe_impl.cc [delete] https://crrev.com/a6215bc06ce7fc233fe1cedab27988d6cbd5b9c4/base/threading/non_thread_safe_impl.h [delete] https://crrev.com/a6215bc06ce7fc233fe1cedab27988d6cbd5b9c4/base/threading/non_thread_safe_unittest.cc [modify] https://crrev.com/c64944c2f2b156865e2936879d9ca12a972a5501/base/threading/thread_checker_impl.h [modify] https://crrev.com/c64944c2f2b156865e2936879d9ca12a972a5501/chrome/browser/printing/print_job_manager.h [modify] https://crrev.com/c64944c2f2b156865e2936879d9ca12a972a5501/chrome/test/base/in_process_browser_test.cc [modify] https://crrev.com/c64944c2f2b156865e2936879d9ca12a972a5501/components/autofill/core/browser/webdata/autocomplete_sync_bridge.h [modify] https://crrev.com/c64944c2f2b156865e2936879d9ca12a972a5501/components/invalidation/impl/sync_system_resources.h [modify] https://crrev.com/c64944c2f2b156865e2936879d9ca12a972a5501/components/sync/driver/sync_stopped_reporter_unittest.cc [modify] https://crrev.com/c64944c2f2b156865e2936879d9ca12a972a5501/components/sync/engine_impl/net/server_connection_manager.h [modify] https://crrev.com/c64944c2f2b156865e2936879d9ca12a972a5501/content/browser/compositor/browser_compositor_output_surface.h [modify] https://crrev.com/c64944c2f2b156865e2936879d9ca12a972a5501/content/public/browser/ssl_host_state_delegate.h [modify] https://crrev.com/c64944c2f2b156865e2936879d9ca12a972a5501/media/cast/net/pacing/paced_sender.h [modify] https://crrev.com/c64944c2f2b156865e2936879d9ca12a972a5501/media/gpu/dxva_video_decode_accelerator_win.h [modify] https://crrev.com/c64944c2f2b156865e2936879d9ca12a972a5501/media/gpu/vaapi_jpeg_decode_accelerator.h [modify] https://crrev.com/c64944c2f2b156865e2936879d9ca12a972a5501/remoting/host/it2me/it2me_confirmation_dialog_proxy.h [modify] https://crrev.com/c64944c2f2b156865e2936879d9ca12a972a5501/remoting/host/local_input_monitor_chromeos.cc [modify] https://crrev.com/c64944c2f2b156865e2936879d9ca12a972a5501/remoting/protocol/transport.h [modify] https://crrev.com/c64944c2f2b156865e2936879d9ca12a972a5501/services/ui/gpu/gpu_service.h [modify] https://crrev.com/c64944c2f2b156865e2936879d9ca12a972a5501/storage/browser/quota/usage_tracker.h [modify] https://crrev.com/c64944c2f2b156865e2936879d9ca12a972a5501/ui/gfx/android/view_configuration.cc
,
Jun 6 2017
\o/!!!!
,
Jun 20 2017
Issue 341945 has been merged into this issue. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 Deleted