Clean up and refactor platform/AudioDestination |
|||
Issue descriptionThe current design of AudioDestination has few issues. - Update AudioIOCallback to match the removal of input(source) in the render callback. - Clarify variable names for the better description. - Remove RefPtr. - Plus trivial clean up and reordering. - Add/update the comment. Some of them are irrelevant or out-of-date. It is ideal to clean them up before introducing the new FIFO structure for the AudioWorkletNode.
,
Dec 22 2016
,
Jan 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c44e4f0a2120f24a6701298868befa1b2adc1ce8 commit c44e4f0a2120f24a6701298868befa1b2adc1ce8 Author: hongchan <hongchan@chromium.org> Date: Wed Jan 04 00:50:43 2017 Clean up and refactor platform/AudioDestination - Code clean up, refactoring and reordering. - Add/update the comment. Some of them are irrelevant or out-of-date. BUG= 676386 Review-Url: https://codereview.chromium.org/2590823007 Cr-Commit-Position: refs/heads/master@{#441270} [modify] https://crrev.com/c44e4f0a2120f24a6701298868befa1b2adc1ce8/third_party/WebKit/Source/modules/webaudio/DefaultAudioDestinationNode.cpp [modify] https://crrev.com/c44e4f0a2120f24a6701298868befa1b2adc1ce8/third_party/WebKit/Source/platform/audio/AudioDestination.cpp [modify] https://crrev.com/c44e4f0a2120f24a6701298868befa1b2adc1ce8/third_party/WebKit/Source/platform/audio/AudioDestination.h
,
Jan 4 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by hongchan@chromium.org
, Dec 21 2016