New issue
Advanced search Search tips

Issue 676379 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature
V1

Blocked on:
issue 676648



Sign in to add a comment

Support Chromad password change on client

Project Member Reported by tnagel@chromium.org, Dec 21 2016

Issue description

This is most urgently needed for passwords that have been expired by the server, but it would be a bonus if the implementation worked for user-initiated password change as well (because we'll need that sooner or later anyways).
 

Comment 1 by tnagel@chromium.org, Dec 21 2016

Labels: -Pri-3 V1 Pri-1
After offline discussion with David: We need that for V1.

Comment 2 by tnagel@chromium.org, Dec 22 2016

Description: Show this description
Status: Started (was: Assigned)
Blockedon: 676648
Labels: M-57

Comment 6 by tnagel@chromium.org, Dec 23 2016

> Labels: M-57

Yay!!
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4d910ca4585f7bd18087ca0b4ce5c2cfaff23889

commit 4d910ca4585f7bd18087ca0b4ce5c2cfaff23889
Author: Lutz Justen <ljusten@google.com>
Date: Fri Dec 23 10:58:16 2016

authpolicy: Handle password expiration

Checks the output of kinit for password expiration and other error
cases and returns a proper error code.

In addition, writes the default realm to krb5.conf since kinit expects
it in case the password expires. In particular, use the realm used for
machine join during device policy fetch and the realm entered by the
user during user auth. Note that the two might not coincide.

BUG= chromium:676379 
TEST=Compiles, tested with custom test code.

Change-Id: I3dd480a2a968505733a755bef924bef0320cb667
Reviewed-on: https://chromium-review.googlesource.com/423068
Commit-Ready: Roman Sorokin <rsorokin@chromium.org>
Tested-by: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/4d910ca4585f7bd18087ca0b4ce5c2cfaff23889/authpolicy/errors.h
[modify] https://crrev.com/4d910ca4585f7bd18087ca0b4ce5c2cfaff23889/authpolicy/samba_interface.cc
[modify] https://crrev.com/4d910ca4585f7bd18087ca0b4ce5c2cfaff23889/authpolicy/errors.cc

Chrome CL is in the pipeline: https://codereview.chromium.org/2602973002/
Labels: Enterprise-Triaged
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd

commit 429c374b9e3b3a7400b1e5fbcfc3a18252e871cd
Author: rsorokin <rsorokin@chromium.org>
Date: Tue Jan 17 11:33:50 2017

Add Active Directory password change screen.

BUG= 676379 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=grt@chromium.org

Review-Url: https://codereview.chromium.org/2602973002
Cr-Commit-Position: refs/heads/master@{#444026}

[modify] https://crrev.com/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd/chrome/browser/chromeos/login/oobe_screen.cc
[modify] https://crrev.com/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd/chrome/browser/chromeos/login/oobe_screen.h
[modify] https://crrev.com/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd/chrome/browser/chromeos/login/screens/core_oobe_actor.h
[add] https://crrev.com/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd/chrome/browser/resources/chromeos/login/active_directory_password_change.html
[add] https://crrev.com/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd/chrome/browser/resources/chromeos/login/active_directory_password_change.js
[modify] https://crrev.com/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd/chrome/browser/resources/chromeos/login/custom_elements_login.html
[modify] https://crrev.com/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd/chrome/browser/resources/chromeos/login/custom_elements_login.js
[modify] https://crrev.com/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd/chrome/browser/resources/chromeos/login/custom_elements_oobe.html
[modify] https://crrev.com/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd/chrome/browser/resources/chromeos/login/custom_elements_oobe.js
[modify] https://crrev.com/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd/chrome/browser/resources/chromeos/login/login.js
[modify] https://crrev.com/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd/chrome/browser/resources/chromeos/login/login_non_lock_shared.html
[modify] https://crrev.com/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd/chrome/browser/resources/chromeos/login/login_non_lock_shared.js
[modify] https://crrev.com/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd/chrome/browser/resources/chromeos/login/login_screens.html
[modify] https://crrev.com/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd/chrome/browser/resources/chromeos/login/login_shared.js
[modify] https://crrev.com/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd/chrome/browser/resources/chromeos/login/oobe.js
[modify] https://crrev.com/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd/chrome/browser/resources/chromeos/login/oobe_screens.html
[add] https://crrev.com/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd/chrome/browser/resources/chromeos/login/screen_active_directory_password_change.css
[add] https://crrev.com/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd/chrome/browser/resources/chromeos/login/screen_active_directory_password_change.html
[add] https://crrev.com/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd/chrome/browser/resources/chromeos/login/screen_active_directory_password_change.js
[modify] https://crrev.com/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc
[modify] https://crrev.com/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h
[modify] https://crrev.com/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h
[modify] https://crrev.com/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
[modify] https://crrev.com/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd/ui/login/display_manager.js
[modify] https://crrev.com/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd/ui/login/screen_container.css

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
bulk Verify of Chromad V1 bugs

Sign in to add a comment