New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 676375 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Unify SurfaceInfo and use everywhere

Project Member Reported by fsam...@chromium.org, Dec 21 2016

Issue description

We currently have two SurfaceInfo objects:

ui/aura/mus/surface_id_handler.h's SurfaceInfo

and cc/surfaces/surface_info.h

We should use cc::SurfaceInfo instead, allow transmitting it over mojo (and Chrome IPC if necessary), and replace all call sites where the fields are passed individually with SurfaceInfo.

SurfaceInfo becomes part of the Mus API: It is the bundle of state necessary to embed a Surface across processes.
 
1. SurfaceInfo in SurfaceIdHandler should go away
2. DisplayCompositorClient should use SurfaceInfo.
3. OffscreenCanvasSurfaceInfo should use SurfaceInfo and should propagate all the way into Blink.
4. ChildFrameCompositingHelper::OnSetSurface should use SurfaceInfo
SurfaceObserver::OnSurfaceCreated should take in a SurfaceInfo too.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96795520bafe2e33f755948f2d732cb42d10504a

commit 96795520bafe2e33f755948f2d732cb42d10504a
Author: fsamuel <fsamuel@chromium.org>
Date: Wed Jan 04 02:41:32 2017

Unify SurfaceInfo

Previously, we had two SurfaceInfo objects:

ui/aura/mus/surface_id_handler.h's SurfaceInfo

and cc/surfaces/surface_info.h

This CL switches to using cc::SurfaceInfo instead, transmitting it over
mojo and replaces all call sites where the fields are passed
individually.

SurfaceInfo becomes part of the Mus API: It is the bundle of state
necessary to embed a Surface across processes.

BUG= 676375 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2610723002
Cr-Commit-Position: refs/heads/master@{#441301}

[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/cc/ipc/BUILD.gn
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/cc/ipc/display_compositor.mojom
[add] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/cc/ipc/surface_info.mojom
[add] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/cc/ipc/surface_info.typemap
[add] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/cc/ipc/surface_info_struct_traits.h
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/cc/ipc/typemaps.gni
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/cc/surfaces/display.cc
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/cc/surfaces/display.h
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/cc/surfaces/surface_factory.cc
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/cc/surfaces/surface_factory_unittest.cc
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/cc/surfaces/surface_info.h
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/cc/surfaces/surface_manager.cc
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/cc/surfaces/surface_manager.h
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/cc/surfaces/surface_observer.h
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/content/browser/renderer_host/offscreen_canvas_surface_impl.cc
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/content/browser/renderer_host/offscreen_canvas_surface_impl.h
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/content/browser/renderer_host/offscreen_canvas_surface_manager.cc
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/content/browser/renderer_host/offscreen_canvas_surface_manager.h
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/content/browser/renderer_host/offscreen_canvas_surface_manager_unittest.cc
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/content/renderer/child_frame_compositing_helper.cc
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/content/renderer/child_frame_compositing_helper.h
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/services/ui/public/cpp/surface_id_handler.h
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/services/ui/public/cpp/window.cc
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/services/ui/public/cpp/window.h
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/services/ui/public/cpp/window_private.h
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/services/ui/public/cpp/window_tree_client.cc
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/services/ui/public/cpp/window_tree_client.h
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/services/ui/public/interfaces/window_tree.mojom
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/services/ui/surfaces/display_compositor.cc
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/services/ui/surfaces/display_compositor.h
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/services/ui/surfaces/display_compositor_unittest.cc
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/services/ui/ws/frame_generator_unittest.cc
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/services/ui/ws/server_window_compositor_frame_sink_manager.cc
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/services/ui/ws/server_window_compositor_frame_sink_manager.h
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/services/ui/ws/test_change_tracker.cc
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/services/ui/ws/test_change_tracker.h
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/services/ui/ws/test_utils.cc
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/services/ui/ws/test_utils.h
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/services/ui/ws/window_server.cc
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/services/ui/ws/window_server.h
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/services/ui/ws/window_tree.cc
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/services/ui/ws/window_tree.h
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/services/ui/ws/window_tree_client_unittest.cc
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.h
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/third_party/WebKit/public/blink_typemaps.gni
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/ui/aura/mus/DEPS
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/ui/aura/mus/surface_id_handler.h
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/ui/aura/mus/window_mus.h
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/ui/aura/mus/window_port_mus.cc
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/ui/aura/mus/window_port_mus.h
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a/ui/aura/mus/window_tree_client.h

Owner: fsam...@chromium.org
Status: Fixed (was: Untriaged)
This should be fixed now.
Blocking: -601863
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment