New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 676366 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 668164
Owner:
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----

Blocked on:
issue 676416



Sign in to add a comment

dromaeo.jslibmodifyjquery failing on 4 builders

Project Member Reported by martiniss@chromium.org, Dec 21 2016

Issue description

dromaeo.jslibmodifyjquery failing on 4 builders

Type: build-failure

Builders failed on: 
- Win 10 Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Win%2010%20Perf
- Win 7 ATI GPU Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Win%207%20ATI%20GPU%20Perf
- Win 7 Intel GPU Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Win%207%20Intel%20GPU%20Perf
- Win 7 Nvidia GPU Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Win%207%20Nvidia%20GPU%20Perf

Looks like a bad CL caused this. Will run a bisect


 
Cc: benhenry@chromium.org sullivan@chromium.org
It looks like this test isn't monitored? (according to the perf dashboard) Should I just disable it?
Cc: yukishiino@chromium.org
Yes, please disable failing benchmarks, kick off a bisect, and assign to the owner to look into fixing.

Adding yukishiino, the owner from go/perf-owners.
Owner: yukishiino@chromium.org
Status: Assigned (was: Started)
Disabled the test. yukishiino@, can you take a look?
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91d919c415190952188b44f65976a28f5f3076e1

commit 91d919c415190952188b44f65976a28f5f3076e1
Author: martiniss <martiniss@chromium.org>
Date: Wed Dec 21 21:24:39 2016

Disable windows build for dromaeo.jslibmodifyjquery

R=sullivan
BUG= 676366 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2596943002
Cr-Commit-Position: refs/heads/master@{#440220}

[modify] https://crrev.com/91d919c415190952188b44f65976a28f5f3076e1/tools/perf/benchmarks/dromaeo.py

Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Dec 21 2016

Bisect failed: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_bisect/builds/818
Failure reason: the build has failed.

Bisect failed, but it pointed at https://codereview.chromium.org/2592713002 I think...
Cc: mlippautz@chromium.org
+mlippautz, not sure if this is a dupe?
To be clear, I'm not sure if it's safe to revert https://codereview.chromium.org/2592713002, or if it could have caused this failure. That's why I'm not directly reverting it. 

sullivan@, should we trust bisect in this case and just revert? Maybe I'm being too distrustful of bisect.
I think this is actually a dupe of  bug 668164 ? We should look at that one for context on whether to revert.
Please don't revert but rather disable the test; I will have a look tomorrow. Jochen mentioned that this might very well be an OOM since dromaeo often scratches at the 1.4GB heap limit.
Mergedinto: 668164
Status: Duplicate (was: Assigned)
Ah yes, looks like a dup. Dup-ed into  bug 668164 . I'll disable the test.
Blockedon: 676416
Project Member

Comment 15 by 42576172...@developer.gserviceaccount.com, Apr 11 2017

Owner: mlippautz@chromium.org

=== Auto-CCing suspected CL author mlippautz@chromium.org ===

Hi mlippautz@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Test failure found with culprit

Suspected Commit
  Author : mlippautz
  Commit : 39fc84f0cec650b199de0fa5d155454e2fa2d8a7
  Date   : Tue Dec 20 19:14:36 2016
  Subject: [wrapper-tracing] Reland: Turn on flag TraceWrappables

Bisect Details
  Configuration: winx64_10_perf_bisect
  Benchmark    : dromaeo.jslibmodifyjquery
  Metric       : board_temperature/board_temperature

Revision             Exit Code      N
chromium@439843      0 +- N/A       20      good
chromium@439858      0 +- N/A       20      good
chromium@439862      0 +- N/A       20      good
chromium@439864      0 +- N/A       20      good
chromium@439865      1 +- N/A       20      bad       <--
chromium@439872      1 +- N/A       20      bad
chromium@439895      1 +- N/A       20      bad
chromium@439947      1 +- N/A       20      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests dromaeo.jslibmodifyjquery

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8982651873027176864

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5208130458222592


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

Sign in to add a comment