New issue
Advanced search Search tips

Issue 676355 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 623160



Sign in to add a comment

Convert AudioBuffer tests to use testharness

Project Member Reported by rtoy@chromium.org, Dec 21 2016

Issue description

As the summary says, convert webaudio/AudioBuffer tests to use testharness

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01758e7540a3f0412d08edaa5253f94a3c7d9a9a

commit 01758e7540a3f0412d08edaa5253f94a3c7d9a9a
Author: rtoy <rtoy@chromium.org>
Date: Wed Jan 04 16:11:43 2017

Convert AudioBuffer Audit tests to testharness

Only the tests using Audit are converted here, using the script:

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(".*")\|finishJSTest()\);[ 	]*/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
done

Additional manual changes were needed to replace methods defined by
js-test.

Expected results files also removed.

BUG= 676355 
TEST=audiobuffer-copy-channel.html, audiobuffer-getChannelData.html

Review-Url: https://codereview.chromium.org/2593083002
Cr-Commit-Position: refs/heads/master@{#441383}

[delete] https://crrev.com/b901d5b1a44d24ffc592dd8293fd86ef984f87f6/third_party/WebKit/LayoutTests/webaudio/AudioBuffer/audiobuffer-copy-channel-expected.txt
[modify] https://crrev.com/01758e7540a3f0412d08edaa5253f94a3c7d9a9a/third_party/WebKit/LayoutTests/webaudio/AudioBuffer/audiobuffer-copy-channel.html
[delete] https://crrev.com/b901d5b1a44d24ffc592dd8293fd86ef984f87f6/third_party/WebKit/LayoutTests/webaudio/AudioBuffer/audiobuffer-getChannelData-expected.txt
[modify] https://crrev.com/01758e7540a3f0412d08edaa5253f94a3c7d9a9a/third_party/WebKit/LayoutTests/webaudio/AudioBuffer/audiobuffer-getChannelData.html

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49fe1c6f7e1960a24ed71a67e69de71371bf7ed5

commit 49fe1c6f7e1960a24ed71a67e69de71371bf7ed5
Author: rtoy <rtoy@chromium.org>
Date: Wed Jan 04 21:53:03 2017

Convert audiobuffer.html to testharness

Manually convert audiobuffer.html to use testharness

BUG= 676355 
TEST=audiobuffer.html

Review-Url: https://codereview.chromium.org/2595073002
Cr-Commit-Position: refs/heads/master@{#441477}

[delete] https://crrev.com/ee7bb192c6b0cef69ab9173df1ca589612449c63/third_party/WebKit/LayoutTests/webaudio/AudioBuffer/audiobuffer-expected.txt
[modify] https://crrev.com/49fe1c6f7e1960a24ed71a67e69de71371bf7ed5/third_party/WebKit/LayoutTests/webaudio/AudioBuffer/audiobuffer.html

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 5 2017

Comment 4 by rtoy@chromium.org, Jan 5 2017

Owner: rtoy@chromium.org
Status: Verified (was: Available)
Manually verified that all tests in AudioBuffer now use testharness.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f51edaef941956727d65a8f3ac7036684963fbb

commit 7f51edaef941956727d65a8f3ac7036684963fbb
Author: rtoy <rtoy@chromium.org>
Date: Tue Jan 10 20:22:29 2017

Convert AudioBufferSource tests using Audit to testharness

Only the tests using Audit are converted here, using the script:

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(".*")\|finishJSTest()\);[ 	]*/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  git rm $base-expected.txt
done

Additional manual changes were needed to replace methods defined by
js-test.  A few tests needed updated expectations due to how
audit-util.js needed to be changed for these tests.

BUG= 676355 
TEST=

Review-Url: https://codereview.chromium.org/2593043003
Cr-Commit-Position: refs/heads/master@{#442672}

[delete] https://crrev.com/d9293175895d81e0a2b6ca1907347889af268492/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-detune-modulated-impulse-expected.txt
[modify] https://crrev.com/7f51edaef941956727d65a8f3ac7036684963fbb/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-detune-modulated-impulse.html
[delete] https://crrev.com/d9293175895d81e0a2b6ca1907347889af268492/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-detune-modulation-expected.txt
[modify] https://crrev.com/7f51edaef941956727d65a8f3ac7036684963fbb/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-detune-modulation.html
[delete] https://crrev.com/d9293175895d81e0a2b6ca1907347889af268492/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-late-start-expected.txt
[modify] https://crrev.com/7f51edaef941956727d65a8f3ac7036684963fbb/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-late-start.html
[modify] https://crrev.com/7f51edaef941956727d65a8f3ac7036684963fbb/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-loop-comprehensive-expected.txt
[delete] https://crrev.com/d9293175895d81e0a2b6ca1907347889af268492/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-loop-grain-no-duration-expected.txt
[modify] https://crrev.com/7f51edaef941956727d65a8f3ac7036684963fbb/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-loop-grain-no-duration.html
[modify] https://crrev.com/7f51edaef941956727d65a8f3ac7036684963fbb/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate-expected.txt
[delete] https://crrev.com/d9293175895d81e0a2b6ca1907347889af268492/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate-modulated-impulse-expected.txt
[modify] https://crrev.com/7f51edaef941956727d65a8f3ac7036684963fbb/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate-modulated-impulse.html
[delete] https://crrev.com/d9293175895d81e0a2b6ca1907347889af268492/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate-modulation-expected.txt
[modify] https://crrev.com/7f51edaef941956727d65a8f3ac7036684963fbb/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate-modulation.html
[delete] https://crrev.com/d9293175895d81e0a2b6ca1907347889af268492/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate-zero-expected.txt
[modify] https://crrev.com/7f51edaef941956727d65a8f3ac7036684963fbb/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate-zero.html
[delete] https://crrev.com/d9293175895d81e0a2b6ca1907347889af268492/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-premature-loop-stop-expected.txt
[modify] https://crrev.com/7f51edaef941956727d65a8f3ac7036684963fbb/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-premature-loop-stop.html
[modify] https://crrev.com/7f51edaef941956727d65a8f3ac7036684963fbb/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-start-expected.txt
[delete] https://crrev.com/d9293175895d81e0a2b6ca1907347889af268492/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiosource-onended-expected.txt
[modify] https://crrev.com/7f51edaef941956727d65a8f3ac7036684963fbb/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiosource-onended.html
[delete] https://crrev.com/d9293175895d81e0a2b6ca1907347889af268492/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiosource-premature-gc-expected.txt
[modify] https://crrev.com/7f51edaef941956727d65a8f3ac7036684963fbb/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiosource-premature-gc.html
[delete] https://crrev.com/d9293175895d81e0a2b6ca1907347889af268492/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiosource-time-limits-expected.txt
[modify] https://crrev.com/7f51edaef941956727d65a8f3ac7036684963fbb/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiosource-time-limits.html
[modify] https://crrev.com/7f51edaef941956727d65a8f3ac7036684963fbb/third_party/WebKit/LayoutTests/webaudio/resources/audiobuffersource-testing.js
[modify] https://crrev.com/7f51edaef941956727d65a8f3ac7036684963fbb/third_party/WebKit/LayoutTests/webaudio/resources/audit-util.js

Sign in to add a comment