New issue
Advanced search Search tips

Issue 676348 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 672152



Sign in to add a comment

Provide detailed information on the test failure

Project Member Reported by hongchan@chromium.org, Dec 21 2016

Issue description

Currently Audit's assertion chooses either the actual value or the description about it. Modify the code so the failure test case can have both information in the error message.
 
Cc: hongchan@chromium.org
 Issue 673485  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15a4b6f89805292c7a2c140cc7ee4a42bc78d26d

commit 15a4b6f89805292c7a2c140cc7ee4a42bc78d26d
Author: hongchan <hongchan@chromium.org>
Date: Wed Dec 21 23:58:43 2016

Provide detailed information on the test failure

Currently Audit's assertion chooses either the actual value or the
description about it. Modify the code so the failure test case can have
both information in the error message.

Now the failed assertion will have 'Got ${actual value}' at the end of
error message.

BUG= 676348 
TEST=LayoutTests/webaudio/unit-tests/audit-failures.html

Review-Url: https://codereview.chromium.org/2591233004
Cr-Commit-Position: refs/heads/master@{#440268}

[modify] https://crrev.com/15a4b6f89805292c7a2c140cc7ee4a42bc78d26d/third_party/WebKit/LayoutTests/webaudio/resources/audit.js
[modify] https://crrev.com/15a4b6f89805292c7a2c140cc7ee4a42bc78d26d/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures-expected.txt
[modify] https://crrev.com/15a4b6f89805292c7a2c140cc7ee4a42bc78d26d/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html

Status: Verified (was: Started)
 Issue 675777  has been merged into this issue.

Sign in to add a comment