Ideally this should be a crw_web_controller_unit test. If that's not possible then autofill_controller_unittest, if not possible then Earl Grey integration test :) Motivation is to catch regressions like this: https://codereview.chromium.org/2581883002/diff/1/ios/web/web_state/ui/crw_web_controller.mm#newcode2926
CL: https://codereview.chromium.org/2593283002/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8fcf715e395fe6deada8461a5a8649da9eb53e7 commit f8fcf715e395fe6deada8461a5a8649da9eb53e7 Author: eugenebut <eugenebut@chromium.org> Date: Thu Dec 22 21:33:00 2016 [ios] Removed keyCode from FormActivityRegistered API. keyCode was not used anywhere and also deprecated: https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode BUG= 676340 Review-Url: https://codereview.chromium.org/2593283002 Cr-Commit-Position: refs/heads/master@{#440511} [modify] https://crrev.com/f8fcf715e395fe6deada8461a5a8649da9eb53e7/ios/chrome/browser/autofill/autofill_agent.mm [modify] https://crrev.com/f8fcf715e395fe6deada8461a5a8649da9eb53e7/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm [modify] https://crrev.com/f8fcf715e395fe6deada8461a5a8649da9eb53e7/ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm [modify] https://crrev.com/f8fcf715e395fe6deada8461a5a8649da9eb53e7/ios/chrome/browser/passwords/password_generation_agent_unittest.mm [modify] https://crrev.com/f8fcf715e395fe6deada8461a5a8649da9eb53e7/ios/web/public/web_state/web_state_observer.h [modify] https://crrev.com/f8fcf715e395fe6deada8461a5a8649da9eb53e7/ios/web/public/web_state/web_state_observer_bridge.h [modify] https://crrev.com/f8fcf715e395fe6deada8461a5a8649da9eb53e7/ios/web/web_state/js/resources/core.js [modify] https://crrev.com/f8fcf715e395fe6deada8461a5a8649da9eb53e7/ios/web/web_state/ui/crw_web_controller.mm [modify] https://crrev.com/f8fcf715e395fe6deada8461a5a8649da9eb53e7/ios/web/web_state/ui/crw_web_controller_unittest.mm [modify] https://crrev.com/f8fcf715e395fe6deada8461a5a8649da9eb53e7/ios/web/web_state/web_state_impl.h [modify] https://crrev.com/f8fcf715e395fe6deada8461a5a8649da9eb53e7/ios/web/web_state/web_state_impl.mm [modify] https://crrev.com/f8fcf715e395fe6deada8461a5a8649da9eb53e7/ios/web/web_state/web_state_observer.mm [modify] https://crrev.com/f8fcf715e395fe6deada8461a5a8649da9eb53e7/ios/web/web_state/web_state_observer_bridge.mm
Comment 1 by eugene...@chromium.org
, Dec 22 2016