Issue metadata
Sign in to add a comment
|
Failing tests after AMD driver upgrade blocking win_optional_gpu_tests_rel |
||||||||||||||||||||||
Issue descriptionOn these bots: https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20(AMD) https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Debug%20(AMD) There are several tests failing after the recent graphics driver upgrade. On the Release bot, the following webgl2_conformance_tests fail: WebglConformance_conformance2_textures_canvas_sub_rectangle_tex_3d_rgb16f_rgb_float WebglConformance_deqp_functional_gles3_texturespecification_basic_texsubimage3d_01 WebglConformance_conformance2_textures_canvas_sub_rectangle_tex_3d_rgb8ui_rgb_integer_unsigned_byte WebglConformance_conformance2_textures_canvas_sub_rectangle_tex_3d_rgb8_rgb_unsigned_byte WebglConformance_deqp_functional_gles3_texturespecification_basic_texsubimage3d_03 WebglConformance_deqp_functional_gles3_texturespecification_basic_teximage3d_3d_00 WebglConformance_conformance2_textures_canvas_sub_rectangle_tex_3d_rgb565_rgb_unsigned_byte WebglConformance_conformance2_textures_image_data_tex_3d_rgb32f_rgb_float WebglConformance_conformance2_textures_image_tex_3d_rgb565_rgb_unsigned_byte WebglConformance_conformance2_textures_video_tex_3d_rgb8_rgb_unsigned_byte WebglConformance_conformance2_textures_image_data_tex_3d_rgb16f_rgb_half_float WebglConformance_deqp_functional_gles3_texturespecification_basic_teximage3d_3d_02 WebglConformance_conformance2_textures_canvas_sub_rectangle_tex_3d_rgb16f_rgb_half_float WebglConformance_conformance2_textures_image_tex_3d_rgb565_rgb_unsigned_short_5_6_5 WebglConformance_conformance2_textures_misc_tex_unpack_params WebglConformance_conformance2_textures_image_tex_3d_rgb32f_rgb_float WebglConformance_conformance2_textures_canvas_sub_rectangle_tex_3d_rgb565_rgb_unsigned_short_5_6_5 WebglConformance_deqp_functional_gles3_texturefiltering_3d_formats_05 WebglConformance_deqp_functional_gles3_texturespecification_teximage3d_pbo_3d_01 WebglConformance_deqp_functional_gles3_texturespecification_basic_teximage3d_3d_03 WebglConformance_conformance2_textures_canvas_sub_rectangle_tex_3d_rgb32f_rgb_float WebglConformance_conformance2_textures_image_tex_3d_rgb16f_rgb_float WebglConformance_conformance2_textures_image_tex_3d_srgb8_rgb_unsigned_byte WebglConformance_deqp_functional_gles3_texturespecification_basic_texsubimage3d_00 Again, on the Release bot, the following angle_deqp_gles3_d3d11_tests fail: dEQP_GLES3.Default_functional_texture_filtering_3d_formats_rgb565_linear_mipmap_linear dEQP_GLES3.Default_functional_texture_filtering_3d_formats_rgb565_linear_mipmap_nearest dEQP_GLES3.Default_functional_texture_filtering_3d_formats_rgb565_nearest_mipmap_linear dEQP_GLES3.Default_functional_texture_filtering_3d_formats_rgb565_nearest_mipmap_nearest dEQP_GLES3.Default_functional_texture_specification_basic_texsubimage3d_rgb16f_3d dEQP_GLES3.Default_functional_texture_specification_basic_texsubimage3d_rgb16i_3d dEQP_GLES3.Default_functional_texture_specification_basic_texsubimage3d_rgb16ui_3d dEQP_GLES3.Default_functional_texture_specification_basic_texsubimage3d_rgb32f_3d dEQP_GLES3.Default_functional_texture_specification_basic_texsubimage3d_rgb32i_3d dEQP_GLES3.Default_functional_texture_specification_basic_texsubimage3d_rgb32ui_3d dEQP_GLES3.Default_functional_texture_specification_basic_texsubimage3d_rgb565_3d dEQP_GLES3.Default_functional_texture_specification_basic_texsubimage3d_rgb8_3d dEQP_GLES3.Default_functional_texture_specification_basic_texsubimage3d_rgb8_snorm_3d dEQP_GLES3.Default_functional_texture_specification_basic_texsubimage3d_rgb8i_3d dEQP_GLES3.Default_functional_texture_specification_basic_texsubimage3d_rgb8ui_3d dEQP_GLES3.Default_functional_texture_specification_basic_texsubimage3d_srgb8_3d On the Debug bot, the following angle_end2end_tests fail: TimerQueriesTest.TimeElapsed_ES2_OPENGL We need to add suppressions for these new failures. While they're very unfortunate, we shouldn't roll back the driver upgrade for them. Geoff, as ANGLE wrangler, could you help with this?
,
Dec 21 2016
Note: emailed AMD about upstreaming the angle_deqp_gles3_d3d11_tests into their internal waterfall, to prevent these sorts of regressions in the future.
,
Dec 21 2016
Issue 676269 has been merged into this issue.
,
Dec 21 2016
Note: this is blocking CLs which run win_optional_gpu_tests_rel, including V8 rolls. Must be addressed immediately.
,
Dec 21 2016
,
Dec 21 2016
Eric: in your opinion should we press forward with this driver upgrade or roll back until AMD claims they've fixed the regressions?
,
Dec 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/e2d0e41fa30879fbd0bf3f2688936dc0293fd79d commit e2d0e41fa30879fbd0bf3f2688936dc0293fd79d Author: Geoff Lang <geofflang@chromium.org> Date: Wed Dec 21 17:02:38 2016 Supress failures for the 16.12.1 Windows AMD D3D11 driver. BUG= 676333 Change-Id: I2c29b3dd4ee00bb68575371fe3b1320aad087575 Reviewed-on: https://chromium-review.googlesource.com/422479 Reviewed-by: Geoff Lang <geofflang@chromium.org> [modify] https://crrev.com/e2d0e41fa30879fbd0bf3f2688936dc0293fd79d/src/tests/deqp_support/deqp_gles3_test_expectations.txt [modify] https://crrev.com/e2d0e41fa30879fbd0bf3f2688936dc0293fd79d/src/tests/gl_tests/TimerQueriesTest.cpp
,
Dec 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7fd28e32fa301bf976be9dde55ce93516ccb9ae0 commit 7fd28e32fa301bf976be9dde55ce93516ccb9ae0 Author: geofflang <geofflang@chromium.org> Date: Wed Dec 21 17:40:08 2016 Supress WebGL failures for the 16.12.1 Windows AMD D3D11 driver. TBR=kbr@chromium.org NOTRY=true BUG= 676333 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2595923003 Cr-Commit-Position: refs/heads/master@{#440141} [modify] https://crrev.com/7fd28e32fa301bf976be9dde55ce93516ccb9ae0/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Dec 21 2016
Given that GPU raster coverage on the waterfall is partial at the moment, I have no problem staying on the older driver until this is addressed. Staying on the older driver will just keep GPU raster blacklisted for these machines, which isn't ideal, but also isn't a huge issue (just one of many configurations we test GPU raster on).
,
Dec 21 2016
Argh. In that case we should roll back to the earlier driver if possible. I've asked about doing that on the parent bug. Separately, we need to get AMD to start running the dEQP tests on top of ANGLE so they don't break them again.
,
Dec 21 2016
Also, FWIW, confirmed that the tests that are failing now are run with GPU raster disabled, so this does appear to be a new driver issue, not some fallout from re-enabling GPU raster now that we're on a whitelisted driver. (On Win7 AMD, the only tests that run with GPU raster are those that specifically force it, such as the "gpu-rasterization.***" tests)
,
Dec 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/2a19313f8464393480fdd0bfcdecd3e40a7b49e6 commit 2a19313f8464393480fdd0bfcdecd3e40a7b49e6 Author: Kenneth Russell <kbr@chromium.org> Date: Thu Dec 22 00:33:42 2016 Revert "Supress failures for the 16.12.1 Windows AMD D3D11 driver." This reverts commit e2d0e41fa30879fbd0bf3f2688936dc0293fd79d. Reason for revert: The driver on these machines has been rolled back to the previous version, so these tests are expected to pass again. Original change's description: > Supress failures for the 16.12.1 Windows AMD D3D11 driver. > > BUG= 676333 > > Change-Id: I2c29b3dd4ee00bb68575371fe3b1320aad087575 > Reviewed-on: https://chromium-review.googlesource.com/422479 > Reviewed-by: Geoff Lang <geofflang@chromium.org> > TBR=geofflang@chromium.org BUG= 676333 NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Ia2952ef55002201dc8c34a4f45c2483bffbf6f43 Reviewed-on: https://chromium-review.googlesource.com/423126 Reviewed-by: Kenneth Russell <kbr@chromium.org> [modify] https://crrev.com/2a19313f8464393480fdd0bfcdecd3e40a7b49e6/src/tests/deqp_support/deqp_gles3_test_expectations.txt [modify] https://crrev.com/2a19313f8464393480fdd0bfcdecd3e40a7b49e6/src/tests/gl_tests/TimerQueriesTest.cpp
,
Dec 22 2016
The WebGL and ANGLE suppressions have been reverted in https://codereview.chromium.org/2597843002/ and https://chromium-review.googlesource.com/c/423126 , respectively, now that the driver has been rolled back to the earlier version. Closing this as fixed.
,
Dec 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e76b4a92618fa3a4eaf889de6af6218daf5be0c commit 1e76b4a92618fa3a4eaf889de6af6218daf5be0c Author: kbr <kbr@chromium.org> Date: Thu Dec 22 00:33:50 2016 Revert of Supress WebGL failures for the 16.12.1 Windows AMD D3D11 driver. (patchset #1 id:1 of https://codereview.chromium.org/2595923003/ ) Reason for revert: The driver on these machines has been rolled back so these tests should pass again. Original issue's description: > Supress WebGL failures for the 16.12.1 Windows AMD D3D11 driver. > > TBR=kbr@chromium.org > NOTRY=true > > BUG= 676333 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > > Committed: https://crrev.com/7fd28e32fa301bf976be9dde55ce93516ccb9ae0 > Cr-Commit-Position: refs/heads/master@{#440141} TBR=geofflang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 676333 Review-Url: https://codereview.chromium.org/2597843002 Cr-Commit-Position: refs/heads/master@{#440281} [modify] https://crrev.com/1e76b4a92618fa3a4eaf889de6af6218daf5be0c/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Dec 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8438beb74dd3443e928c2e53082dbde81ca1900 commit f8438beb74dd3443e928c2e53082dbde81ca1900 Author: jmadill <jmadill@chromium.org> Date: Fri Dec 23 16:29:06 2016 Roll ANGLE b8a580a..d5fe352 https://chromium.googlesource.com/angle/angle.git/+log/b8a580a..d5fe352 BUG= 676333 , 676689 , 672719 , 668223 , 630498 TBR=geofflang@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2606473002 Cr-Commit-Position: refs/heads/master@{#440636} [modify] https://crrev.com/f8438beb74dd3443e928c2e53082dbde81ca1900/DEPS |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kbr@chromium.org
, Dec 21 2016