Issue 676317 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	jkrcal@chromium.org
Closed:	Mar 2017
Cc:	█ tschumann@chromium.org █ bauerb@chromium.org █ ramyan@chromium.org
Components:	UI>Browser>NewTabPage
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug
zine-triaged

[Remote suggestions] RemoteSuggestionsProvider: switch from unique_ptr to value passing

Project Member Reported by jkrcal@chromium.org, Dec 21 2016

Issue description

The RemoteSuggestionsProvider interface expected callbacks to be wrapped as unique_ptrs. This is not needed any more because the Callbacks themselves supports move semantics very well.

 - "nullptr" can be replaced by "Callback<type>()"
 - "if (callback)" conditions can stay the same (Callbacks also have bool() operator)

Comment 1 by fi...@chromium.org, Dec 22 2016

Labels: zine-triaged

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d52cc8bc74d7a397a9054951373635aa698e2edf

commit d52cc8bc74d7a397a9054951373635aa698e2edf
Author: jkrcal <jkrcal@chromium.org>
Date: Thu Mar 30 10:23:04 2017

[Remote suggestions] Remove the unique_ptr wrapper around callbacks

A small cleanup.

BUG= 676317 

Review-Url: https://codereview.chromium.org/2786023002
Cr-Commit-Position: refs/heads/master@{#460716}

[modify] https://crrev.com/d52cc8bc74d7a397a9054951373635aa698e2edf/chrome/browser/ui/webui/snippets_internals_message_handler.cc
[modify] https://crrev.com/d52cc8bc74d7a397a9054951373635aa698e2edf/components/ntp_snippets/remote/remote_suggestions_provider.h
[modify] https://crrev.com/d52cc8bc74d7a397a9054951373635aa698e2edf/components/ntp_snippets/remote/remote_suggestions_provider_impl.cc
[modify] https://crrev.com/d52cc8bc74d7a397a9054951373635aa698e2edf/components/ntp_snippets/remote/remote_suggestions_provider_impl.h
[modify] https://crrev.com/d52cc8bc74d7a397a9054951373635aa698e2edf/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc
[modify] https://crrev.com/d52cc8bc74d7a397a9054951373635aa698e2edf/components/ntp_snippets/remote/remote_suggestions_scheduler_impl.cc
[modify] https://crrev.com/d52cc8bc74d7a397a9054951373635aa698e2edf/components/ntp_snippets/remote/remote_suggestions_scheduler_impl_unittest.cc

Comment 3 by jkrcal@chromium.org, Mar 30 2017

Status: Fixed (was: Assigned)

►

Issue 676317 link

Issue metadata

[Remote suggestions] RemoteSuggestionsProvider: switch from unique_ptr to value passing

Issue description

Comment 1 by fi...@chromium.org, Dec 22 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Mar 30 2017

Comment 2 Deleted

Comment 3 by jkrcal@chromium.org, Mar 30 2017

Comment 3 Deleted

Sign in to add a comment