[Remote suggestions] Trigger the scheduler when starting-up Chrome / opening a new NTP |
||||
Issue descriptionOn these events the scheduler (obtained from ContentSuggestionService via the remote_suggestions_scheduler() getter) should be informed by calling its functions: - bool OnBrowserStartup() - bool OnNTPOpened() Details for the browser startup (from Bernhard): - implement it in chrome/browser/ChromeTabbedActivity.java to finishNativeInitialization. - this should go through the java bridge. - on the c++ side, add an UMA histogram to measure the impact in percentage of startups where we fetch (what the function OnBrowserStartup() returns is what we need to record in the boolean histogram). I know nothing about opening NTP - look into the code. Start with whatever feels easier to implement.
,
Dec 22 2016
,
Dec 22 2016
,
Jan 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b29ba3730a14e6ee4f7836802caf1853aabf3772 commit b29ba3730a14e6ee4f7836802caf1853aabf3772 Author: fhorschig <fhorschig@chromium.org> Date: Tue Jan 03 15:53:41 2017 Call the Scheduler when opening the NTP. When a NTP is created, the scheduler is informed and can consider this event in scheduling the fetching of new snippets. BUG= 676308 Review-Url: https://codereview.chromium.org/2592053004 Cr-Commit-Position: refs/heads/master@{#441129} [modify] https://crrev.com/b29ba3730a14e6ee4f7836802caf1853aabf3772/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java [modify] https://crrev.com/b29ba3730a14e6ee4f7836802caf1853aabf3772/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java [modify] https://crrev.com/b29ba3730a14e6ee4f7836802caf1853aabf3772/chrome/browser/android/ntp/ntp_snippets_bridge.cc [modify] https://crrev.com/b29ba3730a14e6ee4f7836802caf1853aabf3772/chrome/browser/android/ntp/ntp_snippets_bridge.h
,
Jan 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb5e4457d0cef43f5a3676ee30139fe9be28eaa2 commit cb5e4457d0cef43f5a3676ee30139fe9be28eaa2 Author: fhorschig <fhorschig@chromium.org> Date: Thu Jan 05 22:05:44 2017 Trigger the Snippets Scheduler when Resuming Activities Inform the scheduler on resuming activites, so fetching of new snippets consider this event. (There is a related CL that triggers a similar event for new tabs: https://codereview.chromium.org/2592053004/) BUG= 676308 Review-Url: https://codereview.chromium.org/2599743002 Cr-Commit-Position: refs/heads/master@{#441768} [modify] https://crrev.com/cb5e4457d0cef43f5a3676ee30139fe9be28eaa2/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [modify] https://crrev.com/cb5e4457d0cef43f5a3676ee30139fe9be28eaa2/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java [modify] https://crrev.com/cb5e4457d0cef43f5a3676ee30139fe9be28eaa2/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java [modify] https://crrev.com/cb5e4457d0cef43f5a3676ee30139fe9be28eaa2/chrome/browser/android/ntp/ntp_snippets_bridge.cc [modify] https://crrev.com/cb5e4457d0cef43f5a3676ee30139fe9be28eaa2/chrome/browser/android/ntp/ntp_snippets_bridge.h [modify] https://crrev.com/cb5e4457d0cef43f5a3676ee30139fe9be28eaa2/components/ntp_snippets/remote/remote_suggestions_scheduler.h [modify] https://crrev.com/cb5e4457d0cef43f5a3676ee30139fe9be28eaa2/components/ntp_snippets/remote/scheduling_remote_suggestions_provider.cc [modify] https://crrev.com/cb5e4457d0cef43f5a3676ee30139fe9be28eaa2/components/ntp_snippets/remote/scheduling_remote_suggestions_provider.h
,
Jan 9 2017
The events that we figured out were most useful are implemented: - one after initialization of a new NTP - one for a cold start of a browser - one for any warm resume |
||||
►
Sign in to add a comment |
||||
Comment 1 by jkrcal@chromium.org
, Dec 21 2016