authpolicy: Add UMA stats! |
||||||||||
Issue description- Typical number of GPOs to be downloaded (we have a limit of about 600 right now, we want to make sure we don't get close to that) - Error cases - Preg stats similar to what Chrome is sending - How long it takes until machine account is available after domain join (i.e. when kinit works)
,
Dec 26 2016
Lutz, seems like you're the best person to figure out ownership of this.
,
Dec 26 2016
,
Jan 2 2017
,
Jan 2 2017
,
Jan 9 2017
,
Jan 19 2017
,
Jan 31 2017
Also add UMA for run times of all commands.
,
Feb 9 2017
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9806a772bf07a9317a178dd6f076f366e3cec3a6 commit 9806a772bf07a9317a178dd6f076f366e3cec3a6 Author: Lutz Justen <ljusten@chromium.org> Date: Mon Feb 27 20:03:19 2017 authpolicy: Add chromeos-base/metrics dependency Required for sending UMA stats. CQ-DEPEND=CL:440084 BUG= chromium:676299 TEST=Compiled, tested, ran tests, made sure stats show up in chrome://histograms Change-Id: I7e59e6d40c3f967223e420663b476f1a7da8316f Reviewed-on: https://chromium-review.googlesource.com/443427 Commit-Ready: Lutz Justen <ljusten@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Thiemo Nagel <tnagel@chromium.org> [modify] https://crrev.com/9806a772bf07a9317a178dd6f076f366e3cec3a6/chromeos-base/authpolicy/authpolicy-9999.ebuild
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9806a772bf07a9317a178dd6f076f366e3cec3a6 commit 9806a772bf07a9317a178dd6f076f366e3cec3a6 Author: Lutz Justen <ljusten@chromium.org> Date: Mon Feb 27 20:03:19 2017 authpolicy: Add chromeos-base/metrics dependency Required for sending UMA stats. CQ-DEPEND=CL:440084 BUG= chromium:676299 TEST=Compiled, tested, ran tests, made sure stats show up in chrome://histograms Change-Id: I7e59e6d40c3f967223e420663b476f1a7da8316f Reviewed-on: https://chromium-review.googlesource.com/443427 Commit-Ready: Lutz Justen <ljusten@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Thiemo Nagel <tnagel@chromium.org> [modify] https://crrev.com/9806a772bf07a9317a178dd6f076f366e3cec3a6/chromeos-base/authpolicy/authpolicy-9999.ebuild
,
Feb 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/7c25acb368d68bb17e67579f05390313ebebfb68 commit 7c25acb368d68bb17e67579f05390313ebebfb68 Author: Lutz Justen <ljusten@chromium.org> Date: Mon Feb 27 20:03:19 2017 authpolicy: Add UMA stats Sends UMA stats for - execution time of Samba/Kerberos executables, - retry counts, - GPO download counts and - D-Bus ErrorType results. CQ-DEPEND=CL:443427 BUG= chromium:676299 TEST=Compiled, tested, ran tests, made sure stats show up in chrome://histograms Change-Id: I6045b32e1fa81e5099fb97f6a4a7d2bcf2c6cb2d Reviewed-on: https://chromium-review.googlesource.com/440084 Commit-Ready: Lutz Justen <ljusten@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [add] https://crrev.com/7c25acb368d68bb17e67579f05390313ebebfb68/authpolicy/authpolicy_metrics.h [modify] https://crrev.com/7c25acb368d68bb17e67579f05390313ebebfb68/authpolicy/authpolicy_unittest.cc [modify] https://crrev.com/7c25acb368d68bb17e67579f05390313ebebfb68/authpolicy/authpolicy.h [modify] https://crrev.com/7c25acb368d68bb17e67579f05390313ebebfb68/authpolicy/samba_interface.cc [modify] https://crrev.com/7c25acb368d68bb17e67579f05390313ebebfb68/authpolicy/samba_interface.h [add] https://crrev.com/7c25acb368d68bb17e67579f05390313ebebfb68/authpolicy/authpolicy_metrics.cc [modify] https://crrev.com/7c25acb368d68bb17e67579f05390313ebebfb68/authpolicy/authpolicy.gyp [modify] https://crrev.com/7c25acb368d68bb17e67579f05390313ebebfb68/authpolicy/authpolicy.cc [modify] https://crrev.com/7c25acb368d68bb17e67579f05390313ebebfb68/authpolicy/authpolicy_main.cc [modify] https://crrev.com/7c25acb368d68bb17e67579f05390313ebebfb68/authpolicy/etc/init/authpolicyd.conf
,
Mar 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/system_api/+/7bdfccf956cb664f0bfec3b2ab01c60b548f77fb commit 7bdfccf956cb664f0bfec3b2ab01c60b548f77fb Author: Lutz Justen <ljusten@chromium.org> Date: Thu Mar 02 17:33:57 2017 system-api: Add histogram warning to authpolicy ErrorType Enum is being used in histograms.xml in Chromium. BUG= chromium:676299 TEST=Just a comment change, what could possibly go wrong?!? Change-Id: I9214a39a58ac54f9a4b8d2a37b3f1092eb5a81d2 Reviewed-on: https://chromium-review.googlesource.com/448516 Commit-Ready: Lutz Justen <ljusten@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> [modify] https://crrev.com/7bdfccf956cb664f0bfec3b2ab01c60b548f77fb/dbus/authpolicy/dbus-constants.h
,
Mar 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4830d657333322f85bb11a5ff431aaab85d8cb3c commit 4830d657333322f85bb11a5ff431aaab85d8cb3c Author: ljusten <ljusten@chromium.org> Date: Fri Mar 03 09:17:33 2017 Add AuthPolicy histograms Adds histograms used by the AuthPolicy daemon in Chrome OS, see authpolicy_metrics.cc in https://chromium-review.googlesource.com/c/440084/. BUG= chromium:676299 TEST=Ran pretty_print.py and validate_format.py Review-Url: https://codereview.chromium.org/2721913002 Cr-Commit-Position: refs/heads/master@{#454551} [modify] https://crrev.com/4830d657333322f85bb11a5ff431aaab85d8cb3c/tools/metrics/histograms/histograms.xml
,
Mar 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/e9606c8a483132eb4eca6cd4a6c91280f861c0a9 commit e9606c8a483132eb4eca6cd4a6c91280f861c0a9 Author: Lutz Justen <ljusten@chromium.org> Date: Fri Mar 03 11:14:51 2017 authpolicy: Tweak metrics Sets metrics min samples to 1. 0 is the implicit underflow bucket, the min sample in histograms should always be at least 1. Also record kinit/smbclient failures instead of tries, so that we can distinguish max-1 failures/1 success from max failures, and tweaked max samples, so the overflow bucket catches the case of too many retries. BUG= chromium:676299 TEST=Compiles, stats show up in histograms Change-Id: I4f2521c79154ad08a465e07c30b864ab36413339 Reviewed-on: https://chromium-review.googlesource.com/448536 Commit-Ready: Lutz Justen <ljusten@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> [modify] https://crrev.com/e9606c8a483132eb4eca6cd4a6c91280f861c0a9/authpolicy/samba_interface.cc [modify] https://crrev.com/e9606c8a483132eb4eca6cd4a6c91280f861c0a9/authpolicy/authpolicy_metrics.cc [modify] https://crrev.com/e9606c8a483132eb4eca6cd4a6c91280f861c0a9/authpolicy/authpolicy_metrics.h
,
Mar 3 2017
,
Jul 6 2017
bulk Verify of older or not-user-facing Chromad bugs
,
Jul 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb63401fd11ea382833da3fe016b9b989937cc57 commit cb63401fd11ea382833da3fe016b9b989937cc57 Author: Lutz Justen <ljusten@chromium.org> Date: Wed Jul 19 17:31:26 2017 histograms: Add missing authpolicy histogram The ChromeOS code in platform2/authpolicy has been sending AuthPolicy.TimeToRunNetAdsGpo for a while now (see https://chromium-review.googlesource.com/c/440084/), but it was never added to histograms.xml. BUG= chromium:676299 TEST=PCQ Change-Id: I48ba1d1fed31a11dde3c8994d4e0adbef3c39ecc Reviewed-on: https://chromium-review.googlesource.com/574912 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#487902} [modify] https://crrev.com/cb63401fd11ea382833da3fe016b9b989937cc57/tools/metrics/histograms/histograms.xml |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by ljusten@chromium.org
, Dec 21 2016