New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 2 users
Status: Fixed
Owner:
OOO returning 2018
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 669490



Sign in to add a comment
[css-ui] caret-color "auto" shouldn't be interpolable
Project Member Reported by r...@igalia.com, Dec 21 2016 Back to list

This is extracted from this comment:
https://codereview.chromium.org/2537373005/#msg19

It seems than the fact that colors have the unvisited vs visited
values causes that we need to modify InterpolationType design.

On that CL we're making caret-color animatable,
however "auto" is still interpolable in some animations.
For example if you've:
  @keyframes caret-color-to-lime {
    to { caret-color: lime; }
  }
It sill interpolates the caret-color value, when it shouldn't.

But if you've:
  @keyframes caret-color-to-lime {
    from { caret-color: auto; }
    to   { caret-color: lime; }
  }
Then it doesn't interpolate, as expected.

Created new test "caret-color-021.html" (attached)
to reproduce the issue, and send it upstream:
https://github.com/w3c/csswg-test/pull/1163

 
caret-color-021.html
1.1 KB View Download
Components: -Blink>CSS
Labels: Update-Monthly
Project Member Comment 2 by bugdroid1@chromium.org, Feb 17 2017
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a661d2c478a78a6bba5938b42f624a81a17329e

commit 9a661d2c478a78a6bba5938b42f624a81a17329e
Author: alancutter <alancutter@chromium.org>
Date: Fri Feb 17 02:18:53 2017

Don't animate caret-color: auto

This patch enables ColorPropertyFunctions to effectively return nullptr
instead of a StyleColor when the property doesn't have a color value.
This allows us to not run animations for caret-color when one side is "auto".

TEST=external/csswg-test/css-ui-3/caret-color-021.html
BUG= 676295 , 681424 

Review-Url: https://codereview.chromium.org/2694383002
Cr-Commit-Position: refs/heads/master@{#451183}

[modify] https://crrev.com/9a661d2c478a78a6bba5938b42f624a81a17329e/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/9a661d2c478a78a6bba5938b42f624a81a17329e/third_party/WebKit/LayoutTests/animations/composition/caret-color-composition.html
[modify] https://crrev.com/9a661d2c478a78a6bba5938b42f624a81a17329e/third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp
[modify] https://crrev.com/9a661d2c478a78a6bba5938b42f624a81a17329e/third_party/WebKit/Source/core/animation/CSSColorInterpolationType.h
[modify] https://crrev.com/9a661d2c478a78a6bba5938b42f624a81a17329e/third_party/WebKit/Source/core/animation/ColorPropertyFunctions.cpp
[modify] https://crrev.com/9a661d2c478a78a6bba5938b42f624a81a17329e/third_party/WebKit/Source/core/animation/ColorPropertyFunctions.h

Status: Fixed
Sign in to add a comment