[css-ui] caret-color "auto" shouldn't be interpolable |
||
Issue descriptionThis is extracted from this comment: https://codereview.chromium.org/2537373005/#msg19 It seems than the fact that colors have the unvisited vs visited values causes that we need to modify InterpolationType design. On that CL we're making caret-color animatable, however "auto" is still interpolable in some animations. For example if you've: @keyframes caret-color-to-lime { to { caret-color: lime; } } It sill interpolates the caret-color value, when it shouldn't. But if you've: @keyframes caret-color-to-lime { from { caret-color: auto; } to { caret-color: lime; } } Then it doesn't interpolate, as expected. Created new test "caret-color-021.html" (attached) to reproduce the issue, and send it upstream: https://github.com/w3c/csswg-test/pull/1163
,
Feb 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a661d2c478a78a6bba5938b42f624a81a17329e commit 9a661d2c478a78a6bba5938b42f624a81a17329e Author: alancutter <alancutter@chromium.org> Date: Fri Feb 17 02:18:53 2017 Don't animate caret-color: auto This patch enables ColorPropertyFunctions to effectively return nullptr instead of a StyleColor when the property doesn't have a color value. This allows us to not run animations for caret-color when one side is "auto". TEST=external/csswg-test/css-ui-3/caret-color-021.html BUG= 676295 , 681424 Review-Url: https://codereview.chromium.org/2694383002 Cr-Commit-Position: refs/heads/master@{#451183} [modify] https://crrev.com/9a661d2c478a78a6bba5938b42f624a81a17329e/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/9a661d2c478a78a6bba5938b42f624a81a17329e/third_party/WebKit/LayoutTests/animations/composition/caret-color-composition.html [modify] https://crrev.com/9a661d2c478a78a6bba5938b42f624a81a17329e/third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp [modify] https://crrev.com/9a661d2c478a78a6bba5938b42f624a81a17329e/third_party/WebKit/Source/core/animation/CSSColorInterpolationType.h [modify] https://crrev.com/9a661d2c478a78a6bba5938b42f624a81a17329e/third_party/WebKit/Source/core/animation/ColorPropertyFunctions.cpp [modify] https://crrev.com/9a661d2c478a78a6bba5938b42f624a81a17329e/third_party/WebKit/Source/core/animation/ColorPropertyFunctions.h
,
Feb 17 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by alancutter@chromium.org
, Jan 3 2017Labels: Update-Monthly