Then remove it.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6cfb9447b778c874962bc8f3df5b4f53372cd36b commit 6cfb9447b778c874962bc8f3df5b4f53372cd36b Author: sdefresne <sdefresne@chromium.org> Date: Wed Dec 21 14:20:43 2016 Remove ChromeBrowserProvider::CreateInfoBarView() method. With the code upstream, the implementation can now be inlined and the indirection is no longer necessary. Removing it and moving definition of the interfaces to ios/chrome/browser/ui/infobars/. BUG= 676278 Review-Url: https://codereview.chromium.org/2596813002 Cr-Commit-Position: refs/heads/master@{#440090} [modify] https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b/ios/chrome/browser/BUILD.gn [modify] https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b/ios/chrome/browser/downstream_chromium_browser_provider.h [modify] https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b/ios/chrome/browser/downstream_chromium_browser_provider.mm [modify] https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b/ios/chrome/browser/infobars/BUILD.gn [modify] https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b/ios/chrome/browser/infobars/confirm_infobar_controller.mm [modify] https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b/ios/chrome/browser/infobars/infobar.h [modify] https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b/ios/chrome/browser/infobars/infobar_container_view.mm [modify] https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b/ios/chrome/browser/infobars/infobar_controller.mm [modify] https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b/ios/chrome/browser/native_app_launcher/BUILD.gn [modify] https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b/ios/chrome/browser/native_app_launcher/native_app_infobar_controller.mm [modify] https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b/ios/chrome/browser/passwords/BUILD.gn [modify] https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b/ios/chrome/browser/passwords/update_password_infobar_controller.mm [modify] https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b/ios/chrome/browser/translate/BUILD.gn [modify] https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b/ios/chrome/browser/translate/after_translate_infobar_controller.mm [modify] https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b/ios/chrome/browser/translate/before_translate_infobar_controller.mm [modify] https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b/ios/chrome/browser/translate/never_translate_infobar_controller.mm [modify] https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b/ios/chrome/browser/translate/translate_message_infobar_controller.mm [modify] https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b/ios/chrome/browser/ui/infobars/BUILD.gn [modify] https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b/ios/chrome/browser/ui/infobars/infobar_view.h [modify] https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b/ios/chrome/browser/ui/infobars/infobar_view.mm [rename] https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b/ios/chrome/browser/ui/infobars/infobar_view_delegate.h [rename] https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b/ios/chrome/browser/ui/infobars/infobar_view_protocol.h [modify] https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b/ios/public/provider/chrome/browser/chrome_browser_provider.h [modify] https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b/ios/public/provider/chrome/browser/chrome_browser_provider.mm [modify] https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b/ios/public/provider/chrome/browser/test_chrome_browser_provider.h [modify] https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b/ios/public/provider/chrome/browser/test_chrome_browser_provider.mm [modify] https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b/ios/public/provider/chrome/browser/ui/BUILD.gn [delete] https://crrev.com/725822fe81ac2b4d89ae438fb4d975184478c889/ios/public/provider/chrome/browser/ui/test_infobar_view.h [delete] https://crrev.com/725822fe81ac2b4d89ae438fb4d975184478c889/ios/public/provider/chrome/browser/ui/test_infobar_view.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c9f321b835f2839bfc066a20932fd9f92dd8b27 commit 1c9f321b835f2839bfc066a20932fd9f92dd8b27 Author: sdefresne <sdefresne@chromium.org> Date: Wed Dec 21 20:15:54 2016 Remove ChromeBrowserProvider::RegisterProfilePrefs(). The sole implementation can now be inlined as the called code has been upstreamed, remove the method. BUG= 676278 Review-Url: https://codereview.chromium.org/2591823003 Cr-Commit-Position: refs/heads/master@{#440197} [modify] https://crrev.com/1c9f321b835f2839bfc066a20932fd9f92dd8b27/ios/chrome/browser/BUILD.gn [modify] https://crrev.com/1c9f321b835f2839bfc066a20932fd9f92dd8b27/ios/chrome/browser/device_sharing/device_sharing_manager_unittest.mm [modify] https://crrev.com/1c9f321b835f2839bfc066a20932fd9f92dd8b27/ios/chrome/browser/downstream_chromium_browser_provider.h [modify] https://crrev.com/1c9f321b835f2839bfc066a20932fd9f92dd8b27/ios/chrome/browser/downstream_chromium_browser_provider.mm [modify] https://crrev.com/1c9f321b835f2839bfc066a20932fd9f92dd8b27/ios/chrome/browser/prefs/BUILD.gn [modify] https://crrev.com/1c9f321b835f2839bfc066a20932fd9f92dd8b27/ios/chrome/browser/prefs/browser_prefs.mm [modify] https://crrev.com/1c9f321b835f2839bfc066a20932fd9f92dd8b27/ios/chrome/browser/ui/bookmarks/BUILD.gn [modify] https://crrev.com/1c9f321b835f2839bfc066a20932fd9f92dd8b27/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller_unittest.mm [modify] https://crrev.com/1c9f321b835f2839bfc066a20932fd9f92dd8b27/ios/public/provider/chrome/browser/chrome_browser_provider.h [modify] https://crrev.com/1c9f321b835f2839bfc066a20932fd9f92dd8b27/ios/public/provider/chrome/browser/chrome_browser_provider.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9464d6f0321be5f3c8e2ebcd6a2ef9a1e6fe87c4 commit 9464d6f0321be5f3c8e2ebcd6a2ef9a1e6fe87c4 Author: sdefresne <sdefresne@chromium.org> Date: Tue Jan 03 13:48:27 2017 Remove ChromeBrowserProvider::GetLiveTabContextProvider() method. The LiveTabContextProvider class implementation can be inlined in the sole user, removed and the accessor can also removed from the provider too. Add public_deps on :sessions_private from :sessions and restrict the visibility of the target (they cannot yet be merged as one of them uses ARC while not the other). BUG= 676278 Review-Url: https://codereview.chromium.org/2593993002 Cr-Commit-Position: refs/heads/master@{#441113} [modify] https://crrev.com/9464d6f0321be5f3c8e2ebcd6a2ef9a1e6fe87c4/ios/chrome/browser/BUILD.gn [modify] https://crrev.com/9464d6f0321be5f3c8e2ebcd6a2ef9a1e6fe87c4/ios/chrome/browser/browser_state/BUILD.gn [modify] https://crrev.com/9464d6f0321be5f3c8e2ebcd6a2ef9a1e6fe87c4/ios/chrome/browser/browsing_data/BUILD.gn [modify] https://crrev.com/9464d6f0321be5f3c8e2ebcd6a2ef9a1e6fe87c4/ios/chrome/browser/crash_report/BUILD.gn [modify] https://crrev.com/9464d6f0321be5f3c8e2ebcd6a2ef9a1e6fe87c4/ios/chrome/browser/downstream_chromium_browser_provider.h [modify] https://crrev.com/9464d6f0321be5f3c8e2ebcd6a2ef9a1e6fe87c4/ios/chrome/browser/downstream_chromium_browser_provider.mm [modify] https://crrev.com/9464d6f0321be5f3c8e2ebcd6a2ef9a1e6fe87c4/ios/chrome/browser/sessions/BUILD.gn [modify] https://crrev.com/9464d6f0321be5f3c8e2ebcd6a2ef9a1e6fe87c4/ios/chrome/browser/sessions/ios_chrome_tab_restore_service_client.mm [delete] https://crrev.com/961577e159e5cd9a8af365d322213cf86124914d/ios/chrome/browser/sessions/tab_restore_service_delegate_provider_impl.h [delete] https://crrev.com/961577e159e5cd9a8af365d322213cf86124914d/ios/chrome/browser/sessions/tab_restore_service_delegate_provider_impl.mm [modify] https://crrev.com/9464d6f0321be5f3c8e2ebcd6a2ef9a1e6fe87c4/ios/chrome/browser/tabs/BUILD.gn [modify] https://crrev.com/9464d6f0321be5f3c8e2ebcd6a2ef9a1e6fe87c4/ios/chrome/browser/test/BUILD.gn [modify] https://crrev.com/9464d6f0321be5f3c8e2ebcd6a2ef9a1e6fe87c4/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/9464d6f0321be5f3c8e2ebcd6a2ef9a1e6fe87c4/ios/chrome/browser/ui/main/BUILD.gn [modify] https://crrev.com/9464d6f0321be5f3c8e2ebcd6a2ef9a1e6fe87c4/ios/chrome/browser/ui/ntp/recent_tabs/BUILD.gn [modify] https://crrev.com/9464d6f0321be5f3c8e2ebcd6a2ef9a1e6fe87c4/ios/chrome/browser/ui/tab_switcher/BUILD.gn [modify] https://crrev.com/9464d6f0321be5f3c8e2ebcd6a2ef9a1e6fe87c4/ios/public/provider/chrome/browser/chrome_browser_provider.h [modify] https://crrev.com/9464d6f0321be5f3c8e2ebcd6a2ef9a1e6fe87c4/ios/public/provider/chrome/browser/chrome_browser_provider.mm [modify] https://crrev.com/9464d6f0321be5f3c8e2ebcd6a2ef9a1e6fe87c4/ios/public/provider/chrome/browser/sessions/BUILD.gn [delete] https://crrev.com/961577e159e5cd9a8af365d322213cf86124914d/ios/public/provider/chrome/browser/sessions/live_tab_context_provider.h [delete] https://crrev.com/961577e159e5cd9a8af365d322213cf86124914d/ios/public/provider/chrome/browser/sessions/test_live_tab_context_provider.cc [delete] https://crrev.com/961577e159e5cd9a8af365d322213cf86124914d/ios/public/provider/chrome/browser/sessions/test_live_tab_context_provider.h [modify] https://crrev.com/9464d6f0321be5f3c8e2ebcd6a2ef9a1e6fe87c4/ios/public/provider/chrome/browser/test_chrome_browser_provider.h [modify] https://crrev.com/9464d6f0321be5f3c8e2ebcd6a2ef9a1e6fe87c4/ios/public/provider/chrome/browser/test_chrome_browser_provider.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/753c01b46ef292f80a118e7508f7a2551638610b commit 753c01b46ef292f80a118e7508f7a2551638610b Author: sdefresne <sdefresne@chromium.org> Date: Tue Jan 03 15:40:45 2017 Remove legacy InfoBarViewProtocol. The @protocol was only there to allow for upstreaming and can now be removed as client code can directly use @class InfoBarView. BUG= 676278 Review-Url: https://codereview.chromium.org/2592113002 Cr-Commit-Position: refs/heads/master@{#441128} [modify] https://crrev.com/753c01b46ef292f80a118e7508f7a2551638610b/ios/chrome/browser/infobars/confirm_infobar_controller+protected.h [modify] https://crrev.com/753c01b46ef292f80a118e7508f7a2551638610b/ios/chrome/browser/infobars/confirm_infobar_controller.mm [modify] https://crrev.com/753c01b46ef292f80a118e7508f7a2551638610b/ios/chrome/browser/infobars/infobar.mm [modify] https://crrev.com/753c01b46ef292f80a118e7508f7a2551638610b/ios/chrome/browser/infobars/infobar_container_view.mm [modify] https://crrev.com/753c01b46ef292f80a118e7508f7a2551638610b/ios/chrome/browser/infobars/infobar_controller.h [modify] https://crrev.com/753c01b46ef292f80a118e7508f7a2551638610b/ios/chrome/browser/infobars/infobar_controller.mm [modify] https://crrev.com/753c01b46ef292f80a118e7508f7a2551638610b/ios/chrome/browser/native_app_launcher/native_app_infobar_controller.mm [modify] https://crrev.com/753c01b46ef292f80a118e7508f7a2551638610b/ios/chrome/browser/passwords/update_password_infobar_controller.h [modify] https://crrev.com/753c01b46ef292f80a118e7508f7a2551638610b/ios/chrome/browser/passwords/update_password_infobar_controller.mm [modify] https://crrev.com/753c01b46ef292f80a118e7508f7a2551638610b/ios/chrome/browser/translate/after_translate_infobar_controller.mm [modify] https://crrev.com/753c01b46ef292f80a118e7508f7a2551638610b/ios/chrome/browser/translate/before_translate_infobar_controller.mm [modify] https://crrev.com/753c01b46ef292f80a118e7508f7a2551638610b/ios/chrome/browser/translate/never_translate_infobar_controller.mm [modify] https://crrev.com/753c01b46ef292f80a118e7508f7a2551638610b/ios/chrome/browser/translate/translate_message_infobar_controller.mm [modify] https://crrev.com/753c01b46ef292f80a118e7508f7a2551638610b/ios/chrome/browser/ui/infobars/BUILD.gn [modify] https://crrev.com/753c01b46ef292f80a118e7508f7a2551638610b/ios/chrome/browser/ui/infobars/infobar_view.h [modify] https://crrev.com/753c01b46ef292f80a118e7508f7a2551638610b/ios/chrome/browser/ui/infobars/infobar_view.mm [delete] https://crrev.com/6b76da0d5e4f1e1aa75329a53a772de6e96b227b/ios/chrome/browser/ui/infobars/infobar_view_protocol.h [modify] https://crrev.com/753c01b46ef292f80a118e7508f7a2551638610b/ios/public/provider/chrome/browser/chrome_browser_provider.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cce00c325e48f7a8cc0f4a2f808c590bd1b02afb commit cce00c325e48f7a8cc0f4a2f808c590bd1b02afb Author: sdefresne <sdefresne@chromium.org> Date: Tue Jan 03 17:19:57 2017 Remove ChromeBrowserProvider::SetUIViewAlphaWithAnimation(). There is only one client of that code, so inline the implementation in infobar_container_ios.mm and remove the indirection. BUG= 676278 Review-Url: https://codereview.chromium.org/2593103002 Cr-Commit-Position: refs/heads/master@{#441144} [modify] https://crrev.com/cce00c325e48f7a8cc0f4a2f808c590bd1b02afb/ios/chrome/browser/BUILD.gn [modify] https://crrev.com/cce00c325e48f7a8cc0f4a2f808c590bd1b02afb/ios/chrome/browser/downstream_chromium_browser_provider.h [modify] https://crrev.com/cce00c325e48f7a8cc0f4a2f808c590bd1b02afb/ios/chrome/browser/downstream_chromium_browser_provider.mm [modify] https://crrev.com/cce00c325e48f7a8cc0f4a2f808c590bd1b02afb/ios/chrome/browser/infobars/BUILD.gn [modify] https://crrev.com/cce00c325e48f7a8cc0f4a2f808c590bd1b02afb/ios/chrome/browser/infobars/infobar_container_ios.mm [modify] https://crrev.com/cce00c325e48f7a8cc0f4a2f808c590bd1b02afb/ios/public/provider/chrome/browser/chrome_browser_provider.h [modify] https://crrev.com/cce00c325e48f7a8cc0f4a2f808c590bd1b02afb/ios/public/provider/chrome/browser/chrome_browser_provider.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d78af33251a7c3bf28d9a45cb6b664da31c37b82 commit d78af33251a7c3bf28d9a45cb6b664da31c37b82 Author: sdefresne <sdefresne@chromium.org> Date: Tue Jan 03 18:11:54 2017 Remove ChromeBrowserProvider::CreateCardUnmaskPromptView(). The method can now be inlined at the call site as the implementation has been upstreamed. Removing the method and obsolete includes. BUG= 676278 Review-Url: https://codereview.chromium.org/2612583002 Cr-Commit-Position: refs/heads/master@{#441155} [modify] https://crrev.com/d78af33251a7c3bf28d9a45cb6b664da31c37b82/ios/chrome/browser/BUILD.gn [modify] https://crrev.com/d78af33251a7c3bf28d9a45cb6b664da31c37b82/ios/chrome/browser/downstream_chromium_browser_provider.h [modify] https://crrev.com/d78af33251a7c3bf28d9a45cb6b664da31c37b82/ios/chrome/browser/downstream_chromium_browser_provider.mm [modify] https://crrev.com/d78af33251a7c3bf28d9a45cb6b664da31c37b82/ios/chrome/browser/ui/autofill/BUILD.gn [modify] https://crrev.com/d78af33251a7c3bf28d9a45cb6b664da31c37b82/ios/chrome/browser/ui/autofill/autofill_client_ios.mm [modify] https://crrev.com/d78af33251a7c3bf28d9a45cb6b664da31c37b82/ios/public/provider/chrome/browser/chrome_browser_provider.h [modify] https://crrev.com/d78af33251a7c3bf28d9a45cb6b664da31c37b82/ios/public/provider/chrome/browser/chrome_browser_provider.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f378a75463a07e4120477599a9e9600f9d2f4f3 commit 4f378a75463a07e4120477599a9e9600f9d2f4f3 Author: sdefresne <sdefresne@chromium.org> Date: Wed Jan 04 14:51:15 2017 Remove ChromeBrowserProvider::IsOffTheRecordSessionActive(). The method can now be inlined at the call site as the implementation has been upstreamed. Removing the method and obsolete includes. Also remove the helper method ::IsOffTheRecordSessionActive and directly call the real implementation from BrowserListIOS. Convert naked "new" call initializing std::unique_ptr<> to instead use "base::MakeUnique" (ditto for "base::WrapUnique(new ...)"). BUG= 676278 Review-Url: https://codereview.chromium.org/2615433002 Cr-Commit-Position: refs/heads/master@{#441373} [modify] https://crrev.com/4f378a75463a07e4120477599a9e9600f9d2f4f3/ios/chrome/browser/BUILD.gn [modify] https://crrev.com/4f378a75463a07e4120477599a9e9600f9d2f4f3/ios/chrome/browser/downstream_chromium_browser_provider.h [modify] https://crrev.com/4f378a75463a07e4120477599a9e9600f9d2f4f3/ios/chrome/browser/downstream_chromium_browser_provider.mm [modify] https://crrev.com/4f378a75463a07e4120477599a9e9600f9d2f4f3/ios/chrome/browser/metrics/BUILD.gn [rename] https://crrev.com/4f378a75463a07e4120477599a9e9600f9d2f4f3/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm [modify] https://crrev.com/4f378a75463a07e4120477599a9e9600f9d2f4f3/ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.mm [modify] https://crrev.com/4f378a75463a07e4120477599a9e9600f9d2f4f3/ios/chrome/browser/ui/BUILD.gn [delete] https://crrev.com/2d67b3c0fcb6e5ed693d90d8403e324033b7f804/ios/chrome/browser/ui/browser_otr_state.h [delete] https://crrev.com/2d67b3c0fcb6e5ed693d90d8403e324033b7f804/ios/chrome/browser/ui/browser_otr_state.mm [modify] https://crrev.com/4f378a75463a07e4120477599a9e9600f9d2f4f3/ios/public/provider/chrome/browser/chrome_browser_provider.h [modify] https://crrev.com/4f378a75463a07e4120477599a9e9600f9d2f4f3/ios/public/provider/chrome/browser/chrome_browser_provider.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7f6a8a960a2078be95065df1c713f0c16887763 commit a7f6a8a960a2078be95065df1c713f0c16887763 Author: sdefresne <sdefresne@chromium.org> Date: Mon Jan 09 08:32:15 2017 Remove ChromeBrowserProvider::GetFaviconForURL(). The method can now be inlined at the call site as the implementation has been upstreamed. Removing the method and obsolete includes. Move the implementation of GetFaviconForNativeApplicationURL() from ChromeWebUIIOSControllerFactory to FaviconClientImpl to untangle a complex and deep circular dependencies causing linker failures when removing DownstreamChromiumBrowserProvider. BUG= 676278 Review-Url: https://codereview.chromium.org/2609363003 Cr-Commit-Position: refs/heads/master@{#442208} [modify] https://crrev.com/a7f6a8a960a2078be95065df1c713f0c16887763/ios/chrome/browser/downstream_chromium_browser_provider.h [modify] https://crrev.com/a7f6a8a960a2078be95065df1c713f0c16887763/ios/chrome/browser/downstream_chromium_browser_provider.mm [modify] https://crrev.com/a7f6a8a960a2078be95065df1c713f0c16887763/ios/chrome/browser/favicon/BUILD.gn [modify] https://crrev.com/a7f6a8a960a2078be95065df1c713f0c16887763/ios/chrome/browser/favicon/favicon_client_impl.h [modify] https://crrev.com/a7f6a8a960a2078be95065df1c713f0c16887763/ios/chrome/browser/favicon/favicon_client_impl.mm [modify] https://crrev.com/a7f6a8a960a2078be95065df1c713f0c16887763/ios/chrome/browser/favicon/favicon_service_factory.cc [modify] https://crrev.com/a7f6a8a960a2078be95065df1c713f0c16887763/ios/chrome/browser/ui/webui/BUILD.gn [modify] https://crrev.com/a7f6a8a960a2078be95065df1c713f0c16887763/ios/chrome/browser/ui/webui/chrome_web_ui_ios_controller_factory.h [modify] https://crrev.com/a7f6a8a960a2078be95065df1c713f0c16887763/ios/chrome/browser/ui/webui/chrome_web_ui_ios_controller_factory.mm [modify] https://crrev.com/a7f6a8a960a2078be95065df1c713f0c16887763/ios/chrome/browser/ui/webui/crashes_ui.cc [modify] https://crrev.com/a7f6a8a960a2078be95065df1c713f0c16887763/ios/chrome/browser/ui/webui/crashes_ui.h [modify] https://crrev.com/a7f6a8a960a2078be95065df1c713f0c16887763/ios/chrome/browser/ui/webui/flags_ui.cc [modify] https://crrev.com/a7f6a8a960a2078be95065df1c713f0c16887763/ios/chrome/browser/ui/webui/flags_ui.h [modify] https://crrev.com/a7f6a8a960a2078be95065df1c713f0c16887763/ios/chrome/browser/ui/webui/signin_internals_ui_ios.cc [modify] https://crrev.com/a7f6a8a960a2078be95065df1c713f0c16887763/ios/public/provider/chrome/browser/chrome_browser_provider.h [modify] https://crrev.com/a7f6a8a960a2078be95065df1c713f0c16887763/ios/public/provider/chrome/browser/chrome_browser_provider.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cab7ef9c241ae9e42cea3b6860bf724f5b5d8fca commit cab7ef9c241ae9e42cea3b6860bf724f5b5d8fca Author: sdefresne <sdefresne@chromium.org> Date: Mon Jan 09 09:56:59 2017 Remove ChromeBrowserProvider::CreateSyncedWindowDelegatesGetter(). The method can now be inlined at the call site as the implementation has been upstreamed. Removing the method and obsolete includes. BUG= 676278 Review-Url: https://codereview.chromium.org/2611963002 Cr-Commit-Position: refs/heads/master@{#442221} [modify] https://crrev.com/cab7ef9c241ae9e42cea3b6860bf724f5b5d8fca/ios/chrome/browser/downstream_chromium_browser_provider.h [modify] https://crrev.com/cab7ef9c241ae9e42cea3b6860bf724f5b5d8fca/ios/chrome/browser/downstream_chromium_browser_provider.mm [modify] https://crrev.com/cab7ef9c241ae9e42cea3b6860bf724f5b5d8fca/ios/chrome/browser/sync/BUILD.gn [modify] https://crrev.com/cab7ef9c241ae9e42cea3b6860bf724f5b5d8fca/ios/chrome/browser/sync/ios_chrome_sync_client.mm [modify] https://crrev.com/cab7ef9c241ae9e42cea3b6860bf724f5b5d8fca/ios/chrome/browser/tabs/BUILD.gn [modify] https://crrev.com/cab7ef9c241ae9e42cea3b6860bf724f5b5d8fca/ios/public/provider/chrome/browser/BUILD.gn [modify] https://crrev.com/cab7ef9c241ae9e42cea3b6860bf724f5b5d8fca/ios/public/provider/chrome/browser/chrome_browser_provider.h [modify] https://crrev.com/cab7ef9c241ae9e42cea3b6860bf724f5b5d8fca/ios/public/provider/chrome/browser/chrome_browser_provider.mm [delete] https://crrev.com/0d00f1d2f70b0c8eb42d6e81eb780acd8c21aa43/ios/public/provider/chrome/browser/sessions/BUILD.gn [delete] https://crrev.com/0d00f1d2f70b0c8eb42d6e81eb780acd8c21aa43/ios/public/provider/chrome/browser/sessions/test_synced_window_delegates_getter.cc [delete] https://crrev.com/0d00f1d2f70b0c8eb42d6e81eb780acd8c21aa43/ios/public/provider/chrome/browser/sessions/test_synced_window_delegates_getter.h [modify] https://crrev.com/cab7ef9c241ae9e42cea3b6860bf724f5b5d8fca/ios/public/provider/chrome/browser/test_chrome_browser_provider.h [modify] https://crrev.com/cab7ef9c241ae9e42cea3b6860bf724f5b5d8fca/ios/public/provider/chrome/browser/test_chrome_browser_provider.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/42f6c8d4feba8dbbfd32111d36e7c6b2d0e66b89 commit 42f6c8d4feba8dbbfd32111d36e7c6b2d0e66b89 Author: sdefresne <sdefresne@google.com> Date: Mon Jan 09 14:45:28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a87330e6389b26bdfe5623b677f79be4bccb7f92 commit a87330e6389b26bdfe5623b677f79be4bccb7f92 Author: sdefresne <sdefresne@chromium.org> Date: Mon Jan 09 14:59:07 2017 Remove obsolete class DownstreamChromiumBrowserProvider. This class is no longer used nor the factory function, so remove them both and cleanup BUILD.gn files. Remove obsolete public_deps that were there for the upstreaming process and are no longer required. BUG= 676278 Review-Url: https://codereview.chromium.org/2613063002 Cr-Commit-Position: refs/heads/master@{#442249} [modify] https://crrev.com/a87330e6389b26bdfe5623b677f79be4bccb7f92/ios/chrome/browser/BUILD.gn [delete] https://crrev.com/7af9db6743eb97d139fc3e7460a51830cc942d1f/ios/chrome/browser/downstream_chromium_browser_provider.h [delete] https://crrev.com/7af9db6743eb97d139fc3e7460a51830cc942d1f/ios/chrome/browser/downstream_chromium_browser_provider.mm [delete] https://crrev.com/7af9db6743eb97d139fc3e7460a51830cc942d1f/ios/chrome/browser/downstream_chromium_browser_provider_factory.mm [modify] https://crrev.com/a87330e6389b26bdfe5623b677f79be4bccb7f92/ios/public/provider/chrome/browser/BUILD.gn [modify] https://crrev.com/a87330e6389b26bdfe5623b677f79be4bccb7f92/ios/public/provider/chrome/browser/build_config.gni
Comment 1 by bugdroid1@chromium.org
, Dec 21 2016