New issue
Advanced search Search tips

Issue 676267 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Generated password on w3.org is not recognised by the page

Project Member Reported by vabr@chromium.org, Dec 21 2016

Issue description

Chrome Version: 55.0.2883.87, password generation enabled by a flag
OS: GNU/Linux

What steps will reproduce the problem?
(1) Visit https://www.w3.org/accounts/request
(2) Fill all fields on the sign-up form, and let Chrome generate the password.
(3) Attempt to click Continue

What is the expected result?
The form is submitted.

What happens instead?
The Continue button appears to be inactive.

Once the user types a character into the password field (extending the generated password), the Continue button becomes active.

This might be the page just doing something weird. In any case it is apparently possible for the page to distinguish a user-typed password form a generated one, which might not be right.
 

Comment 1 by kolos@chromium.org, Mar 9 2017

Labels: -Pri-3 Pri-1

Comment 2 by kolos@chromium.org, Mar 17 2017

Owner: kolos@chromium.org
Status: Started (was: Untriaged)

Comment 3 by kolos@chromium.org, Mar 17 2017

Issue 501614 has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a42d386112ff65fe17baa0c633e5ccc44989aa5

commit 4a42d386112ff65fe17baa0c633e5ccc44989aa5
Author: kolos <kolos@chromium.org>
Date: Tue Mar 21 17:37:54 2017

[Password Manager] Replace WebInputElement.setValue(element, true /* send events*/) with WebInputElement.setAutofillValue

Sometimes sites doesn't recognize that the password manager changed field values. setAutofillValue sends more events than setValue.

This CL (https://codereview.chromium.org/1955963002/) makes migration for autofill code.

BUG= 676267 , 501614

Review-Url: https://codereview.chromium.org/2750323003
Cr-Commit-Position: refs/heads/master@{#458459}

[modify] https://crrev.com/4a42d386112ff65fe17baa0c633e5ccc44989aa5/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
[modify] https://crrev.com/4a42d386112ff65fe17baa0c633e5ccc44989aa5/chrome/renderer/autofill/password_generation_agent_browsertest.cc
[modify] https://crrev.com/4a42d386112ff65fe17baa0c633e5ccc44989aa5/chrome/renderer/autofill/password_generation_test_utils.cc
[modify] https://crrev.com/4a42d386112ff65fe17baa0c633e5ccc44989aa5/chrome/renderer/autofill/password_generation_test_utils.h
[modify] https://crrev.com/4a42d386112ff65fe17baa0c633e5ccc44989aa5/components/autofill/content/renderer/form_cache.cc
[modify] https://crrev.com/4a42d386112ff65fe17baa0c633e5ccc44989aa5/components/autofill/content/renderer/password_autofill_agent.cc
[modify] https://crrev.com/4a42d386112ff65fe17baa0c633e5ccc44989aa5/components/autofill/content/renderer/password_generation_agent.cc

Comment 5 by kolos@chromium.org, Mar 21 2017

Status: Fixed (was: Started)

Sign in to add a comment