It is only broken if the amp url has a different domain (that does not serve the correct favicon).

Examples:

Broken for amp.slate.com
Still works for: bbc, guard, telegraph, daily mail


If at FF, this is not unblocked, we need to fix it in the java code (e.g. pass in the favicon domain).

Note also that when this fails, there's a fallback to the white document icon. It doesn't crash or do weird stuff. Additionally, for regular urls we also sometimes see the fallback icon.

Another broken example amp.smh.com.au.

Hm, this issue slipped through my radar :(

From my point of view this is not so severe to be merged. 
WDYT, Michael, Bernhard?

I'd consider this P2 or P3.

This feature is implemented for the new code-path that fetches favicons via ContentSuggestionsService. I want to experiment with this code path in M59 and eventually make it default (which would fix this bug).

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06fc44d446d9eca68c8c827439ad2145a2e0f1d3

commit 06fc44d446d9eca68c8c827439ad2145a2e0f1d3
Author: jkrcal <jkrcal@chromium.org>
Date: Wed Apr 19 14:18:49 2017

[Content suggestions] Reveal URL with favicon in snippets-internals

This CL adds debugging information for fetching favicons via Content
Suggestions Service. As in the presence of AMP URLs, the URL used for
fetching favicons is different from the main URL, we display it as
another piece of information in details for a suggestions.

BUG= 676259 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2824173005
Cr-Commit-Position: refs/heads/master@{#465590}

[modify] https://crrev.com/06fc44d446d9eca68c8c827439ad2145a2e0f1d3/chrome/browser/resources/snippets_internals.html
[modify] https://crrev.com/06fc44d446d9eca68c8c827439ad2145a2e0f1d3/chrome/browser/ui/webui/snippets_internals_message_handler.cc
[modify] https://crrev.com/06fc44d446d9eca68c8c827439ad2145a2e0f1d3/components/ntp_snippets/content_suggestion.h
[modify] https://crrev.com/06fc44d446d9eca68c8c827439ad2145a2e0f1d3/components/ntp_snippets/content_suggestions_service.cc

This (minor) problem goes away with Google Feed. Not worth fixing for the time being.