HTMLOptionsCollection.length setter should trigger custom elements reactions |
||
Issue descriptionThe HTMLOptionsCollection length setter can remove elements from the tree and should trigger custom elements reactions. This was causing Blink to fail the custom-elements/reactions/HTMLOptionsCollection.html test "length on HTMLOptionsCollection must enqueue disconnectedCallback when removing a custom element" Spec for HTMLOptionsCollection is here: https://html.spec.whatwg.org/#the-htmloptionscollection-interface
,
Dec 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a578d12a688c40523cc326151606f5ea4f50fb9 commit 4a578d12a688c40523cc326151606f5ea4f50fb9 Author: dominicc <dominicc@chromium.org> Date: Thu Dec 22 03:49:29 2016 Options length setter should process custom elements reactions Unlike HTMLCollections, the HTMLOptionsCollection length attribute is writable and it can remove elements from the DOM on truncation, which should trigger custom element reactions. Add the metadata to do that. This means Blink is now passing web-platform-tests' custom-elements/reactions/HTMLOptionsCollection.html tests. BUG= 676257 Review-Url: https://codereview.chromium.org/2598563002 Cr-Commit-Position: refs/heads/master@{#440331} [delete] https://crrev.com/47684d7e2323e73654f8f88090a399a4705dfc00/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/HTMLOptionsCollection-expected.txt [modify] https://crrev.com/4a578d12a688c40523cc326151606f5ea4f50fb9/third_party/WebKit/Source/core/html/HTMLOptionsCollection.idl
,
Dec 22 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by dominicc@chromium.org
, Dec 21 2016