New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 676255 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

The innerText setter should run custom element reactions

Project Member Reported by dominicc@chromium.org, Dec 21 2016

Issue description

ToT r439712

The innerText setter does not run custom element reactions causing Chrome to fail this web platform test:

custom-elements/reactions/HTMLElement.html

"innerText on HTMLElement must enqueue a disconnected reaction"
 
outerText isn't really standardized, see https://github.com/whatwg/html/issues/668, but since Blink implements something we may as well do it interoperably with WebKit. So should fix outerText too.

Patch up at https://codereview.chromium.org/2592973002
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47684d7e2323e73654f8f88090a399a4705dfc00

commit 47684d7e2323e73654f8f88090a399a4705dfc00
Author: dominicc <dominicc@chromium.org>
Date: Thu Dec 22 03:48:23 2016

innerText, outerText should dispatch custom element reactions.

innerText in the HTML spec is specified to do CEReactions. outerText
isn't in any spec, but since Blink implements something we may as well
do in interoperably with WebKit.

These missing CEReactions were causing us to fail a couple of tests in
web-platform-tests' custom-elements/reactions/HTMLElement.html .

BUG= 676255 

Review-Url: https://codereview.chromium.org/2592973002
Cr-Commit-Position: refs/heads/master@{#440330}

[modify] https://crrev.com/47684d7e2323e73654f8f88090a399a4705dfc00/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/HTMLElement-expected.txt
[modify] https://crrev.com/47684d7e2323e73654f8f88090a399a4705dfc00/third_party/WebKit/Source/core/html/HTMLElement.idl

Status: Fixed (was: Started)

Sign in to add a comment