New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 676252 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Opt-in menu is empty if only ime is added.

Project Member Reported by xiulingw@chromium.org, Dec 21 2016

Issue description

Version 57.0.2925.0 canary 
Platform 9100 link
Firmware Google_Link.2695.1.169

REPRO STEPS 
1.Add only one IME(e.g. Pinyin or US)
2.Checked <Show input options in the shelf> 
3.Open opt-in menu in shelf 


ACTUAL RESULTS 
The opt-in menu is empty.


 
Screenshot 2016-12-21 at 3.37.36 PM.png
126 KB View Download
Screenshot 2016-12-21 at 3.38.32 PM.png
127 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9786d46dddfaafccff9d11fc7e011dce9214fe13

commit 9786d46dddfaafccff9d11fc7e011dce9214fe13
Author: azurewei <azurewei@chromium.org>
Date: Thu Dec 22 23:34:27 2016

Show IME in opt-in menu when there's one IME.

BUG= 676252 
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2601453002
Cr-Commit-Position: refs/heads/master@{#440540}

[modify] https://crrev.com/9786d46dddfaafccff9d11fc7e011dce9214fe13/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified in M57 , 9145 link, 
Input tools version 6.6.9.3
Labels: Proj-MaterialDesign-CrOS
azurewei@, just wanted to double check that this is M-57 only (otherwise this should probably be merged back to M-56).
Labels: Needs-Feedback
Status: Assigned (was: Verified)
azurewei@, friendly ping on comment #5. I think this would be important to merge back to m-56 unless you're certain it's an m-57-only regression.
Labels: -M-57 -InputTools-57 M-56 Merge-Request-56 InputTools-56
tdanderson@, thanks for reminder. It's not M-57 only. I'll merge it back to M-56. 
Project Member

Comment 8 by sheriffbot@chromium.org, Jan 13 2017

Labels: -Merge-Request-56 Hotlist-Merge-Approved Merge-Approved-56
Your change meets the bar and is auto-approved for M56. Please go ahead and merge the CL manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 16 2017

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bed87e79886221593a7929543691607e5ad2efc

commit 1bed87e79886221593a7929543691607e5ad2efc
Author: azurewei <azurewei@chromium.org>
Date: Mon Jan 16 00:58:02 2017

Show IME in opt-in menu when there's one IME.

TBR=tdanderson@chromium.org,stevenjb@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG= 676252 
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2601453002
Cr-Commit-Position: refs/heads/master@{#440540}
(cherry picked from commit 9786d46dddfaafccff9d11fc7e011dce9214fe13)

Review-Url: https://codereview.chromium.org/2633943002
Cr-Commit-Position: refs/branch-heads/2924@{#768}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/1bed87e79886221593a7929543691607e5ad2efc/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc

Labels: -Needs-Feedback
Status: Fixed (was: Assigned)
This has been merged, marking as Fixed. Please verify in m-56 beta-channel.
Status: Verified (was: Fixed)
Verified fixed on version 56.0.2924.65, platfrom 9006.64.0 link.

Sign in to add a comment