attributeChanged should fire when setting at attribute even if the value did not change |
||
Issue descriptionToT r439712 Chrome is failing these web-platform-tests: custom-elements/reactions/DOMStringMap.html "setter on DOMStringMap must enqueue an attributeChanged reaction when mutating the value of an observed data attribute to the same value" custom-elements/reactions/DOMTokenList.html "the stringifier of DOMTokenList must enqueue an attributeChanged reaction when the setter is called with the original value of the attribute" This is probably because DOM spec runs through attribute setting without regard for the previous value, but Chrome short-circuits it.
,
Dec 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ba3273c3c421d97ee7ca9570782874cef380275 commit 1ba3273c3c421d97ee7ca9570782874cef380275 Author: dominicc <dominicc@chromium.org> Date: Thu Dec 22 03:59:12 2016 Queue custom element attribute reactions for no-op sets, removes The DOM spec says to set attributes, even if their values don't change, and it is the attribute *setting* which triggers custom elements attributeChangedCallbacks. In hindsight that callback could be better named. BUG= 676247 Review-Url: https://codereview.chromium.org/2593973002 Cr-Commit-Position: refs/heads/master@{#440334} [delete] https://crrev.com/d20cc0bc639b07b29e1e50ae5f321fceb8a9daa7/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/DOMStringMap-expected.txt [modify] https://crrev.com/1ba3273c3c421d97ee7ca9570782874cef380275/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/DOMTokenList-expected.txt [modify] https://crrev.com/1ba3273c3c421d97ee7ca9570782874cef380275/third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/MutationObserver-attributes-expected.txt [modify] https://crrev.com/1ba3273c3c421d97ee7ca9570782874cef380275/third_party/WebKit/Source/core/dom/DOMTokenList.cpp [modify] https://crrev.com/1ba3273c3c421d97ee7ca9570782874cef380275/third_party/WebKit/Source/core/dom/Element.cpp
,
Dec 22 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by dominicc@chromium.org
, Dec 21 2016