Creating HTML elements in innerHTML in an XML document should process custom elements |
|||
Issue descriptionToT r439712 Chrome fails the WPT custom-elements/parser/parser-uses-registry-of-owner-document.html "HTML parser must use the registry of window.document in a document created by document.implementation.createXHTMLDocument()" (the test has an odd name, but it is actually doing createDocument with an XHTML NSURI.) The HTML spec has this nugget [1]: "This Document must then be populated with DOM nodes that represent the tree structure of the input passed to the parser, as defined by the XML specification, the Namespaces in XML specification, and the WHATWG DOM standard. When creating DOM nodes representing elements, the create an element for a token algorithm or some equivalent that operates on appropriate XML datastructures must be used, to ensure the proper element interfaces are created and that custom elements are set up correctly." Note the "custom elements are set up correctly" part. [1] https://html.spec.whatwg.org/#xml-parser
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/304c524c5df38c9f4fe8e523000e8963a56c58bd commit 304c524c5df38c9f4fe8e523000e8963a56c58bd Author: Kent Tamura <tkent@chromium.org> Date: Tue Aug 01 06:56:08 2017 Fix an innerHTML bug in a case where namespaces aren't declared by xmlns attributes. According to "XML fragment parsing algorithm" [1] and "locate a namespace" [2], we should take into account of prefix-namespace mapping implied by ancestor elements names. [1] https://html.spec.whatwg.org/multipage/xhtml.html#xml-fragment-parsing-algorithm [2] https://dom.spec.whatwg.org/#locate-a-namespace Bug: 312320 , 676246 Change-Id: I0bbd2907f7ef2a3f64d01a96befc6bd50eea43e6 Reviewed-on: https://chromium-review.googlesource.com/593491 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: Dominic Cooney <dominicc@chromium.org> Cr-Commit-Position: refs/heads/master@{#490890} [delete] https://crrev.com/251119cd400fdeaca0a1ec7769a63942e1adac52/third_party/WebKit/LayoutTests/external/wpt/custom-elements/parser/parser-uses-registry-of-owner-document-expected.txt [delete] https://crrev.com/251119cd400fdeaca0a1ec7769a63942e1adac52/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-template-element/additions-to-parsing-xhtml-documents/node-document-expected.txt [delete] https://crrev.com/251119cd400fdeaca0a1ec7769a63942e1adac52/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-template-element/additions-to-parsing-xhtml-documents/template-child-nodes-expected.txt [modify] https://crrev.com/304c524c5df38c9f4fe8e523000e8963a56c58bd/third_party/WebKit/LayoutTests/fast/innerHTML/innerHTML-xml-expected.txt [modify] https://crrev.com/304c524c5df38c9f4fe8e523000e8963a56c58bd/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
,
Jan 15 2018
Bulk edit bugs owned by dominicc@
,
Jan 24 2018
Looks this was already fixed. |
|||
►
Sign in to add a comment |
|||
Comment 1 Deleted