New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 676240 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Search geolocation disclosure is shown in incognito

Project Member Reported by benwells@chromium.org, Dec 21 2016

Issue description

The disclosure should not be shown as geolocation information is not shared.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62c93a50d8856db7621bc98d4c59794c58474ee2

commit 62c93a50d8856db7621bc98d4c59794c58474ee2
Author: benwells <benwells@chromium.org>
Date: Wed Dec 21 22:34:51 2016

Don't show geolocation disclosure when in incognito mode.

The geolocation will not be shared, so the disclosure should not be
shown.

BUG= 676240 

Review-Url: https://codereview.chromium.org/2593943002
Cr-Commit-Position: refs/heads/master@{#440244}

[modify] https://crrev.com/62c93a50d8856db7621bc98d4c59794c58474ee2/chrome/browser/android/search_geolocation_disclosure_tab_helper.cc

Labels: Merge-Request-56
This has been on stable for some time now and there have been no problems.

Comment 3 by dimu@chromium.org, Dec 28 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 28 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b8e02b901e22228729049f87d05320f27cb65fc

commit 4b8e02b901e22228729049f87d05320f27cb65fc
Author: Ben Wells <benwells@chromium.org>
Date: Wed Dec 28 03:35:13 2016

Don't show geolocation disclosure when in incognito mode.

The geolocation will not be shared, so the disclosure should not be
shown.

BUG= 676240 

Review-Url: https://codereview.chromium.org/2593943002
Cr-Commit-Position: refs/heads/master@{#440244}
(cherry picked from commit 62c93a50d8856db7621bc98d4c59794c58474ee2)

Review-Url: https://codereview.chromium.org/2603903002 .
Cr-Commit-Position: refs/branch-heads/2924@{#627}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/4b8e02b901e22228729049f87d05320f27cb65fc/chrome/browser/android/search_geolocation_disclosure_tab_helper.cc

Status: Fixed (was: Started)

Sign in to add a comment