Search geolocation disclosure is shown in incognito |
|||||
Issue descriptionThe disclosure should not be shown as geolocation information is not shared.
,
Dec 28 2016
This has been on stable for some time now and there have been no problems.
,
Dec 28 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b8e02b901e22228729049f87d05320f27cb65fc commit 4b8e02b901e22228729049f87d05320f27cb65fc Author: Ben Wells <benwells@chromium.org> Date: Wed Dec 28 03:35:13 2016 Don't show geolocation disclosure when in incognito mode. The geolocation will not be shared, so the disclosure should not be shown. BUG= 676240 Review-Url: https://codereview.chromium.org/2593943002 Cr-Commit-Position: refs/heads/master@{#440244} (cherry picked from commit 62c93a50d8856db7621bc98d4c59794c58474ee2) Review-Url: https://codereview.chromium.org/2603903002 . Cr-Commit-Position: refs/branch-heads/2924@{#627} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/4b8e02b901e22228729049f87d05320f27cb65fc/chrome/browser/android/search_geolocation_disclosure_tab_helper.cc
,
Dec 29 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Dec 21 2016