New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 676233 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Rebaseline-o-matic is failing because of PRECISE

Project Member Reported by wangxianzhu@chromium.org, Dec 21 2016

Issue description

Rebaseline-o-matic isn't working.

https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/547923/steps/webkit-patch%20auto-rebaseline/logs/stdio

webkitpy.tool.commands.auto_rebaseline: [INFO] LayoutTests/TestExpectations:897 Unrecognized specifier "PRECISE" fast/text/basic/015.html
webkitpy.tool.commands.auto_rebaseline: [INFO] Lint failed.


 
Tried https://codereview.chromium.org/2594933002 locally and 'webkit-patch auto-rebaseline' succeeded. However, I'm not sure if it's fully correct.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8440812961941989550ccfd0f200a78e6753e96

commit a8440812961941989550ccfd0f200a78e6753e96
Author: shimazu <shimazu@chromium.org>
Date: Wed Dec 21 08:31:10 2016

Mark popup-menu-with-scrollbar-appearance.html as Skip/Failure

Updating expectation failed when the previous rebaseline happened.

BUG= 676233 
TBR=oshima@chromium.org

Review-Url: https://codereview.chromium.org/2592963002
Cr-Commit-Position: refs/heads/master@{#440053}

[modify] https://crrev.com/a8440812961941989550ccfd0f200a78e6753e96/third_party/WebKit/LayoutTests/TestExpectations

This means that  bug 660580  wasn't completely finished; https://codereview.chromium.org/2514253002 was supposed to remove precise from everywhere, but missed at least one place.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/577ff0235b402852870c79bd2aba7615e4235f50

commit 577ff0235b402852870c79bd2aba7615e4235f50
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Wed Dec 21 19:44:04 2016

Remove 'precise' from supported layout test configurations

BUG= 676233 

Review-Url: https://codereview.chromium.org/2594933002
Cr-Commit-Position: refs/heads/master@{#440182}

[modify] https://crrev.com/577ff0235b402852870c79bd2aba7615e4235f50/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

Cc: qyears...@chromium.org
Owner: shimazu@chromium.org
Status: Fixed (was: Assigned)
Owner: wangxianzhu@chromium.org

Sign in to add a comment