New issue
Advanced search Search tips

Issue 676229 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

plugins/mouse-click-plugin-clears-selection.html is flaky on linux_chromium_rel_ng etc.

Project Member Reported by wangxianzhu@chromium.org, Dec 21 2016

Issue description

The test is failing most time and pass occasionally on linux_chromium_rel_ng:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=plugins%2Fmouse-click-plugin-clears-selection.html

When it fails, the plugin is painted as a green and blue checkerboard. See the attached actual result.

It also occasionally fails (succeeds when retried) on some other bots. See the gray boxes shown in the above link.

 
mouse-click-plugin-clears-selection-actual.png
3.4 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40deb0cec6cbc7d24743edddebc6d97a95797526

commit 40deb0cec6cbc7d24743edddebc6d97a95797526
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Wed Dec 21 05:05:22 2016

Mark plugins/mouse-click-plugin-clears-selection.html as flaky on Linux

TBR=dcheng@chromium.org
TBR_REASON=Update test expectations
NOTRY=true
BUG=676229

Review-Url: https://codereview.chromium.org/2594923002
Cr-Commit-Position: refs/heads/master@{#440022}

[modify] https://crrev.com/40deb0cec6cbc7d24743edddebc6d97a95797526/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by hu...@opera.com, Apr 14 2017

Labels: -OS-Mac
I don't know where the green and blue checkerboard comes from, but when I run this test in content_shell manually (Ubuntu 16.04) I get a hint that the plugin can't load. 100% reproducible. Is that the root cause of this bug? 

$ out/PcDebug/content_shell third_party/WebKit/LayoutTests/plugins/mouse-click-plugin-clears-selection.html
cantloadplugin.png
34.7 KB View Download

Comment 3 by vabr@chromium.org, Jun 22 2017

The test now flakes also on Win (https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7), sample build is https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/53375, log attached.
webkit_tests.txt
7.9 MB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6347deea52e69ca489506a1f1c65f046663c5599

commit 6347deea52e69ca489506a1f1c65f046663c5599
Author: Vaclav Brozek <vabr@chromium.org>
Date: Thu Jun 22 09:59:08 2017

Mark plugins/mouse-click-plugin-clears-selection.html as flaky on Win7

TBR=dcheng@chromium.org
TBR_REASON=Update test expectations
NOTRY=true
BUG=676229

Change-Id: If3d193d7e95fff0edeb799997c69cbf9fa0b02a3
Reviewed-on: https://chromium-review.googlesource.com/544859
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481494}
[modify] https://crrev.com/6347deea52e69ca489506a1f1c65f046663c5599/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/765ed10683220896163a799d285ce99567d5bd80

commit 765ed10683220896163a799d285ce99567d5bd80
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Fri Jul 14 11:35:22 2017

Mark plugins/mouse-click-plugin-clears-selection.html as flaky on Mac10.10

TBR=dcheng@chromium.org
TBR_REASON=Update test expectations
NOTRY=true

Bug: 676229, 742742 
Change-Id: I1aaf376ad020c6a4d8c2aec85714ef627132c7a2
Reviewed-on: https://chromium-review.googlesource.com/571704
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486736}
[modify] https://crrev.com/765ed10683220896163a799d285ce99567d5bd80/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8187e1c3b6fee2215c75de867a2d90cb8b68484f

commit 8187e1c3b6fee2215c75de867a2d90cb8b68484f
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Fri Jul 14 13:30:59 2017

Mark plugins/mouse-click-plugin-clears-selection.html as flaky on all Mac platforms

Following Mac10.10, Mac10.11 broke, too.
Mark flaky for all Mac platforms so sheriffs don't have to look for this when it
hits Mac10.9.

TBR=dcheng@chromium.org
TBR_REASON=Update test expectations
NOTRY=true

Bug: 676229, 742742 
Change-Id: Iecda3eb55b891dc35ed47552b43786e80f9f4aa3
Reviewed-on: https://chromium-review.googlesource.com/571788
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486748}
[modify] https://crrev.com/8187e1c3b6fee2215c75de867a2d90cb8b68484f/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5739a9f0ad63ae5e30a7d83de3694720c7581690

commit 5739a9f0ad63ae5e30a7d83de3694720c7581690
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Fri Sep 22 16:01:00 2017

sheriff: disable plugins/mouse-click-plugin-clears-selection.html on Win

This test is flaky on all platforms.

Bug: 676229
Change-Id: I73ff8e36ac596db4a071033993af435f9126b346
TBR: dcheng@chromium.org
No-Tree-Checks: True
Reviewed-on: https://chromium-review.googlesource.com/677957
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503752}
[modify] https://crrev.com/5739a9f0ad63ae5e30a7d83de3694720c7581690/third_party/WebKit/LayoutTests/TestExpectations

Cc: dcheng@chromium.org
 Issue 742742  has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/825926d301743f87f66b3dc5884d084a9b52e3d1

commit 825926d301743f87f66b3dc5884d084a9b52e3d1
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Wed Dec 19 22:01:39 2018

Update test expectations of several plugin tests

- plugins/mouse-click-plugin-clears-selection.html
  combine the platform entries.
- plugins/iframe-plugin-bgcolor.html
  combine the platform entries and use the correct bug number.
- plugins/fullscreen-plugins-dont-reload.html
  unskip to ensure test coverage, and add entry in LeakTests

TBR=kpaulhamus@chromium.org,dcheng@chromium.org

Bug:  838354 ,676229,742670
Change-Id: I9d3fc173d02c2f2835a633e2984b7588f40b2ec7
Reviewed-on: https://chromium-review.googlesource.com/c/1385014
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617971}
[modify] https://crrev.com/825926d301743f87f66b3dc5884d084a9b52e3d1/third_party/blink/web_tests/LeakExpectations
[modify] https://crrev.com/825926d301743f87f66b3dc5884d084a9b52e3d1/third_party/blink/web_tests/TestExpectations

Sign in to add a comment