see attached spec. Notification views (toasts or in-message-center views) are currently rectangles (not roundrects). That's one thing to fix. We need to add an 8 elevation shadow to the toasts.
https://codereview.chromium.org/2589163003/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba7b9d74bdd0fa555c7997c459ddd0d6c05cc78a commit ba7b9d74bdd0fa555c7997c459ddd0d6c05cc78a Author: estade <estade@chromium.org> Date: Wed Jan 04 20:06:06 2017 Replace WM shadow types (on/off) and styles (small/inactive/active) with elevation values instead. This is necessary to allow different windows of the same UI or WM window type to specify different shadow appearances. This also makes more sense in that active windows aren't the only ones to get big shadows. Concretely, this is a requirement for updating Toast shadows. BUG=608852, 676223 TBR=reveman@chromium.org Review-Url: https://codereview.chromium.org/2596743002 Cr-Commit-Position: refs/heads/master@{#441441} [modify] https://crrev.com/ba7b9d74bdd0fa555c7997c459ddd0d6c05cc78a/ash/common/wm/overview/window_grid.cc [modify] https://crrev.com/ba7b9d74bdd0fa555c7997c459ddd0d6c05cc78a/ash/common/wm/overview/window_selector_item.cc [modify] https://crrev.com/ba7b9d74bdd0fa555c7997c459ddd0d6c05cc78a/ash/shell/window_type_launcher.cc [modify] https://crrev.com/ba7b9d74bdd0fa555c7997c459ddd0d6c05cc78a/ash/wm/drag_window_controller.cc [modify] https://crrev.com/ba7b9d74bdd0fa555c7997c459ddd0d6c05cc78a/chrome/browser/chromeos/accessibility/chromevox_panel.cc [modify] https://crrev.com/ba7b9d74bdd0fa555c7997c459ddd0d6c05cc78a/components/exo/shell_surface.cc [modify] https://crrev.com/ba7b9d74bdd0fa555c7997c459ddd0d6c05cc78a/components/exo/shell_surface_unittest.cc [modify] https://crrev.com/ba7b9d74bdd0fa555c7997c459ddd0d6c05cc78a/ui/keyboard/content/keyboard_ui_content.cc [modify] https://crrev.com/ba7b9d74bdd0fa555c7997c459ddd0d6c05cc78a/ui/views/bubble/tray_bubble_view.cc [modify] https://crrev.com/ba7b9d74bdd0fa555c7997c459ddd0d6c05cc78a/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc [modify] https://crrev.com/ba7b9d74bdd0fa555c7997c459ddd0d6c05cc78a/ui/views/widget/native_widget_aura.cc [modify] https://crrev.com/ba7b9d74bdd0fa555c7997c459ddd0d6c05cc78a/ui/views/widget/widget.h [modify] https://crrev.com/ba7b9d74bdd0fa555c7997c459ddd0d6c05cc78a/ui/wm/core/shadow.cc [modify] https://crrev.com/ba7b9d74bdd0fa555c7997c459ddd0d6c05cc78a/ui/wm/core/shadow.h [modify] https://crrev.com/ba7b9d74bdd0fa555c7997c459ddd0d6c05cc78a/ui/wm/core/shadow_controller.cc [modify] https://crrev.com/ba7b9d74bdd0fa555c7997c459ddd0d6c05cc78a/ui/wm/core/shadow_controller_unittest.cc [modify] https://crrev.com/ba7b9d74bdd0fa555c7997c459ddd0d6c05cc78a/ui/wm/core/shadow_types.cc [modify] https://crrev.com/ba7b9d74bdd0fa555c7997c459ddd0d6c05cc78a/ui/wm/core/shadow_types.h [modify] https://crrev.com/ba7b9d74bdd0fa555c7997c459ddd0d6c05cc78a/ui/wm/core/shadow_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36f01b0163a66ba5174589f0e766ff80f28ae748 commit 36f01b0163a66ba5174589f0e766ff80f28ae748 Author: estade <estade@chromium.org> Date: Thu Jan 05 01:49:08 2017 Add shadow/corner radius to message center notifications. Both toasts (standalone bubbles) and notifications inside the message center get new shadows. BUG= 676223 , 624175 Review-Url: https://codereview.chromium.org/2589163003 Cr-Commit-Position: refs/heads/master@{#441553} [modify] https://crrev.com/36f01b0163a66ba5174589f0e766ff80f28ae748/ash/common/system/web_notification/ash_popup_alignment_delegate.cc [modify] https://crrev.com/36f01b0163a66ba5174589f0e766ff80f28ae748/ui/gfx/BUILD.gn [modify] https://crrev.com/36f01b0163a66ba5174589f0e766ff80f28ae748/ui/gfx/image/image_skia_operations.cc [modify] https://crrev.com/36f01b0163a66ba5174589f0e766ff80f28ae748/ui/gfx/image/image_skia_operations.h [add] https://crrev.com/36f01b0163a66ba5174589f0e766ff80f28ae748/ui/gfx/shadow_util.cc [add] https://crrev.com/36f01b0163a66ba5174589f0e766ff80f28ae748/ui/gfx/shadow_util.h [modify] https://crrev.com/36f01b0163a66ba5174589f0e766ff80f28ae748/ui/message_center/views/message_view.cc [modify] https://crrev.com/36f01b0163a66ba5174589f0e766ff80f28ae748/ui/message_center/views/message_view_factory.cc [modify] https://crrev.com/36f01b0163a66ba5174589f0e766ff80f28ae748/ui/message_center/views/toast_contents_view.h [modify] https://crrev.com/36f01b0163a66ba5174589f0e766ff80f28ae748/ui/views/border.cc [modify] https://crrev.com/36f01b0163a66ba5174589f0e766ff80f28ae748/ui/wm/core/shadow.cc
done -- Sebastien, please give it a look at your earliest convenience.
Comment 1 by est...@chromium.org
, Dec 29 2016