New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 676211 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: 57-Stable
Launch-Privacy: ----
Launch-Security: ----
Launch-Test: ----
Launch-UI: ----
Rollout-Type: ----



Sign in to add a comment

Media Recorder : add support for |timecode|

Project Member Reported by mcasas@chromium.org, Dec 21 2016

Issue description

Comment 1 by mcasas@chromium.org, Dec 21 2016

Components: Blink>MediaStream>Recording
Owner: mcasas@chromium.org
Status: Started (was: Available)
https://codereview.chromium.org/2610163006/
Labels: -Type-Feature Type-Launch-OWP
Labels: Launch-M-Target-57-Stable
https://www.chromestatus.com/admin/features/launch/5643877683822592
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab5ae32c6233fe7938b9a0b53cf1c74918310d7a

commit ab5ae32c6233fe7938b9a0b53cf1c74918310d7a
Author: mcasas <mcasas@chromium.org>
Date: Tue Jan 10 17:26:40 2017

MediaRecorder: support |timecode| and remove |m_ignoreMutedMedia|.

This CL
- adds |timecode| [1] to the produced BlobEvents (and
BlobEventInits) and wires it from the platform.
- removes MediaRecorder's ignoreMutedMedia after [2]

[1] https://github.com/w3c/mediacapture-record/issues/73
[2] https://github.com/w3c/mediacapture-record/issues/99

BUG= 676211 ,  678854 

Review-Url: https://codereview.chromium.org/2610163006
Cr-Commit-Position: refs/heads/master@{#442619}

[modify] https://crrev.com/ab5ae32c6233fe7938b9a0b53cf1c74918310d7a/content/renderer/media/media_recorder_handler.cc
[modify] https://crrev.com/ab5ae32c6233fe7938b9a0b53cf1c74918310d7a/content/renderer/media/media_recorder_handler_unittest.cc
[modify] https://crrev.com/ab5ae32c6233fe7938b9a0b53cf1c74918310d7a/third_party/WebKit/LayoutTests/fast/mediarecorder/BlobEvent-basic.html
[modify] https://crrev.com/ab5ae32c6233fe7938b9a0b53cf1c74918310d7a/third_party/WebKit/LayoutTests/fast/mediarecorder/MediaRecorder-audio-video.html
[modify] https://crrev.com/ab5ae32c6233fe7938b9a0b53cf1c74918310d7a/third_party/WebKit/LayoutTests/fast/mediarecorder/MediaRecorder-requestData.html
[modify] https://crrev.com/ab5ae32c6233fe7938b9a0b53cf1c74918310d7a/third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/ab5ae32c6233fe7938b9a0b53cf1c74918310d7a/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/ab5ae32c6233fe7938b9a0b53cf1c74918310d7a/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/ab5ae32c6233fe7938b9a0b53cf1c74918310d7a/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/ab5ae32c6233fe7938b9a0b53cf1c74918310d7a/third_party/WebKit/Source/modules/mediarecorder/BlobEvent.cpp
[modify] https://crrev.com/ab5ae32c6233fe7938b9a0b53cf1c74918310d7a/third_party/WebKit/Source/modules/mediarecorder/BlobEvent.h
[modify] https://crrev.com/ab5ae32c6233fe7938b9a0b53cf1c74918310d7a/third_party/WebKit/Source/modules/mediarecorder/BlobEvent.idl
[modify] https://crrev.com/ab5ae32c6233fe7938b9a0b53cf1c74918310d7a/third_party/WebKit/Source/modules/mediarecorder/BlobEventInit.idl
[modify] https://crrev.com/ab5ae32c6233fe7938b9a0b53cf1c74918310d7a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
[modify] https://crrev.com/ab5ae32c6233fe7938b9a0b53cf1c74918310d7a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h
[modify] https://crrev.com/ab5ae32c6233fe7938b9a0b53cf1c74918310d7a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.idl
[modify] https://crrev.com/ab5ae32c6233fe7938b9a0b53cf1c74918310d7a/third_party/WebKit/public/platform/WebMediaRecorderHandlerClient.h

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8525c81d710cd9a5f92c343825094345e333afd3

commit 8525c81d710cd9a5f92c343825094345e333afd3
Author: mcasas <mcasas@chromium.org>
Date: Wed Jan 18 01:00:39 2017

MediaRecorder: add timecode validation to content_browsertests

Timecode was added recently (see bug) to the Spec and Chrome,
this CL adds some validation of the produced timecodes, which
boils down to they need to be monotonically increasing [1].

BUG= 676211 

[1] https://w3c.github.io/mediacapture-record/MediaRecorder.html#dom-blobevent-timecode

Review-Url: https://codereview.chromium.org/2639693003
Cr-Commit-Position: refs/heads/master@{#444216}

[modify] https://crrev.com/8525c81d710cd9a5f92c343825094345e333afd3/content/test/data/media/mediarecorder_test.html

Comment 8 by mcasas@chromium.org, Jan 18 2017

Labels: Launch-Status-Approval-Requested

Comment 9 by mcasas@chromium.org, Jan 18 2017

Components: Blink>MediaRecording
Components: -Blink>MediaStream>Recording
Bulk move
Blink>MediaStream>Recording ---> Blink>MediaRecording
Cc: owe...@chromium.org
owencm@chromium.org as PM for this.
Labels: -Launch-Status-Approval-Requested
Removing approval requested as that system is only for type=launch issues.

This change is minor enough that it doesn't need a Chrome launch review. It already has blink-dev@ LGTM so proceed.
Status: Fixed (was: Started)

Sign in to add a comment