New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 676210 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocked on:
issue 645736

Blocking:
issue 524758



Sign in to add a comment

Make isolated_scripts suitable for running the layout tests

Project Member Reported by dpranke@chromium.org, Dec 21 2016

Issue description

We're getting close to be able to run the layout tests under swarming (finally! see  bug 524758 ).

I would like for these tests to work like any other isolated script test,
but that can't currently work because we're missing a bunch of functionality.

The most important thing is that the standard isolate command doesn't yet work with an isolate the size of the layout tests. There is a new "exparchive" command that is supposed to work (and that we're testing), but
that means we need to modify the isolate recipes to know whether to use that or not.

Second, we need to make sure that we can correctly merge the JSON test results from multiple shards. Currently the standard mechanism for merging results from isolated scripts doesn't quite work, because the "layout_test_dir" varies from shard to shard, and because run-webkit-tests records tests that are skipped via sharding differently than the merger code expects.

Third, we need to embed the build properties into the test results. In regular script tests, these get passed in a --properties argument; we should probably support that.

Fourth, the layout test results are large and complicated, and we normally upload them to a cloud storage bucket. So, we need to be able to merge the layout-test-results directories from each shard, and then build another complete dir tree and zip and upload them.

I think the way to the second through fourth things is to be able to configure a custom "collect" script that runs when trying to collect the results from swarming. I think this is probably a generically useful hook.


 
Patch to modify the isolate tests step:

https://chromium-review.googlesource.com/c/422460/
Blocking: 524758
Labels: OS-All
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/3e5a44e18ae3744510b00d5698c2de3f8475588b

commit 3e5a44e18ae3744510b00d5698c2de3f8475588b
Author: John Budorick <jbudorick@chromium.org>
Date: Fri Feb 10 00:00:27 2017

Add a custom postprocess/merge hook and wrapper for isolated script tests.

This adds a way to customize how the output from swarming tasks
is merged. It also allows you to run client-side work after the
tasks are completed and the results are collected, and to optionally
customize the links on the collect step in the buildbot page.

These things will be used by the layout tests to merge the
results JSON and archive the results html dirs.

This CL was migrated from dpranke's original at
https://chromium-review.googlesource.com/c/423114/

R=maruel@chromium.org, nednguyen@chromium.org, dpranke@chromium.org
BUG= 676210 

Change-Id: Ie502920549b434782238b6f7cc9e006bb3cab66b
Reviewed-on: https://chromium-review.googlesource.com/433397
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/swarming/example.py
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_all_shards.json
[add] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/swarming/example.expected/isolated_script_with_custom_merge.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_dbg.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_forced.json
[rename] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/swarming/resources/results_merger.py
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.py
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_failing_test.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/swarming/api.py
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/swarming/example.expected/isolated_script_expired_new.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan_vptr.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_shard.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_debug.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_rel.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_memcheck.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/swarming/tests/results_merger_unittest.py
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_memcheck.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac_asan.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_mac_gpu.json
[add] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_merge_script_with_args.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/swarming/example.expected/isolated_script_expired_old.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_debug.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_rel.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_missing_shard.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_invalid_format_isolated_script_test.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/swarming/example.expected/isolated_script_timeout_new.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_msan.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan_vptr.json
[add] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/swarming/resources/standard_isolated_script_merge.py
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test_with_swarming_failure.json
[add] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/isolated_script_test_bad_custom_merge_script.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_non_gpu.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_rel.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_rel.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test_empty.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win__swarming_.json
[add] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_merge_script.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_release.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_disabled.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_asan.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_harness_failure.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/test_utils/test_api.py
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/chromium_tests/steps.py
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_tsan_v2.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_dbg.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_linux_gpu.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_dbg.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win32_asan__swarming_.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/swarming/example.expected/isolated_script_timeout_old.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_tsan2.json
[add] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test_no_chartjson.json
[add] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/swarming/tests/standard_isolated_script_merge_test.py
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux__swarming_.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_failed_isolated_script_test.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test_disabled.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_mac__swarming_.json
[add] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/swarming/tests/collect_isolated_script_task_test.py
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_asan.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_gpu.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_dbg.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_msan.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release.json
[add] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/swarming/resources/collect_isolated_script_task.py
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_rel.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_test.json

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/3e5a44e18ae3744510b00d5698c2de3f8475588b

commit 3e5a44e18ae3744510b00d5698c2de3f8475588b
Author: John Budorick <jbudorick@chromium.org>
Date: Fri Feb 10 00:00:27 2017

Add a custom postprocess/merge hook and wrapper for isolated script tests.

This adds a way to customize how the output from swarming tasks
is merged. It also allows you to run client-side work after the
tasks are completed and the results are collected, and to optionally
customize the links on the collect step in the buildbot page.

These things will be used by the layout tests to merge the
results JSON and archive the results html dirs.

This CL was migrated from dpranke's original at
https://chromium-review.googlesource.com/c/423114/

R=maruel@chromium.org, nednguyen@chromium.org, dpranke@chromium.org
BUG= 676210 

Change-Id: Ie502920549b434782238b6f7cc9e006bb3cab66b
Reviewed-on: https://chromium-review.googlesource.com/433397
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/swarming/example.py
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_all_shards.json
[add] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/swarming/example.expected/isolated_script_with_custom_merge.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_dbg.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_forced.json
[rename] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/swarming/resources/results_merger.py
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.py
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_failing_test.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/swarming/api.py
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/swarming/example.expected/isolated_script_expired_new.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan_vptr.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_shard.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_debug.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_rel.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_memcheck.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/swarming/tests/results_merger_unittest.py
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_memcheck.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac_asan.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_mac_gpu.json
[add] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_merge_script_with_args.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/swarming/example.expected/isolated_script_expired_old.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_debug.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_rel.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_missing_shard.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_invalid_format_isolated_script_test.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/swarming/example.expected/isolated_script_timeout_new.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_msan.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan_vptr.json
[add] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/swarming/resources/standard_isolated_script_merge.py
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test_with_swarming_failure.json
[add] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/isolated_script_test_bad_custom_merge_script.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_non_gpu.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_rel.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_rel.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test_empty.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win__swarming_.json
[add] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_merge_script.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_release.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_disabled.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_asan.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_harness_failure.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/test_utils/test_api.py
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/chromium_tests/steps.py
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_tsan_v2.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_dbg.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_linux_gpu.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_dbg.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win32_asan__swarming_.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/swarming/example.expected/isolated_script_timeout_old.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_tsan2.json
[add] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test_no_chartjson.json
[add] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/swarming/tests/standard_isolated_script_merge_test.py
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux__swarming_.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_failed_isolated_script_test.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test_disabled.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_mac__swarming_.json
[add] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/swarming/tests/collect_isolated_script_task_test.py
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_asan.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_gpu.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_dbg.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_msan.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release.json
[add] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipe_modules/swarming/resources/collect_isolated_script_task.py
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_rel.json
[modify] https://crrev.com/3e5a44e18ae3744510b00d5698c2de3f8475588b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_test.json

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/b6432927585db1d0b22c37bc988e7f5c07f6e06d

commit b6432927585db1d0b22c37bc988e7f5c07f6e06d
Author: John Budorick <jbudorick@chromium.org>
Date: Fri Feb 10 00:41:01 2017

Revert "Add a custom postprocess/merge hook and wrapper for isolated script tests."

This reverts commit 3e5a44e18ae3744510b00d5698c2de3f8475588b.

Reason for revert: breaking.

Original change's description:
> Add a custom postprocess/merge hook and wrapper for isolated script tests.
> 
> This adds a way to customize how the output from swarming tasks
> is merged. It also allows you to run client-side work after the
> tasks are completed and the results are collected, and to optionally
> customize the links on the collect step in the buildbot page.
> 
> These things will be used by the layout tests to merge the
> results JSON and archive the results html dirs.
> 
> This CL was migrated from dpranke's original at
> https://chromium-review.googlesource.com/c/423114/
> 
> R=​maruel@chromium.org, nednguyen@chromium.org, dpranke@chromium.org
> BUG= 676210 
> 
> Change-Id: Ie502920549b434782238b6f7cc9e006bb3cab66b
> Reviewed-on: https://chromium-review.googlesource.com/433397
> Commit-Queue: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
> Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> 

TBR=maruel@chromium.org,phajdan.jr@chromium.org,dpranke@chromium.org,jbudorick@google.com,nednguyen@chromium.org,tansell@chromium.org,martiniss@chromium.org,jbudorick@chromium.org,noinoidk00@gmail.com,chromium-reviews@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 676210 

Change-Id: Ibdcf8ef9863580678417b2c46ff00a8621d9adf9
Reviewed-on: https://chromium-review.googlesource.com/440429
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipe_modules/swarming/example.py
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release.json
[rename] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipe_modules/swarming/results_merger.py
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_all_shards.json
[delete] https://crrev.com/724cb9f5be0790bdfc4ba0fa6e54128ff267980a/scripts/slave/recipe_modules/swarming/example.expected/isolated_script_with_custom_merge.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_dbg.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_forced.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_rel.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/chromium.py
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_failing_test.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipe_modules/swarming/api.py
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipe_modules/swarming/example.expected/isolated_script_expired_new.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan_vptr.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_shard.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_debug.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_rel.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_memcheck.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipe_modules/swarming/tests/results_merger_unittest.py
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_memcheck.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac_asan.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_mac_gpu.json
[delete] https://crrev.com/724cb9f5be0790bdfc4ba0fa6e54128ff267980a/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_merge_script_with_args.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipe_modules/swarming/example.expected/isolated_script_expired_old.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_debug.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_rel.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_missing_shard.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_invalid_format_isolated_script_test.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipe_modules/swarming/example.expected/isolated_script_timeout_new.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_msan.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan_vptr.json
[delete] https://crrev.com/724cb9f5be0790bdfc4ba0fa6e54128ff267980a/scripts/slave/recipe_modules/swarming/resources/standard_isolated_script_merge.py
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test_with_swarming_failure.json
[delete] https://crrev.com/724cb9f5be0790bdfc4ba0fa6e54128ff267980a/scripts/slave/recipes/chromium.expected/isolated_script_test_bad_custom_merge_script.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_non_gpu.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_rel.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test_empty.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win__swarming_.json
[delete] https://crrev.com/724cb9f5be0790bdfc4ba0fa6e54128ff267980a/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_merge_script.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_release.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_disabled.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_asan.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_harness_failure.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipe_modules/test_utils/test_api.py
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipe_modules/chromium_tests/steps.py
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_tsan_v2.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_dbg.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_linux_gpu.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_dbg.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win32_asan__swarming_.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipe_modules/swarming/example.expected/isolated_script_timeout_old.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_tsan2.json
[delete] https://crrev.com/724cb9f5be0790bdfc4ba0fa6e54128ff267980a/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test_no_chartjson.json
[delete] https://crrev.com/724cb9f5be0790bdfc4ba0fa6e54128ff267980a/scripts/slave/recipe_modules/swarming/tests/standard_isolated_script_merge_test.py
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux__swarming_.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_failed_isolated_script_test.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test_disabled.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_mac__swarming_.json
[delete] https://crrev.com/724cb9f5be0790bdfc4ba0fa6e54128ff267980a/scripts/slave/recipe_modules/swarming/tests/collect_isolated_script_task_test.py
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_asan.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_gpu.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_dbg.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_msan.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release.json
[delete] https://crrev.com/724cb9f5be0790bdfc4ba0fa6e54128ff267980a/scripts/slave/recipe_modules/swarming/resources/collect_isolated_script_task.py
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_rel.json
[modify] https://crrev.com/b6432927585db1d0b22c37bc988e7f5c07f6e06d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_test.json

Owner: jbudorick@chromium.org
Reassigning to jbudorick@, since getting that change to land is all that's left here, I think.
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/8e1aab781f894d7b0df576fcee99c0ebeadf0a45

commit 8e1aab781f894d7b0df576fcee99c0ebeadf0a45
Author: John Budorick <jbudorick@chromium.org>
Date: Mon Feb 13 17:46:05 2017

Add a custom postprocess/merge hook and wrapper for isolated script tests. (RELAND)

This adds a way to customize how the output from swarming tasks
is merged. It also allows you to run client-side work after the
tasks are completed and the results are collected, and to optionally
customize the links on the collect step in the buildbot page.

These things will be used by the layout tests to merge the
results JSON and archive the results html dirs.

This CL is a reland of https://chromium-review.googlesource.com/c/433397/

BUG= 676210 

Change-Id: I6fbff9955d5c269f039d026d1451aa9447f79f69
Reviewed-on: https://chromium-review.googlesource.com/441391
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipe_modules/swarming/example.py
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_all_shards.json
[add] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipe_modules/swarming/example.expected/isolated_script_with_custom_merge.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_dbg.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_forced.json
[rename] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipe_modules/swarming/resources/results_merger.py
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/chromium.py
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_failing_test.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipe_modules/test_utils/test_api.py
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipe_modules/swarming/example.expected/isolated_script_expired_new.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan_vptr.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_shard.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_debug.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_rel.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_memcheck.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipe_modules/swarming/tests/results_merger_unittest.py
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_memcheck.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac_asan.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_mac_gpu.json
[add] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_merge_script_with_args.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipe_modules/swarming/example.expected/isolated_script_expired_old.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_debug.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_rel.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test_with_swarming_failure.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_missing_shard.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_invalid_format_isolated_script_test.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipe_modules/swarming/example.expected/isolated_script_timeout_new.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_msan.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan_vptr.json
[add] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipe_modules/swarming/resources/standard_isolated_script_merge.py
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipe_modules/swarming/example.expected/isolated_large_outdir.json
[add] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/chromium.expected/isolated_script_test_bad_custom_merge_script.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_non_gpu.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_rel.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_rel.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test_empty.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win__swarming_.json
[add] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_merge_script.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_release.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_disabled.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_asan.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_harness_failure.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipe_modules/swarming/api.py
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipe_modules/chromium_tests/steps.py
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_tsan_v2.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_dbg.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_linux_gpu.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_dbg.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win32_asan__swarming_.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipe_modules/swarming/example.expected/isolated_script_timeout_old.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_tsan2.json
[add] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test_no_chartjson.json
[add] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipe_modules/swarming/tests/standard_isolated_script_merge_test.py
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux__swarming_.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_failed_isolated_script_test.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test_disabled.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_mac__swarming_.json
[add] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipe_modules/swarming/tests/collect_isolated_script_task_test.py
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_asan.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_gpu.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_dbg.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_msan.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release.json
[add] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipe_modules/swarming/resources/collect_isolated_script_task.py
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_rel.json
[modify] https://crrev.com/8e1aab781f894d7b0df576fcee99c0ebeadf0a45/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_test.json

Comment 9 by kbr@chromium.org, Feb 14 2017

Blockedon: 645736

Sign in to add a comment