Chrome Official build fails at setup_unittests target |
||
Issue descriptionBuild fails due to symbols required, from a missing include: ninja -t msvc -e environment.x64 -- C:\src\goma-win64/gomacc.exe "c:\src\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/chrome/installer/setup/setup_unittests/setup_util_unittest.obj.rsp /c ../../chrome/installer/setup/setup_util_unittest.cc /Foobj/chrome/installer/setup/setup_unittests/setup_util_unittest.obj /Fd"obj/chrome/installer/setup/setup_unittests_cc.pdb" c:\src\git-chrome-internal\src\chrome\installer\setup\setup_util_unittest.cc(211): error C2653: 'InstallUtil': is not a class or namespace name c:\src\git-chrome-internal\src\chrome\installer\setup\setup_util_unittest.cc(211): error C3861: 'IsChromeSxSProcess': identifier not found This code was added in https://codereview.chromium.org/2507753002/
,
Dec 21 2016
Uploaded https://codereview.chromium.org/2590173004/ to fix this.
,
Dec 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4fad38f7761ee4193d30b80416d26c6412b991c commit a4fad38f7761ee4193d30b80416d26c6412b991c Author: pastarmovj <pastarmovj@chromium.org> Date: Wed Dec 21 09:31:36 2016 Add missing include to setup_util_unittest.cc. This fixes compilation failure in the official Chrome build for Windows. Patch from issue 2590173004 at patchset 1 (http://crrev.com/2590173004#ps1) Orignal author wez@chromium.org. BUG= 676202 Review-Url: https://codereview.chromium.org/2593853004 Cr-Commit-Position: refs/heads/master@{#440062} [modify] https://crrev.com/a4fad38f7761ee4193d30b80416d26c6412b991c/chrome/installer/setup/setup_util_unittest.cc
,
Dec 21 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by w...@chromium.org
, Dec 21 2016