David to prioritize this FR

We will def look into this once the source item is resolved.

This is a HUGE need for us.  Please, Google, help with this situation.

I would like to be able to do this also for my devices.  Please add the feature.

Without having the hostname configurable and available, it makes troubleshooting wireless, dhcp, etc issues difficult.  Please add this so that we can add a hostname to our devices and then identify them in our router, switch, dhcp, etc client lists where connected hostnames are displayed.  Thanks!

This is a HUGE need for us, also.  Please, Google, help with this situation.

This would be a great help to us as well. Please Google.

The policy will be surfaced as a string in the admin UI. Values:

(default) no policy:               No DHCP option 12 attached - Existing behavior
Policy=xxx                         xxx
Policy=${ASSET_ID}                 Device's asset ID [1]
Policy=${SERIAL_NUM}               Device's serial number
Policy=${MAC_ADDR}                 Device's MAC address
Policy=xxx+VAR+xxx                 xxx+VAR_VALUE+xxx


[1] https://chromereleases.googleblog.com/2015/04/admin-console-update_8.html

So if we say that we have only 3 variables (ASSET_ID, SERIAL_NUM, MAC_ADDR) and we do simple case-sensitive string substitution for them, then we actually have only two options: 

(default) no policy:               No DHCP option 12 attached - Existing behavior
Policy=xxxVARxxx                 xxxVAR_VALUExxx

But we would need to validate hostname after, and this brings us to question "What to do if resulting hostname is invalid?". We do not want to set invalid host name, as it might either result in rejected DHCP request, or be a way to exploit DHCP server vulnerabilities. And at this point there are few ways we can use to indicate errors: system logging and setting some message-containing host name.

I'd like for Cpanel to detect invalid hostnames, since this is the best place for the user to notice the error.

If an invalid hostname somehow makes it into the policy, shill can drop it and log an error.  This shouldn't normally happen, of course.

FWIW:

1) I don't see any validation of kHostnameProperty (hostname_) happening in $SHILL/dhcp/dhcpv4_config.cc so we should check that.  Same for vendor_class_.  Seeing string properties from Chrome getting copied directly into subprocess command-line arguments makes me nervous.

2) DhcpProperties::kHostnameProperty and DhcpProperties::kVendorClassProperty should probably be moved into dbus-constants.h in the system_api package so that Chrome can use them.

Re: cpanel detection, is this actually viable if we do client-side substitution of things like Asset ID?

Btw, Asset ID seem to have no validation - it can be arbitrary long, start with digits, contain weird UTF symbols, etc.

I believe we should have defend-it-depth here: sanity checks on at least 3 layers: ChromeOS (shill), Chrome (layer that applies policy) and CPanel (to prevent absurd values in policy).

If the Asset ID field is less restrictive than the Hostname field by design, I would suggest substituting (say) '_' for any disallowed characters found in the Asset ID, when shill creates the parameter to pass to dhcpcd.

For substitutions like "append the last 3 octets of the MAC address" (found in the doc we discussed over email), that should not present a validation problem, unless the final hostname string is too long.

tbh I would prefer not to work too hard on ensuring sanity of hostname. The admin is responsible for creating hostnames that fit into whatever use case they want to aim for. We can add warnings to admins so that they understand what they are getting themsevles into. But wouldn't do things like changing non-characters into _ and such. Seems quite overkill and unpredictable from an admin's perspective.

I normally wouldn't care either, but letting bad strings percolate into dhcpcd parameters or DHCP options could create security issues for software that isn't designed to handle them.

"_" isn't valid in DNS labels, only [-0-9a-zA-Z]

This is a limitation of hostnames, not a DNS limitation.

(DNS is not just for hostnames and hostnames are not just in DNS)

https://en.wikipedia.org/wiki/Internationalized_domain_name#Internationalizing_Domain_Names_in_Applications

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/339c49a48ae67a0a070c3f9c954a5a52c54057e1

commit 339c49a48ae67a0a070c3f9c954a5a52c54057e1
Author: Denis Kuznetsov <antrim@google.com>
Date: Mon Dec 04 01:03:37 2017

Add a policy to specify device Hostame in DHCP request.

Bug:  676195 
Change-Id: I450fcf3416f620ce9867d55ea225c610583d1169
Reviewed-on: https://chromium-review.googlesource.com/764168
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521241}
[modify] https://crrev.com/339c49a48ae67a0a070c3f9c954a5a52c54057e1/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/339c49a48ae67a0a070c3f9c954a5a52c54057e1/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
[modify] https://crrev.com/339c49a48ae67a0a070c3f9c954a5a52c54057e1/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h
[modify] https://crrev.com/339c49a48ae67a0a070c3f9c954a5a52c54057e1/chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc
[add] https://crrev.com/339c49a48ae67a0a070c3f9c954a5a52c54057e1/chrome/browser/chromeos/policy/hostname_handler.cc
[add] https://crrev.com/339c49a48ae67a0a070c3f9c954a5a52c54057e1/chrome/browser/chromeos/policy/hostname_handler.h
[add] https://crrev.com/339c49a48ae67a0a070c3f9c954a5a52c54057e1/chrome/browser/chromeos/policy/hostname_handler_unittest.cc
[modify] https://crrev.com/339c49a48ae67a0a070c3f9c954a5a52c54057e1/chrome/browser/chromeos/settings/device_settings_provider.cc
[modify] https://crrev.com/339c49a48ae67a0a070c3f9c954a5a52c54057e1/chrome/browser/chromeos/settings/device_settings_provider_unittest.cc
[modify] https://crrev.com/339c49a48ae67a0a070c3f9c954a5a52c54057e1/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/339c49a48ae67a0a070c3f9c954a5a52c54057e1/chromeos/network/network_state_handler.cc
[modify] https://crrev.com/339c49a48ae67a0a070c3f9c954a5a52c54057e1/chromeos/network/network_state_handler.h
[modify] https://crrev.com/339c49a48ae67a0a070c3f9c954a5a52c54057e1/chromeos/network/shill_property_handler.cc
[modify] https://crrev.com/339c49a48ae67a0a070c3f9c954a5a52c54057e1/chromeos/network/shill_property_handler.h
[modify] https://crrev.com/339c49a48ae67a0a070c3f9c954a5a52c54057e1/chromeos/settings/cros_settings_names.cc
[modify] https://crrev.com/339c49a48ae67a0a070c3f9c954a5a52c54057e1/chromeos/settings/cros_settings_names.h
[modify] https://crrev.com/339c49a48ae67a0a070c3f9c954a5a52c54057e1/components/policy/proto/chrome_device_policy.proto
[modify] https://crrev.com/339c49a48ae67a0a070c3f9c954a5a52c54057e1/components/policy/resources/policy_templates.json
[modify] https://crrev.com/339c49a48ae67a0a070c3f9c954a5a52c54057e1/tools/metrics/histograms/enums.xml

Hi,  may I know where's the fix or feature got applied? Is it in the Admin Console? Any help and answers will be much appreciated. Thank you!

You configure a device name in Admin Console.
Then you take some router that supports  and see that after device connects to router, you check that there is a dhcp client connected with a given name.

The admin console setting is planned for end of March, early April. We will update this bug once the setting is surfaced.

are you guys still on track to have this feature available by end of March, early April?

dskaram@
as you commented on #25, 
Do you have any update that can be shared with the customer?

The change is available client-side but still not surfaced server-side. Due to some delays, we had to punt to Q2. So please expect this by end of this quarter.

Are there any updates on the availability of this feature please?

Is this feature available as of August 2018? If so please indicate where it is configured. Thanks.

Cheers everyone,

I have a technical case open (16780036) requesting an update on this matter and public facing documentation on how to perform the procedure in his devices.  What's the feedback we have to provide in this matter?

Technical work on this is completed. Please reach out to marcuskoehler@ if you need additional information/public-facing docs and he can help coordinate that effort.

Any there any instructions on where this is configured / rollout schedule please?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85203f2094a0673955fcef4716a79bec4a604e9c

commit 85203f2094a0673955fcef4716a79bec4a604e9c
Author: Denis Kuznetsov <antrim@google.com>
Date: Mon Sep 03 14:24:11 2018

Make policy description public

Bug:  676195 
Change-Id: I75ba73a7ee75d446c8d5b79d8f4c45aed569940d
Reviewed-on: https://chromium-review.googlesource.com/1201855
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588388}
[modify] https://crrev.com/85203f2094a0673955fcef4716a79bec4a604e9c/components/policy/resources/policy_templates.json

 Issue 593574  has been merged into this issue.

Hello everyone,
hello antrim@chromium.org

is there any update to this issue?

If I understood the conversation correctly, in the end only the update for the admin console is missing, right?

We need this to get a valid DHCP-Hostname.

Please give us a schedule for the update of the admin console.

We would be infinitely grateful!

Yes, all pieces are there except for admin console changes.
I've asked people from Admin Console team to look on this issue.

Please get this online!  I manage a school with thousands of chromebooks, and it's crazy not to be able to see which is which in DHCP/DNS!

I gave up on this long ago, but would love to see this finally implemented.  Please push this through, seems like such a standard and simple thing.  Thanks.

Any word on this? We also manage 20K plus Chromebooks. Having a name to resolve would help tremendously.