New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 676191 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

iOS native history sync tests

Project Member Reported by jyqu...@chromium.org, Dec 21 2016

Issue description

iOS native history does not have tests for sync functionality, including confirming the correct message shown to the user in signed in versus signed out and syncing versus not syncing states. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cc8e9fb672d4dedbdbd04dd88ad741333d1670b

commit 3cc8e9fb672d4dedbdbd04dd88ad741333d1670b
Author: jyquinn <jyquinn@chromium.org>
Date: Fri Dec 23 00:51:07 2016

[ios] Open links in history status message in new tab and add test

Makes links in the history entries status message (sync or local)
open in new tab rather than current tab. Also adds
testHistoryEntriesStatusItem to test that a message about history
entries shows up on the history panel when the user is signed in and
that tapping the link in the message opens a new tab with sync info.

BUG=676191

Review-Url: https://codereview.chromium.org/2598763002
Cr-Commit-Position: refs/heads/master@{#440566}

[modify] https://crrev.com/3cc8e9fb672d4dedbdbd04dd88ad741333d1670b/ios/chrome/browser/ui/history/BUILD.gn
[modify] https://crrev.com/3cc8e9fb672d4dedbdbd04dd88ad741333d1670b/ios/chrome/browser/ui/history/history_collection_view_controller.mm
[modify] https://crrev.com/3cc8e9fb672d4dedbdbd04dd88ad741333d1670b/ios/chrome/browser/ui/history/history_ui_egtest.mm

Cc: -sczs@chromium.org baxley@chromium.org jyqu...@chromium.org
Owner: sczs@chromium.org
Status: Assigned (was: Started)
There is now one test for the history entries message, which tests signed-in versus not signed-in state. It would also be good to have tests for sync functionality, a la the tests in sync_fake_server_egtest.mm.
sczs: Is this bug worth keeping open?
Yes, we're still not testing this on EGTests. I'll try to address this along the other Franky->EGTests requests that we've been getting from testing.
Components: Tests>Missing
Components: -Test>Missing

Sign in to add a comment