Issue metadata
Sign in to add a comment
|
Using high contrast mode shortcut types H |
||||||||||||||||||||||||
Issue description56.0.2924.28 What steps will reproduce the problem? (1) Press search+shift+h for high contrast mode. (2) See that H is typed. What is the expected result? Like other shortcuts, no typing happens. Happens on: - google.com search box - password field of login screen - gmail compose window Does not happen on: - url bar
,
Dec 21 2016
Dominic, I just filed the test review to get the Shift+Search+H shortcut fully approved via launch review. Katherine filed this and mentioned that once this is resolved, she can flip the test bit. Can you take a look please?
,
Dec 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7ea139838c04b7e254f70debe51e794beda2f1c commit f7ea139838c04b7e254f70debe51e794beda2f1c Author: dmazzoni <dmazzoni@chromium.org> Date: Wed Dec 21 23:04:48 2016 Toggle High Contrast on Chrome OS should toggle on key down, not key up This was just an accidental oversight. Triggering on key up means that if you're focused on a text box, the H key gets pressed. We deliberately picked Search+Shift as the modifier keys so that it wouldn't interfere with any web apps, so it's fine that it completely steals that key down event. BUG= 676178 , 644758 TBR=jamescook Review-Url: https://codereview.chromium.org/2592223002 Cr-Commit-Position: refs/heads/master@{#440255} [modify] https://crrev.com/f7ea139838c04b7e254f70debe51e794beda2f1c/ash/common/accelerators/accelerator_table.cc
,
Dec 23 2016
Verified working in M-57 on 9112.0.0, 57.0.2959.0.
,
Dec 23 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 26 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 29 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 3 2017
,
Jan 3 2017
@Dominic, would it be possible for you to merge this?
,
Jan 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b13914173819e4465e4d6b7ef22562db399ee51 commit 0b13914173819e4465e4d6b7ef22562db399ee51 Author: Mitsuru Oshima <oshima@chromium.org> Date: Fri Jan 06 17:46:23 2017 Toggle High Contrast on Chrome OS should toggle on key down, not key up This was just an accidental oversight. Triggering on key up means that if you're focused on a text box, the H key gets pressed. We deliberately picked Search+Shift as the modifier keys so that it wouldn't interfere with any web apps, so it's fine that it completely steals that key down event. BUG= 676178 , 644758 TBR=jamescook Review-Url: https://codereview.chromium.org/2592223002 Cr-Commit-Position: refs/heads/master@{#440255} (cherry picked from commit f7ea139838c04b7e254f70debe51e794beda2f1c) Review-Url: https://codereview.chromium.org/2616113002 . Cr-Commit-Position: refs/branch-heads/2924@{#687} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/0b13914173819e4465e4d6b7ef22562db399ee51/ash/common/accelerators/accelerator_table.cc
,
Jan 6 2017
,
Jan 11 2017
Verified on 56.0.2924.58 |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by kathrelk...@chromium.org
, Dec 20 2016