New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 676166 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jan 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

afdo_use is not supported with clang

Project Member Reported by laszio@chromium.org, Dec 20 2016

Issue description

If both afdo_use and clang are specified in USE, afdo_use will not be effective.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/40021003bd77ec489bf2cddc60dca796143a7efe

commit 40021003bd77ec489bf2cddc60dca796143a7efe
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Thu Jan 05 02:16:10 2017

afdo: update ebuilds differently for gcc and llvm

The profile versions for these two configurations might be different.

BUG= chromium:676166 
CQ-DEPEND=CL:422656
TEST=cbuildbot master-chromium-pfq without push
     cbuildbot samus-pre-flight-branch without push

Change-Id: I104c89c380e7d38f1129a3166ea7a5ed6190a9eb
Reviewed-on: https://chromium-review.googlesource.com/425000
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>

[modify] https://crrev.com/40021003bd77ec489bf2cddc60dca796143a7efe/cbuildbot/afdo.py
[modify] https://crrev.com/40021003bd77ec489bf2cddc60dca796143a7efe/cbuildbot/stages/afdo_stages.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/14f162f47cdc3685b8d4d01307cea36990873229

commit 14f162f47cdc3685b8d4d01307cea36990873229
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Wed Dec 21 23:15:40 2016

Support USE=afdo_use with USE=clang

gcc and clang use different command line options and file formats
to receive profile data. This patch implements the clang part.

BUG= chromium:676166 
TEST=emerge-chell chromeos-chrome with clang and llvm-next.
     emerge-kevin chromeos-chrome with gcc.

Change-Id: Iecd9b3d74afbe1a2ec42d8bbc6141def72ddf732
Reviewed-on: https://chromium-review.googlesource.com/422656
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>

[modify] https://crrev.com/14f162f47cdc3685b8d4d01307cea36990873229/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Comment 3 by laszio@chromium.org, Jan 13 2017

Status: Fixed (was: Started)

Comment 4 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 5 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61
Status: Verified (was: Fixed)
Closing. Please reopen it if its not fixed. Thanks!

Sign in to add a comment