New issue
Advanced search Search tips

Issue 676147 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Virtualize DataUseRecorder's destructor

Project Member Reported by ryansturm@chromium.org, Dec 20 2016

Issue description

DataUseRecorder's destructor is not virtual and ChromeDataUseRecorder inherits from it. While there are no delete's called on DataUseRecorder pointers, this may not hold true in the future.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35bfb2b24de94145f1aac42a41c73e11427281d4

commit 35bfb2b24de94145f1aac42a41c73e11427281d4
Author: ryansturm <ryansturm@chromium.org>
Date: Wed Dec 21 00:03:21 2016

Virtualize DataUseRecorder's destructor

DataUseRecorder's destructor is not virtual and ChromeDataUseRecorder
inherits from it. While there are no delete's called on DataUseRecorder
pointers, this may not hold true in the future.

BUG= 676147 

Review-Url: https://codereview.chromium.org/2592653005
Cr-Commit-Position: refs/heads/master@{#439941}

[modify] https://crrev.com/35bfb2b24de94145f1aac42a41c73e11427281d4/chrome/browser/data_use_measurement/chrome_data_use_recorder.h
[modify] https://crrev.com/35bfb2b24de94145f1aac42a41c73e11427281d4/components/data_use_measurement/core/data_use_recorder.h

Components: Internals>Network>DataProxy
Status: Fixed (was: Started)

Sign in to add a comment