Support adding new release board through GE |
|||||
Issue descriptiona poppy-release (new board) build needs to be added to ChromeOs waterfall through GE, but it's prevented by config-updater because it failed the testAllBoardsExist unittest. chromeos_config should automatically add boards from GE to the right board list. Currently this is blocked as not every board from GE template is associated with a right type (ARM/X86, external/internal). Current solutions: 1) add poppy board to chromeos_config.py board_list manually. (this will allow config-updater to check-in the poppy-release build). 2) GE exports a valid template, in which every board is associated with a right type. 3) change chromeos_config to add all boards from GE to the right board list.
,
Dec 20 2016
Is this a newly added unittest? The config-updater was green around last week I believe?
,
Dec 20 2016
I do have a CL https://chromium-review.googlesource.com/#/c/420806/ which adds poppy into the list, but is current on hold.
,
Dec 20 2016
it's an old unittest. It's just we never directly added new boards through GE. I think we can get yueherngl@'s CL in first.
,
Dec 21 2016
We'd better either checkin the CL https://chromium-review.googlesource.com/#/c/420806/ or remove poppy from GE, to bring config-updater back to work. WDYT, moch@ ?
,
Feb 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/8325eb076cfbdc163cb09c59192d2f801ba0da9c commit 8325eb076cfbdc163cb09c59192d2f801ba0da9c Author: Ningning Xia <nxia@chromium.org> Date: Sat Feb 04 07:21:26 2017 Support adding new board-release builds to GE. Previously, config-updater failed to merge changes when the changes tried to add new board-release builds to GE. Changes: 1) add GetArchBoardDict to support get boards by types from ge_build_config. 2) refactor chromeos_config to build board_type to board_names dict given the boards in chromeos_config and ge_build_config. BUG= chromium:676143 TEST=unit_tests Change-Id: Id260737698a91edfc672b192f46eb5f9122f9eaf Reviewed-on: https://chromium-review.googlesource.com/436351 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/8325eb076cfbdc163cb09c59192d2f801ba0da9c/lib/config_lib_unittest.py [modify] https://crrev.com/8325eb076cfbdc163cb09c59192d2f801ba0da9c/lib/config_lib.py [modify] https://crrev.com/8325eb076cfbdc163cb09c59192d2f801ba0da9c/cbuildbot/chromeos_config_unittest.py [modify] https://crrev.com/8325eb076cfbdc163cb09c59192d2f801ba0da9c/cbuildbot/chromeos_config.py
,
Mar 21 2017
,
Jun 21 2017
,
Jan 22 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by nxia@chromium.org
, Dec 20 2016