New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 676124 link

Starred by 8 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 659138



Sign in to add a comment

Text Detection for Chrome on Android

Project Member Reported by xianglu@google.com, Dec 20 2016

Issue description

Text detection, similar to barcode detection is supported on Android via Play Services. 
Overview: https://developers.google.com/vision/text-overview
Documentation: https://developers.google.com/android/reference/com/google/android/gms/vision/text/package-summary

Implement based on spec (https://wicg.github.io/shape-detection-api/#text-detection-api)

 

Comment 1 by mcasas@chromium.org, Dec 22 2016

Cc: mcasas@chromium.org
Components: Blink>ImageCapture
Labels: ShapeDetection
Owner: xianglu@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 2 Deleted

Description: Show this description
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbe29b0276f347c3619cdc33fcb6540eef466bb9

commit bbe29b0276f347c3619cdc33fcb6540eef466bb9
Author: xianglu <xianglu@chromium.org>
Date: Mon Jan 09 18:12:36 2017

Shape Detection: Add Text Detection in Chrome Android

This CL adds text detection API in addition to face detection and barcode
detection. It uses com.google.android.gms package and is registered in
ChromeInterfaceRegistrar.java.

Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/JkdoxpINjxQ

BUG= 676124 
SPEC=
 https://wicg.github.io/shape-detection-api/#text-detection-api
TEST(Layout)=
 third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
 third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html
DEMO=
 https://s.codepen.io/xianglu_google/debug/pNGBKv
 https://s.codepen.io/xianglu_google/debug/QGoaYe
 https://drive.google.com/file/d/0B3T2kSOMuTq3aFhZelAxTFdNWUk/view?usp=sharing (video)

Review-Url: https://codereview.chromium.org/2588293005
Cr-Commit-Position: refs/heads/master@{#442293}

[modify] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/chrome/android/java/src/org/chromium/chrome/browser/mojo/ChromeInterfaceRegistrar.java
[add] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionFactory.java
[add] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionImpl.java
[modify] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/chrome/android/java_sources.gni
[modify] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/chrome/browser/DEPS
[modify] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
[modify] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
[modify] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expected.txt
[modify] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
[modify] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
[modify] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
[modify] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
[modify] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html
[modify] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js
[add] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/third_party/WebKit/LayoutTests/shapedetection/resources/mock-textdetection.js
[modify] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/third_party/WebKit/Source/modules/shapedetection/BUILD.gn
[modify] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp
[add] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/third_party/WebKit/Source/modules/shapedetection/DetectedText.cpp
[add] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/third_party/WebKit/Source/modules/shapedetection/DetectedText.h
[add] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/third_party/WebKit/Source/modules/shapedetection/DetectedText.idl
[modify] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
[add] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
[add] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/third_party/WebKit/Source/modules/shapedetection/TextDetector.h
[add] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/third_party/WebKit/Source/modules/shapedetection/TextDetector.idl
[modify] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/third_party/WebKit/public/BUILD.gn
[add] https://crrev.com/bbe29b0276f347c3619cdc33fcb6540eef466bb9/third_party/WebKit/public/platform/modules/shapedetection/textdetection.mojom

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04e8ca70316308763a6f51d1ee11960819887f7e

commit 04e8ca70316308763a6f51d1ee11960819887f7e
Author: mcasas <mcasas@chromium.org>
Date: Wed Mar 01 03:19:19 2017

Shape detection: moar content_browsertests (face, qr/barcode)

In the spirit of "if it can be tested, it ought to be tested", this
CL cleans up and expands the a few tests related to Shape Detection.

- the current content_browsertest, which on ToT is extended to
work on Mac and cleaned up (generalized and parameterized, variable
names clarified).

- the test face is changed to a smaller, public domain one of size
6182B (~1.4K smaller).

- Also corrected names: s/shapedetection/shape_detection/

- QR/barcode and text detection in Android is based on coreGMS,
so need to be tested under chrome/. A new ShapeDetectionTest.java
is added for that.  To use coreGMS, we have to guarantee that
StrictMode.allowThreadDiskWrites().

BUG= 665150 ,  676124 

Review-Url: https://codereview.chromium.org/2711893003
Cr-Commit-Position: refs/heads/master@{#453818}

[modify] https://crrev.com/04e8ca70316308763a6f51d1ee11960819887f7e/chrome/android/java_sources.gni
[add] https://crrev.com/04e8ca70316308763a6f51d1ee11960819887f7e/chrome/android/javatests/src/org/chromium/chrome/browser/shape_detection/ShapeDetectionTest.java
[add] https://crrev.com/04e8ca70316308763a6f51d1ee11960819887f7e/chrome/test/data/android/barcode_detection.html
[add] https://crrev.com/04e8ca70316308763a6f51d1ee11960819887f7e/chrome/test/data/android/text_detection.html
[add] https://crrev.com/04e8ca70316308763a6f51d1ee11960819887f7e/content/browser/shape_detection/shape_detection_browsertest.cc
[delete] https://crrev.com/bd3f676ad85ff5e61204c2e8c41d3328fe2ae182/content/browser/shapedetection/shapedetection_browsertest.cc
[modify] https://crrev.com/04e8ca70316308763a6f51d1ee11960819887f7e/content/test/BUILD.gn
[rename] https://crrev.com/04e8ca70316308763a6f51d1ee11960819887f7e/content/test/data/media/shape_detection_test.html
[modify] https://crrev.com/04e8ca70316308763a6f51d1ee11960819887f7e/content/test/data/single_face.jpg

Labels: -OS-Linux OS-Android
Status: Fixed (was: Assigned)
With the tests in #6 in place, I think we're good here.
Blocking: 659138

Sign in to add a comment