New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 676120 link

Starred by 1 user
Status: WontFix
Owner:
█ twif...@chromium.org
Last visit > 30 days ago
Closed: Apr 2018
Cc:
wifiprefetch-reviews@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android
Pri: 3
Type: Bug



Sign in to add a comment

Inconsistent schema in precache_urls

Project Member Reported by twif...@chromium.org, Dec 20 2016 
PrecacheURLTable::CreateTableIfNonExistent() issues a CREATE TABLE for new users, and for old users, an ALTER TABLE to add various columns.

The CREATE TABLE for is_precached does not specify a default value, but the ALTER TABLE specifies a default of 1. So we've got users with both schemas out there.

I'm not sure what the impact of this is. We should evaluate the impact, figure out what the default should be, send a change to correct users' schemae, and figure out whether it's bad enough that we should cherry-pick.

Comment 1 by twif...@chromium.org, Dec 21 2016 

Per https://codereview.chromium.org/2586813004/diff/80001/components/precache/core/precache_url_table.cc#newcode177:

"This may cause a bug in the future but, currently, I think it won't affect the
behavior since we never rely on the default value in the current implementation
of AddURL."

Comment 2 by twif...@chromium.org, Apr 11 2017

Components: Internals>Preload

Comment 3 by twif...@chromium.org, Apr 11 2017

Components: -Internals>Network>DataUse
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 12 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by twif...@chromium.org, Apr 12 2018

Status: WontFix (was: Untriaged)
►

Sign in to add a comment