New issue
Advanced search Search tips

Issue 676105 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Local extensions doc server hangs

Project Member Reported by tbarzic@chromium.org, Dec 20 2016

Issue description

chrome/common/extensions/doc/server2/preview.py hangs when attempting to view API list, or a specific API documentation.

The issue seems to be that doc server does not recognize API dependencies on behavior features (introduced in   https://chromium.googlesource.com/chromium/src.git/+/975d838eca97d3cac1578861c9df42fe46e2a9d5) - preview just hangs repeatedly attempting to resolve networkingPrivate and networking.onc API features.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1e3e116e8b8b3fd88eade4dae3521354ff8efd1

commit c1e3e116e8b8b3fd88eade4dae3521354ff8efd1
Author: tbarzic <tbarzic@chromium.org>
Date: Wed Dec 21 18:41:02 2016

Remove networking API permissions depdendency on behavior feature

Docs server does not handle API dependency on behavior features, so
having networkingPrivate and networking.onc depend on a behavior
feature to provide white list breaks docserver preview.py.
To avoid the issue, replicate whitelists in _permission_features file
for each of the permissions.

BUG= 676105 ,672186

Review-Url: https://codereview.chromium.org/2592613003
Cr-Commit-Position: refs/heads/master@{#440164}

[modify] https://crrev.com/c1e3e116e8b8b3fd88eade4dae3521354ff8efd1/extensions/common/api/_behavior_features.json
[modify] https://crrev.com/c1e3e116e8b8b3fd88eade4dae3521354ff8efd1/extensions/common/api/_permission_features.json
[modify] https://crrev.com/c1e3e116e8b8b3fd88eade4dae3521354ff8efd1/extensions/common/extension_api.cc
[modify] https://crrev.com/c1e3e116e8b8b3fd88eade4dae3521354ff8efd1/extensions/common/features/behavior_feature.cc
[modify] https://crrev.com/c1e3e116e8b8b3fd88eade4dae3521354ff8efd1/extensions/common/features/behavior_feature.h

Status: Fixed (was: Started)

Sign in to add a comment