[HBD] Flash navigations in popup windows are not intercepted |
||||||
Issue descriptionRepro steps: 0. Make sure HBD is on, Flash is installed. 1. Goto http://pps-test-a.appspot.com/popup.html 2. Click the link to open the popup. 3. Click the Download Flash link. 4. Observe that the navigation is not intercepted.
,
Dec 22 2016
,
Dec 23 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 24 2016
looks like this also impacts NFL.com's gamepass, which pops a window to watch the game, and then also detects in that window.
,
Dec 27 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 30 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85b4f6a7e6cb7792c9af14a82a8260f66f4355ed commit 85b4f6a7e6cb7792c9af14a82a8260f66f4355ed Author: Tommy C. Li <tommycli@chromium.org> Date: Mon Jan 09 19:43:07 2017 [HBD] Intercept Flash navigations in popup windows. This CL turns up the Flash download interception aggression - by making it apply to popup windows as well. This should be fairly harmless. BUG= 676096 Review-Url: https://codereview.chromium.org/2590363003 Cr-Commit-Position: refs/heads/master@{#440518} (cherry picked from commit d60fef6f171bacc82ecaf3f1d4b70450d49ad1cc) Review-Url: https://codereview.chromium.org/2623593002 . Cr-Commit-Position: refs/branch-heads/2924@{#703} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/85b4f6a7e6cb7792c9af14a82a8260f66f4355ed/chrome/browser/plugins/flash_download_interception.cc [modify] https://crrev.com/85b4f6a7e6cb7792c9af14a82a8260f66f4355ed/chrome/browser/plugins/flash_permission_browsertest.cc [modify] https://crrev.com/85b4f6a7e6cb7792c9af14a82a8260f66f4355ed/chrome/test/data/permissions/flash.js
,
Jan 9 2017
,
Jan 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1bd7c525a6024db82d6c5f24277c84b09edeb341 commit 1bd7c525a6024db82d6c5f24277c84b09edeb341 Author: dewittj <dewittj@chromium.org> Date: Mon Jan 09 22:35:46 2017 Revert of [HBD] Intercept Flash navigations in popup windows. (patchset #1 id:1 of https://codereview.chromium.org/2623593002/ ) Reason for revert: PageReloadWaiter not defined. Original issue's description: > [HBD] Intercept Flash navigations in popup windows. > > This CL turns up the Flash download interception aggression - by making > it apply to popup windows as well. > > This should be fairly harmless. > > BUG= 676096 > > Review-Url: https://codereview.chromium.org/2590363003 > Cr-Commit-Position: refs/heads/master@{#440518} > (cherry picked from commit d60fef6f171bacc82ecaf3f1d4b70450d49ad1cc) > > Review-Url: https://codereview.chromium.org/2623593002 . > Cr-Commit-Position: refs/branch-heads/2924@{#703} > Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} > Committed: https://chromium.googlesource.com/chromium/src/+/85b4f6a7e6cb7792c9af14a82a8260f66f4355ed TBR=tommycli@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 676096 ,679496 Review-Url: https://codereview.chromium.org/2622643004 Cr-Commit-Position: refs/branch-heads/2924@{#707} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/1bd7c525a6024db82d6c5f24277c84b09edeb341/chrome/browser/plugins/flash_download_interception.cc [modify] https://crrev.com/1bd7c525a6024db82d6c5f24277c84b09edeb341/chrome/browser/plugins/flash_permission_browsertest.cc [modify] https://crrev.com/1bd7c525a6024db82d6c5f24277c84b09edeb341/chrome/test/data/permissions/flash.js
,
Jan 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3ed2163bfdd00c29966c43c46afbd678ab4a8a9 commit d3ed2163bfdd00c29966c43c46afbd678ab4a8a9 Author: Tommy C. Li <tommycli@chromium.org> Date: Tue Jan 10 00:26:39 2017 [HBD] Intercept Flash navigations in popup windows. This CL turns up the Flash download interception aggression - by making it apply to popup windows as well. This should be fairly harmless. BUG= 676096 Review-Url: https://codereview.chromium.org/2590363003 Cr-Commit-Position: refs/heads/master@{#440518} (cherry picked from commit d60fef6f171bacc82ecaf3f1d4b70450d49ad1cc) Review-Url: https://codereview.chromium.org/2627483002 . Cr-Commit-Position: refs/branch-heads/2924@{#708} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/d3ed2163bfdd00c29966c43c46afbd678ab4a8a9/chrome/browser/plugins/flash_download_interception.cc
,
Jan 11 2017
Verified this issue in Ubuntu 14.04, Windows 10 and Mac 10.12.2 with chrome version #56.0.2924.59 These are the steps followed 1. Navigated to chrome://flags and enabled "Prefer HTML over Flash" flag 2. Navigated to "http://pps-test-a.appspot.com/popup.html" 3. Clicked on the link to open the popup. 4. Clicked on the Download Flash link. Didn't observe any interception in the navigation. Note: ----- In Ubuntu machine, when we click on allow to run the plugin, the browser is requested for browser restart and after restart Flash content played. This restart behavior is not seen in mac and windows Attaching the screen-casts for reference. tommycli@ Could you please look into it and let us know this is the expected behavior for this fix? |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Dec 22 2016