New issue
Advanced search Search tips

Issue 676083 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Dec 2016
Cc:
brucedaw...@chromium.org
jsc...@chromium.org
dpranke@chromium.org
scottmg@chromium.org
jmad...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Compile difference between chromium Win x64 bot and CQ

Project Member Reported by jam@chromium.org, Dec 20 2016 
This change landed fine through CQ:
https://chromium.googlesource.com/chromium/src/+/47cd7960532e2a1bd4e7a987b69c66f632f7f6c9

but broke the Win x64 bot on chromium waterfall:
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/6994/steps/compile/logs/stdio

with this error

FAILED: obj/third_party/angle/src/tests/angle_perftests/UniformsPerf.obj 
ninja -t msvc -e environment.x64 -- C:\b\c\cipd\goma/gomacc.exe "C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/third_party/angle/src/tests/angle_perftests/UniformsPerf.obj.rsp /c ../../third_party/angle/src/tests/perf_tests/UniformsPerf.cpp /Foobj/third_party/angle/src/tests/angle_perftests/UniformsPerf.obj /Fd"obj/third_party/angle/src/tests/angle_perftests_cc.pdb"
c:\b\c\b\win_x64_archive\src\third_party\angle\src\tests\perf_tests\uniformsperf.cpp(148): error C2220: warning treated as error - no 'object' file generated
c:\b\c\b\win_x64_archive\src\third_party\angle\src\tests\perf_tests\uniformsperf.cpp(148): warning C4267: 'initializing': conversion from 'size_t' to 'GLint', possible loss of data
c:\b\c\b\win_x64_archive\src\third_party\angle\src\tests\perf_tests\uniformsperf.cpp(149): warning C4267: 'initializing': conversion from 'size_t' to 'GLint', possible loss of data


I'm surprised that the compile warning level was different on chromium Win x64 and the windows x64 builder on the CQ.

CC'd folks: can someone investigate this more? Thanks

Comment 1 by dpranke@chromium.org, Dec 20 2016 

I think it's more that angle_perftests isn't build or run as part of the CQ, so the only place we'd catch the build failure is on the chromium waterfall where we're building all.

Comment 2 by scottmg@chromium.org, Dec 20 2016 

I think it's not the warning level, it's that the CQ bot builds a specific set of things, but the waterfall builds everything (UniformsPerf.cpp wasn't built on the cq run).

Not sure why or if that has to be like that though.

Comment 3 by dpranke@chromium.org, Dec 20 2016 

we intentionally only build a subset of things on the CQ due to CQ cycle times thanks to the bug filer :).

Comment 4 by jam@chromium.org, Dec 20 2016

Status: WontFix (was: Unconfirmed)
ah ok, thanks for the explanations. I didn't check that; I thought it was building with different settings.
►

Sign in to add a comment