Issue metadata
Sign in to add a comment
|
Windows component build fails with LNK2005 error in media_service_unittests |
||||||||||||||||||||||
Issue descriptionThis breaks builds of "all" or "gn_all". This issue is not visible on the waterfall or try-bots because they do not build "all", only a specific subset of targets (see issue
,
Dec 20 2016
,
Dec 20 2016
,
Dec 20 2016
,
Dec 21 2016
Uploaded https://codereview.chromium.org/2592853002/# to temporarily disable media_service_unittest from building on Win component builds.
,
Dec 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ee841c7f7d1f08996ed6bfc71209395638e135d commit 0ee841c7f7d1f08996ed6bfc71209395638e135d Author: wez <wez@chromium.org> Date: Wed Dec 21 20:36:20 2016 Remove broken targets from "all" and "gn_all", under Windows component builds. The media_service_unittests target fails to link under Windows component builds, due to duplicate symbol definitions. BUG= 676055 Review-Url: https://codereview.chromium.org/2592853002 Cr-Commit-Position: refs/heads/master@{#440204} [modify] https://crrev.com/0ee841c7f7d1f08996ed6bfc71209395638e135d/BUILD.gn [modify] https://crrev.com/0ee841c7f7d1f08996ed6bfc71209395638e135d/media/mojo/services/BUILD.gn
,
Jan 20 2017
Given this only affects a test, change to P2 and move to M58.
,
Mar 16 2017
jrummell is looking at this right now.
,
Mar 16 2017
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e462aab03239f5ddfcec2adc598e5d775fb70e2 commit 6e462aab03239f5ddfcec2adc598e5d775fb70e2 Author: jrummell <jrummell@chromium.org> Date: Thu Jul 13 20:49:47 2017 Fix media_mojo builds Previously media/mojo/sevices:lib was done as a source_set due to issue 670094. Now that that issue is fixed, the intermediate "lib" target is no longer needed. Removing the suppression of duplicate symbols revealed that some of the CdmPromiseTemplate methods end up in multiple modules when doing a component build. So fix CdmPromiseTemplate<>::GetResolveParameterType() implementation to avoid this. This also enables //media/mojo/services/media_service_unittests on Windows (which was disabled due to linking issues that are now fixed). BUG= 676418 , 676055 , 656706 TEST=media_mojo tests compile and run Review-Url: https://codereview.chromium.org/2737513004 Cr-Commit-Position: refs/heads/master@{#486472} [modify] https://crrev.com/6e462aab03239f5ddfcec2adc598e5d775fb70e2/media/BUILD.gn [modify] https://crrev.com/6e462aab03239f5ddfcec2adc598e5d775fb70e2/media/base/cdm_callback_promise.h [modify] https://crrev.com/6e462aab03239f5ddfcec2adc598e5d775fb70e2/media/base/cdm_promise.cc [modify] https://crrev.com/6e462aab03239f5ddfcec2adc598e5d775fb70e2/media/base/cdm_promise.h [modify] https://crrev.com/6e462aab03239f5ddfcec2adc598e5d775fb70e2/media/cdm/BUILD.gn [modify] https://crrev.com/6e462aab03239f5ddfcec2adc598e5d775fb70e2/media/mojo/BUILD.gn [modify] https://crrev.com/6e462aab03239f5ddfcec2adc598e5d775fb70e2/media/mojo/services/BUILD.gn [modify] https://crrev.com/6e462aab03239f5ddfcec2adc598e5d775fb70e2/media/remoting/proto_utils.h
,
Aug 25 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by w...@chromium.org
, Dec 20 2016Status: Assigned (was: Untriaged)