New issue
Advanced search Search tips

Issue 676055 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression

Blocking:
issue 676057



Sign in to add a comment

Windows component build fails with LNK2005 error in media_service_unittests

Project Member Reported by w...@chromium.org, Dec 20 2016

Issue description

This breaks builds of "all" or "gn_all".  This issue is not visible on the waterfall or try-bots because they do not build "all", only a specific subset of targets (see issue 
 

Comment 1 by w...@chromium.org, Dec 20 2016

Owner: xhw...@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by w...@chromium.org, Dec 20 2016

Blocking: 659007

Comment 3 by w...@chromium.org, Dec 20 2016

Blocking: -659007

Comment 4 by w...@chromium.org, Dec 20 2016

Blocking: 676057

Comment 5 by w...@chromium.org, Dec 21 2016

Uploaded https://codereview.chromium.org/2592853002/# to temporarily disable media_service_unittest from building on Win component builds.
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ee841c7f7d1f08996ed6bfc71209395638e135d

commit 0ee841c7f7d1f08996ed6bfc71209395638e135d
Author: wez <wez@chromium.org>
Date: Wed Dec 21 20:36:20 2016

Remove broken targets from "all" and "gn_all", under Windows component builds.

The media_service_unittests target fails to link under Windows component builds, due to duplicate symbol definitions.

BUG= 676055 

Review-Url: https://codereview.chromium.org/2592853002
Cr-Commit-Position: refs/heads/master@{#440204}

[modify] https://crrev.com/0ee841c7f7d1f08996ed6bfc71209395638e135d/BUILD.gn
[modify] https://crrev.com/0ee841c7f7d1f08996ed6bfc71209395638e135d/media/mojo/services/BUILD.gn

Comment 7 by xhw...@chromium.org, Jan 20 2017

Labels: -Pri-1 -M-57 M-58 Pri-2
Given this only affects a test, change to P2 and move to M58.

Comment 8 by xhw...@chromium.org, Mar 16 2017

Owner: jrumm...@chromium.org
Status: Started (was: Assigned)
jrummell is looking at this right now.

Comment 9 by xhw...@chromium.org, Mar 16 2017

Labels: -M-58 M-59
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e462aab03239f5ddfcec2adc598e5d775fb70e2

commit 6e462aab03239f5ddfcec2adc598e5d775fb70e2
Author: jrummell <jrummell@chromium.org>
Date: Thu Jul 13 20:49:47 2017

Fix media_mojo builds

Previously media/mojo/sevices:lib was done as a source_set due to issue
670094. Now that that issue is fixed, the intermediate "lib" target is
no longer needed.

Removing the suppression of duplicate symbols revealed that some of the
CdmPromiseTemplate methods end up in multiple modules when doing a
component build. So fix CdmPromiseTemplate<>::GetResolveParameterType()
implementation to avoid this.

This also enables //media/mojo/services/media_service_unittests on
Windows (which was disabled due to linking issues that are now fixed).

BUG= 676418 , 676055 , 656706 
TEST=media_mojo tests compile and run

Review-Url: https://codereview.chromium.org/2737513004
Cr-Commit-Position: refs/heads/master@{#486472}

[modify] https://crrev.com/6e462aab03239f5ddfcec2adc598e5d775fb70e2/media/BUILD.gn
[modify] https://crrev.com/6e462aab03239f5ddfcec2adc598e5d775fb70e2/media/base/cdm_callback_promise.h
[modify] https://crrev.com/6e462aab03239f5ddfcec2adc598e5d775fb70e2/media/base/cdm_promise.cc
[modify] https://crrev.com/6e462aab03239f5ddfcec2adc598e5d775fb70e2/media/base/cdm_promise.h
[modify] https://crrev.com/6e462aab03239f5ddfcec2adc598e5d775fb70e2/media/cdm/BUILD.gn
[modify] https://crrev.com/6e462aab03239f5ddfcec2adc598e5d775fb70e2/media/mojo/BUILD.gn
[modify] https://crrev.com/6e462aab03239f5ddfcec2adc598e5d775fb70e2/media/mojo/services/BUILD.gn
[modify] https://crrev.com/6e462aab03239f5ddfcec2adc598e5d775fb70e2/media/remoting/proto_utils.h

Status: Fixed (was: Started)

Sign in to add a comment