The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14c2d14e20ae335e22dc9873a700c1ec48dff53d

commit 14c2d14e20ae335e22dc9873a700c1ec48dff53d
Author: jbauman <jbauman@chromium.org>
Date: Wed Dec 21 00:07:35 2016

Supply video_decode_accelerator_unittest args in buildbot json

Some GPU FYI machines don't use isolates, so we need to specify the
arguments to video_decode_accelerator_unittest in the buildbot json
instead.

BUG= 676053 
TBR=kbr@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2597513002
Cr-Commit-Position: refs/heads/master@{#439943}

[modify] https://crrev.com/14c2d14e20ae335e22dc9873a700c1ec48dff53d/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/14c2d14e20ae335e22dc9873a700c1ec48dff53d/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/14c2d14e20ae335e22dc9873a700c1ec48dff53d/testing/buildbot/chromium.gpu.json
[modify] https://crrev.com/14c2d14e20ae335e22dc9873a700c1ec48dff53d/testing/buildbot/gn_isolate_map.pyl

These tests are still failing to find their input file on the bots which don't run the test via isolates:

https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20(NVIDIA%20GeForce%20730)
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win10%20Release%20(New%20Intel)
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win10%20Debug%20(New%20Intel)
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20(AMD%20R5%20230)

I think that the current working directory isn't what the test expects. PWD seems to be C:\b\build\slave\Win7_Release__AMD_R5_230_\build when the test is run:

 PWD: C:\b\build\slave\Win7_Release__AMD_R5_230_\build
 PYTHONPATH: C:\b\rr\tmpapbv3a\rw\checkout\scripts;C:\b\rr\tmpapbv3a\rw\checkout\site_config;C:\b\rr\tmpapbv3a\rw\checkout\third_party;C:\b\rr\tmpapbv3a\rw\checkout\third_party\buildbot_8_4p1;C:\b\rr\tmpapbv3a\rw\checkout\third_party\buildbot_slave_8_4;C:\b\rr\tmpapbv3a\rw\checkout\third_party\coverage-3.7.1;C:\b\rr\tmpapbv3a\rw\checkout\third_party\decorator_3_3_1;C:\b\rr\tmpapbv3a\rw\checkout\third_party\google_api_python_client;C:\b\rr\tmpapbv3a\rw\checkout\third_party\httplib2\python2;C:\b\rr\tmpapbv3a\rw\checkout\third_party\infra_libs;C:\b\rr\tmpapbv3a\rw\checkout\third_party\jinja2;C:\b\rr\tmpapbv3a\rw\checkout\third_party\markupsafe;C:\b\rr\tmpapbv3a\rw\checkout\third_party\mock-1.0.1;C:\b\rr\tmpapbv3a\rw\checkout\third_party\oauth2client;C:\b\rr\tmpapbv3a\rw\checkout\third_party\pyasn1;C:\b\rr\tmpapbv3a\rw\checkout\third_party\pyasn1-modules;C:\b\rr\tmpapbv3a\rw\checkout\third_party\python-rsa;C:\b\rr\tmpapbv3a\rw\checkout\third_party\requests_2_10_0;C:\b\rr\tmpapbv3a\rw\checkout\third_party\setuptools-0.6c11;C:\b\rr\tmpapbv3a\rw\checkout\third_party\sqlalchemy_0_7_1;C:\b\rr\tmpapbv3a\rw\checkout\third_party\sqlalchemy_migrate_0_7_1;C:\b\rr\tmpapbv3a\rw\checkout\third_party\tempita_0_5;C:\b\rr\tmpapbv3a\rw\checkout\third_party\twisted_10_2;C:\b\rr\tmpapbv3a\rw\checkout\third_party\uritemplate;C:\b\rr\tmpapbv3a\rw\checkout\third_party\site-packages;C:\b\rr\tmpapbv3a\rw\checkout\scripts\slave\recipe_modules\test_results\resources;C:\b\rr\tmpapbv3a\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\third_party;C:\b\rr\tmpapbv3a\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\third_party\requests;C:\b\rr\tmpapbv3a\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\third_party\six;C:\b\rr\tmpapbv3a\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\third_party\client-py;C:\b\rr\tmpapbv3a\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\third_party\mock-1.0.1;C:\b\rr\tmpapbv3a\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\third_party\astunparse;C:\b\rr\tmpapbv3a\rw\checkout\scripts\slave\.recipe_deps\recipe_engine;C:\b\build\site_config;C:\b\build\scripts;C:\b\build\scripts\release;C:\b\build\third_party;C:\b\build\third_party\requests_2_10_0;C:\b\build_internal\site_config;C:\b\build_internal\symsrc;C:\b\build\slave;C:\b\build\third_party\buildbot_slave_8_4;C:\b\build\third_party\twisted_10_2;C:\b\build\slave\Win7_Release__AMD_R5_230_\build;C:\b\depot_tools\python276_bin\python27.zip;C:\b\depot_tools\python276_bin\DLLs;C:\b\depot_tools\python276_bin\lib;C:\b\depot_tools\python276_bin\lib\plat-win;C:\b\depot_tools\python276_bin\lib\lib-tk;C:\b\depot_tools\python276_bin
 PYTHONUNBUFFERED: 1
 SYSTEMDRIVE: C:
 SYSTEMROOT: C:\Windows
 TEMP: C:\Users\CHROME~1.LAB\AppData\Local\Temp
 TMP: C:\Users\CHROME~1.LAB\AppData\Local\Temp
 USERDOMAIN: LABS
 USERNAME: chrome-bot
 USERPROFILE: C:\Users\chrome-bot.LABS
 VS110COMNTOOLS: C:\Program Files (x86)\Microsoft Visual Studio 11.0\Common7\Tools\
 WINDIR: C:\Windows

[Running on builder: "Win7 Release (AMD R5 230)"]

C:\b\c\b\Win7_Release__AMD_R5_230_\src\out\Release\video_decode_accelerator_unittest.exe --test-launcher-bot-mode --test_video_data=../../media/test/data/test-25fps.h264:320:240:250:258:50:175:1 --test-launcher-summary-output=c:\users\chrome~1.lab\appdata\local\temp\tmpbq3ko7.json
IMPORTANT DEBUGGING NOTE: batches of tests are run inside their
own process. For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with
--single-process-tests.
Using sharding settings from environment. This is shard 0/1
Using 1 parallel jobs.
[ RUN      ] VideoDecodeAcceleratorTest.TestDecodeTimeMedian

[4916:3392:1221/054857.009:12815918:FATAL:video_decode_accelerator_unittest.cc(1191)] Assert failed: base::ReadFileToString(base::MakeAbsoluteFilePath(filepath), &video_file->data_str). test_video_file: ../../media/test/data/test-25fps.h264


I think the test needs to assume that the input file is relative to the location of the executable on the disk, and not relative to the current working directory.

Only tangentially related: we might want to copy other media tests and use this to get the path: https://cs.chromium.org/chromium/src/media/base/test_data_util.cc?sq=package:chromium&dr=C&rcl=1482322769&l=31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb22e9c7a95045446775bfca936024596222ce8b

commit bb22e9c7a95045446775bfca936024596222ce8b
Author: jbauman <jbauman@chromium.org>
Date: Thu Dec 22 01:35:29 2016

Revert of Run video_decode_accelerator_unittest on windows GPU bots.

Reason for revert:
The test can't find the video test file on some FYI bots.

Original issue's description
> This tests our hardware video decoding path.

> BUG= 663126 
> Cr-Commit-Position: refs/heads/master@{#439614}

BUG= 676053 , 663126 
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2592283002
Cr-Commit-Position: refs/heads/master@{#440303}

[modify] https://crrev.com/bb22e9c7a95045446775bfca936024596222ce8b/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/bb22e9c7a95045446775bfca936024596222ce8b/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/bb22e9c7a95045446775bfca936024596222ce8b/testing/buildbot/chromium.gpu.json
[modify] https://crrev.com/bb22e9c7a95045446775bfca936024596222ce8b/testing/buildbot/gn_isolate_map.pyl

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de22f3cd6cbaeb347cd317629ca8528bf63da152

commit de22f3cd6cbaeb347cd317629ca8528bf63da152
Author: jbauman <jbauman@chromium.org>
Date: Thu Dec 22 20:02:56 2016

Add flag to make vda_unittest input paths relative to media/test/data

On ChromeOS the test launcher specifies the paths as absolute paths or
relative to the CWD. On the GPU bots they need to be specified relative
to the source root, so add the --use-test-data-path flag for that.

BUG= 676053 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2594243002
Cr-Commit-Position: refs/heads/master@{#440481}

[modify] https://crrev.com/de22f3cd6cbaeb347cd317629ca8528bf63da152/media/gpu/BUILD.gn
[modify] https://crrev.com/de22f3cd6cbaeb347cd317629ca8528bf63da152/media/gpu/video_decode_accelerator_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d69f117b2cc60f748e75ea72f33abc346d850a10

commit d69f117b2cc60f748e75ea72f33abc346d850a10
Author: jbauman <jbauman@chromium.org>
Date: Tue Jan 10 01:46:49 2017

Reland of Run video_decode_accelerator_unittest on windows GPU bots.

This tests our hardware video decoding path.

BUG= 663126 , 676053 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2617263002
Cr-Commit-Position: refs/heads/master@{#442445}

[modify] https://crrev.com/d69f117b2cc60f748e75ea72f33abc346d850a10/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/d69f117b2cc60f748e75ea72f33abc346d850a10/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/d69f117b2cc60f748e75ea72f33abc346d850a10/testing/buildbot/chromium.gpu.json
[modify] https://crrev.com/d69f117b2cc60f748e75ea72f33abc346d850a10/testing/buildbot/gn_isolate_map.pyl